From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E78C4C433FE for ; Fri, 30 Sep 2022 20:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231834AbiI3Uak (ORCPT ); Fri, 30 Sep 2022 16:30:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231963AbiI3Uab (ORCPT ); Fri, 30 Sep 2022 16:30:31 -0400 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E70CF6C74B; Fri, 30 Sep 2022 13:30:30 -0700 (PDT) Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-1318106fe2cso6702606fac.13; Fri, 30 Sep 2022 13:30:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=ydbseSGCiGhWnegJ4/rTEcMK4rWRsSZqxah9FKyfgJM=; b=bIzkqsn4783z8j1qQkimP5fgaAXpv2k0/E/2AfnEZ+O2bp9W8/RAjI55CbD/WDGecD TTKsP3NWGwwf4CLkPC4+m90JRG7d416W+0NF/V7yBzST5z8Zb1toOQWGo+r2YMrim71I bqAnsZbI1dBKBaWDCOHOf85hOcJW1NGsKWgbyi71nVo+as7Uy0FTCcwJ2elm0EdWa6gR cA1MlrGCp0TBHvjaPNajXNoQYKz5fkDUTRX3MdJK36CmpCvWb5Ml7cGGyJk7tXaVxjSV C0ZLHt8iA+5FG6ESzoxSD2agE4tHNIUNvrektQwIpY+QtLn+EQViGgW83XnCVjyXWqXC nw9g== X-Gm-Message-State: ACrzQf1t8UxW2+GDVcGjnviA6OLFSGfmYX2VqqKj2l+eUvbvx7C4MQAA 8CgB/2rPxBl6yiVH9afEcHqAZqCTWqs6XEwbzaqZj80h X-Google-Smtp-Source: AMsMyM7T6nr1BYvKp1AkuXZqHWeDItxN8pCYcfsR+CT6+Sgm6Sj6OPqdGn2ty4UfIFNxy+DduZb1q3ohlShJYoxUS80= X-Received: by 2002:a05:6871:14f:b0:131:a644:7c58 with SMTP id z15-20020a056871014f00b00131a6447c58mr5957oab.209.1664569829912; Fri, 30 Sep 2022 13:30:29 -0700 (PDT) MIME-Version: 1.0 References: <20220922041435.709119-1-namhyung@kernel.org> In-Reply-To: From: Namhyung Kim Date: Fri, 30 Sep 2022 13:30:18 -0700 Message-ID: Subject: Re: [PATCH] perf stat: Support old kernels for bperf cgroup counting To: Tejun Heo , Jiri Olsa , Song Liu , Arnaldo Carvalho de Melo Cc: Zefan Li , Johannes Weiner , cgroups , LKML , linux-perf-users , bpf Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 23, 2022 at 8:22 PM Tejun Heo wrote: > > On Wed, Sep 21, 2022 at 09:14:35PM -0700, Namhyung Kim wrote: > > The recent change in the cgroup will break the backward compatiblity in > > the BPF program. It should support both old and new kernels using BPF > > CO-RE technique. > > > > Like the task_struct->__state handling in the offcpu analysis, we can > > check the field name in the cgroup struct. > > > > Signed-off-by: Namhyung Kim > > --- > > Arnaldo, I think this should go through the cgroup tree since it depends > > on the earlier change there. I don't think it'd conflict with other > > perf changes but please let me know if you see any trouble, thanks! > > FWIW, looks fine to me and I'd be happy to route this through the cgroup > tree once it gets acked. Thanks Tejun! Can any perf + bpf folks take a look?