From: Namhyung Kim <namhyung@kernel.org>
To: Yang Jihong <yangjihong1@huawei.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Yao Jin <yao.jin@linux.intel.com>,
gustavoars@kernel.org, mliska@suse.cz,
linux-kernel <linux-kernel@vger.kernel.org>,
zhangjinhao2@huawei.com
Subject: Re: [PATCH] perf annotate: Fix sample events lost in stdio mode
Date: Thu, 11 Mar 2021 23:42:20 +0900 [thread overview]
Message-ID: <CAM9d7chRZq743y1Qb24eLZ5ScXeZs0b_0dyffRcOAwuLdVag7g@mail.gmail.com> (raw)
In-Reply-To: <53ff575f-1fcf-6650-76ad-a0304f6bdf15@huawei.com>
Hi,
On Thu, Mar 11, 2021 at 5:48 PM Yang Jihong <yangjihong1@huawei.com> wrote:
>
> Hello,
>
> On 2021/3/6 16:28, Yang Jihong wrote:
> > In hist__find_annotations function, since have a hist_entry per IP for the same
> > symbol, we free notes->src to signal already processed this symbol in stdio mode;
> > when annotate, entry will skipped if notes->src is NULL to avoid repeated output.
I'm not sure it's still true that we have a hist_entry per IP.
Afaik the default sort key is comm,dso,sym which means it should have a single
hist_entry for each symbol. It seems like an old comment..
> >
> > However, there is a problem, for example, run the following command:
> >
> > # perf record -e branch-misses -e branch-instructions -a sleep 1
> >
> > perf.data file contains different types of sample event.
> >
> > If the same IP sample event exists in branch-misses and branch-instructions,
> > this event uses the same symbol. When annotate branch-misses events, notes->src
> > corresponding to this event is set to null, as a result, when annotate
> > branch-instructions events, this event is skipped and no annotate is output.
> >
> > Solution of this patch is to add a u8 member to struct sym_hist and use a bit to
> > indicate whether the symbol has been processed.
> > Because different types of event correspond to different sym_hist, no conflict
> > occurs.
> > ---
> > tools/perf/builtin-annotate.c | 22 ++++++++++++++--------
> > tools/perf/util/annotate.h | 4 ++++
> > 2 files changed, 18 insertions(+), 8 deletions(-)
> >
> > diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
> > index a23ba6bb99b6..c8c67892ae82 100644
> > --- a/tools/perf/builtin-annotate.c
> > +++ b/tools/perf/builtin-annotate.c
> > @@ -372,15 +372,21 @@ static void hists__find_annotations(struct hists *hists,
> > if (next != NULL)
> > nd = next;
> > } else {
> > - hist_entry__tty_annotate(he, evsel, ann);
> > + struct sym_hist *h = annotated_source__histogram(notes->src,
> > + evsel->idx);
> > +
> > + if (h->processed == 0) {
> > + hist_entry__tty_annotate(he, evsel, ann);
> > +
> > + /*
> > + * Since we have a hist_entry per IP for the same
> > + * symbol, set processed flag of evsel in sym_hist
> > + * to signal we already processed this symbol.
> > + */
> > + h->processed = 1;
> > + }
> > +
> > nd = rb_next(nd);
> > - /*
> > - * Since we have a hist_entry per IP for the same
> > - * symbol, free he->ms.sym->src to signal we already
> > - * processed this symbol.
> > - */
> > - zfree(¬es->src->cycles_hist);
> > - zfree(¬es->src);
> > }
> > }
> > }
> > diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h
> > index 096cdaf21b01..89872bfdc958 100644
> > --- a/tools/perf/util/annotate.h
> > +++ b/tools/perf/util/annotate.h
> > @@ -228,6 +228,10 @@ void symbol__calc_percent(struct symbol *sym, struct evsel *evsel);
> > struct sym_hist {
> > u64 nr_samples;
> > u64 period;
> > +
> > + u8 processed : 1, /* whether symbol has been processed, used for annotate */
> > + __reserved : 7;
I think just a bool member is fine.
> > +
> > struct sym_hist_entry addr[];
> > };
> >
> >
> Please check whether this solution is feasible, look forward to your review.
What about this? (not tested)
diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
index a23ba6bb99b6..a91fe45bd69f 100644
--- a/tools/perf/builtin-annotate.c
+++ b/tools/perf/builtin-annotate.c
@@ -374,13 +374,6 @@ static void hists__find_annotations(struct hists *hists,
} else {
hist_entry__tty_annotate(he, evsel, ann);
nd = rb_next(nd);
- /*
- * Since we have a hist_entry per IP for the same
- * symbol, free he->ms.sym->src to signal we already
- * processed this symbol.
- */
- zfree(¬es->src->cycles_hist);
- zfree(¬es->src);
}
}
}
Thanks,
Namhyung
next prev parent reply other threads:[~2021-03-11 14:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 8:28 [PATCH] perf annotate: Fix sample events lost in stdio mode Yang Jihong
2021-03-11 8:48 ` Yang Jihong
2021-03-11 14:42 ` Namhyung Kim [this message]
2021-03-12 3:24 ` Yang Jihong
2021-03-12 5:49 ` Namhyung Kim
2021-03-12 7:18 ` Yang Jihong
2021-03-12 8:39 ` Namhyung Kim
2021-03-12 10:20 ` Yang Jihong
2021-03-13 2:00 ` Yang Jihong
2021-03-13 2:23 ` Yang Jihong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9d7chRZq743y1Qb24eLZ5ScXeZs0b_0dyffRcOAwuLdVag7g@mail.gmail.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=gustavoars@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mliska@suse.cz \
--cc=peterz@infradead.org \
--cc=yangjihong1@huawei.com \
--cc=yao.jin@linux.intel.com \
--cc=zhangjinhao2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).