From: Namhyung Kim <namhyung@kernel.org>
To: David Ahern <dsahern@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH 2/2] perf sched timehist: Fix use of CPU list with summary option
Date: Tue, 11 Aug 2020 15:42:54 +0900 [thread overview]
Message-ID: <CAM9d7chXrXh1QfJfwsEJ_Tk0_EDNL9ajBE8H0QYCSn_yuLhNUA@mail.gmail.com> (raw)
In-Reply-To: <20200807164937.44921-1-dsahern@kernel.org>
On Sat, Aug 8, 2020 at 1:49 AM David Ahern <dsahern@kernel.org> wrote:
>
> Do not update thread stats or show idle summary unless CPU is in
> the list of interest.
>
> Fixes: c30d630d1bcf ("perf sched timehist: Add support for filtering on CPU")
> Signed-off-by: David Ahern <dsahern@kernel.org>
> ---
> tools/perf/builtin-sched.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index 0c7d599fa555..82ee0dfd1831 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -2575,7 +2575,8 @@ static int timehist_sched_change_event(struct perf_tool *tool,
> }
>
> if (!sched->idle_hist || thread->tid == 0) {
> - timehist_update_runtime_stats(tr, t, tprev);
> + if (!cpu_list || test_bit(sample->cpu, cpu_bitmap))
> + timehist_update_runtime_stats(tr, t, tprev);
>
> if (sched->idle_hist) {
> struct idle_thread_runtime *itr = (void *)tr;
> @@ -2848,6 +2849,9 @@ static void timehist_print_summary(struct perf_sched *sched,
>
> printf("\nIdle stats:\n");
> for (i = 0; i < idle_max_cpu; ++i) {
> + if (!test_bit(i, cpu_bitmap))
Shouldn't it check cpu_list as well?
Thanks
Namhyung
> + continue;
> +
> t = idle_threads[i];
> if (!t)
> continue;
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-08-11 6:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 16:49 [PATCH 2/2] perf sched timehist: Fix use of CPU list with summary option David Ahern
2020-08-11 6:42 ` Namhyung Kim [this message]
2020-08-12 3:12 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9d7chXrXh1QfJfwsEJ_Tk0_EDNL9ajBE8H0QYCSn_yuLhNUA@mail.gmail.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=dsahern@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).