From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] perf report TUI: Remove needless 'dummy' event from menu
Date: Tue, 7 Jul 2020 00:12:21 +0900 [thread overview]
Message-ID: <CAM9d7chmV5itD-2K50qFcktJ2JPWdf=quDX_YL8HTYiHgzByXA@mail.gmail.com> (raw)
In-Reply-To: <20200706115452.GA2772@redhat.com>
On Mon, Jul 6, 2020 at 8:55 PM Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
>
> Em Fri, Jul 03, 2020 at 10:44:28PM +0900, Namhyung Kim escreveu:
> > > @@ -3613,7 +3630,7 @@ int perf_evlist__tui_browse_hists(struct evlist *evlist, const char *help,
> > > int nr_entries = evlist->core.nr_entries;
> > >
> > > single_entry:
> > > - if (nr_entries == 1) {
> > > + if (perf_evlist__single_entry(evlist)) {
> >
> > But I think it cannot cover the event group case below..
>
> Right, we can fix that later, I think, my worry at this point was that
> the simplest case, which is:
>
> # perf record
> ^C
> # perf report
>
> Would get that annoyance :-)
Right, then I suggest moving the 'single_entry' label to inside of the
if statement.
With that applied,
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks
Namhyung
prev parent reply other threads:[~2020-07-06 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200703123431.GG1320@kernel.org>
2020-07-03 13:44 ` [PATCH 1/1] perf report TUI: Remove needless 'dummy' event from menu Namhyung Kim
2020-07-06 11:54 ` Arnaldo Carvalho de Melo
2020-07-06 15:12 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM9d7chmV5itD-2K50qFcktJ2JPWdf=quDX_YL8HTYiHgzByXA@mail.gmail.com' \
--to=namhyung@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).