From: Namhyung Kim <namhyung@kernel.org>
To: Jing Zhang <renyu.zj@linux.alibaba.com>
Cc: Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
John Garry <john.g.garry@oracle.com>,
Shuai Xue <xueshuai@linux.alibaba.com>,
Ian Rogers <irogers@google.com>,
Robin Murphy <robin.murphy@arm.com>,
James Clark <james.clark@arm.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
Ilkka Koskinen <ilkka@os.amperecomputing.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org,
Zhuo Song <zhuo.song@linux.alibaba.com>
Subject: Re: [PATCH v4 0/4] Add JSON metrics for Yitian710 DDR
Date: Tue, 20 Jun 2023 22:00:46 -0700 [thread overview]
Message-ID: <CAM9d7chxMpUUouHsVTEvVEy8RyZ6tNzYbVD=a0Toao=n6cau-w@mail.gmail.com> (raw)
In-Reply-To: <a5486c58-32b6-2d5e-e623-d7844c51474c@linux.alibaba.com>
On Tue, Jun 20, 2023 at 8:08 PM Jing Zhang <renyu.zj@linux.alibaba.com> wrote:
>
>
>
> 在 2023/6/21 上午3:04, Namhyung Kim 写道:
> > Hello,
> >
> > On Tue, Jun 20, 2023 at 12:17 AM Jing Zhang <renyu.zj@linux.alibaba.com> wrote:
> >>
> >> Hi all,
> >>
> >> I add an identifier sysfs file for the yitian710 SoC DDR to allow
> >> userspace to identify the specific implementation of the device,
> >> so that the perf tool can match the corresponding uncore events and
> >> metrics through the identifier. Then added yitian710 SoC DDR
> >> metrics and events alias.
> >>
> >> Change since v3:
> >> - Split the CMN and ali_drw patches. This patchset only contains
> >> ali_drw PMU related patches. The CMN metric related patches will
> >> be in another patchset.
> >> - Link: https://lore.kernel.org/all/1685438374-33287-1-git-send-email-renyu.zj@linux.alibaba.com/
> >>
> >> $perf list:
> >> ...
> >> ali_drw:
> >> chi_rxdat
> >> [A packet at CHI RXDAT interface (write data). Unit: ali_drw]
> >> chi_rxrsp
> >> [A packet at CHI RXRSP interface. Unit: ali_drw]
> >> chi_txdat
> >> [A packet at CHI TXDAT interface (read data). Unit: ali_drw]
> >> chi_txreq
> >> [A packet at CHI TXREQ interface (request). Unit: ali_drw]
> >> cycle
> >> [The ddr cycle. Unit: ali_drw]
> >> ...
> >> ali_drw:
> >> ddr_read_bandwidth.all
> >> [The ddr read bandwidth(MB/s). Unit: ali_drw ]
> >> ddr_write_bandwidth.all
> >> [The ddr write bandwidth(MB/s). Unit: ali_drw ]
> >> ...
> >>
> >> $perf stat -M ddr_read_bandwidth.all ./test
> >>
> >> Performance counter stats for 'system wide':
> >>
> >> 38,150 hif_rd # 2.4 MB/s ddr_read_bandwidth.all
> >> 1,000,957,941 ns duration_time
> >>
> >> 1.000957941 seconds time elapsed
> >>
> >> Jing Zhang (4):
> >> driver/perf: Add identifier sysfs file for Yitian 710 DDR
> >> perf jevents: Add support for Yitian 710 DDR PMU aliasing
> >> perf vendor events: Add JSON metrics for Yitian 710 DDR
> >> docs: perf: Update metric usage for Alibaba's T-Head PMU driver
> >
> > So patch 1 is for the kernel, and patch 2-4 depend on it, right?
> >
>
> Hi Namhyung,
>
> Yes, patch 2-4 depend on patch 1.
>
> > I'm curious why the first patch is needed, presumably the PMU
> > should have 'ali_drw' in the name already. Do we use substring
> > match for the compat name in the JSON metric?
> >
>
> The main purpose of patch 1 is to add an identifier so that the Compat
> field can match the corresponding event when defining aliases or metrics
> for events.
>
> For example, "Unit" can match "ali_drw" in the name and different SoCs may
> be able to match ali_drw, but they may have different events, and even if
> the events are the same, the meanings may be different. Therefore, the
> Compat field is needed to match the Identifier to confirm which type and
> revision of PMU the current SoC has. Therefore, both "Unit" and "Compat"
> need to be matched at the same time. Although it seems that ali_drw is
> redundantly matched currently, it is meaningful for future expansion.
I see, thanks for the explanation.
I think you need to route the kernel patch differently. I can apply the tools
part once the kernel patch gets Acks from others.
Thanks,
Namhyung
next prev parent reply other threads:[~2023-06-21 5:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 7:12 [PATCH v4 0/4] Add JSON metrics for Yitian710 DDR Jing Zhang
2023-06-20 7:12 ` [PATCH v4 1/4] driver/perf: Add identifier sysfs file for Yitian 710 DDR Jing Zhang
2023-06-20 7:12 ` [PATCH v4 2/4] perf jevents: Add support for Yitian 710 DDR PMU aliasing Jing Zhang
2023-06-20 7:12 ` [PATCH v4 3/4] perf vendor events: Add JSON metrics for Yitian 710 DDR Jing Zhang
2023-06-20 7:12 ` [PATCH v4 4/4] docs: perf: Update metric usage for Alibaba's T-Head PMU driver Jing Zhang
2023-06-20 7:30 ` John Garry
2023-06-20 19:04 ` [PATCH v4 0/4] Add JSON metrics for Yitian710 DDR Namhyung Kim
2023-06-21 3:08 ` Jing Zhang
2023-06-21 5:00 ` Namhyung Kim [this message]
2023-06-25 8:58 ` Jing Zhang
2023-06-26 12:44 ` Will Deacon
2023-06-27 7:19 ` Jing Zhang
2023-07-27 12:22 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM9d7chxMpUUouHsVTEvVEy8RyZ6tNzYbVD=a0Toao=n6cau-w@mail.gmail.com' \
--to=namhyung@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=corbet@lwn.net \
--cc=ilkka@os.amperecomputing.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=xueshuai@linux.alibaba.com \
--cc=zhuo.song@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).