From: Namhyung Kim <namhyung@kernel.org>
To: Hao Luo <haoluo@google.com>
Cc: Yonghong Song <yhs@fb.com>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Network Development <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Eugene Loh <eugene.loh@oracle.com>
Subject: Re: [PATCH 1/2] bpf: Adjust BPF stack helper functions to accommodate skip > 0
Date: Thu, 10 Mar 2022 16:33:13 -0800 [thread overview]
Message-ID: <CAM9d7ciKCXD0vcC7rhZFOaXOFTAAWb5w1bXYEee-FZowwzEX9w@mail.gmail.com> (raw)
In-Reply-To: <CA+khW7ieO9QbGYdJQvg8vpYLi-yoUQcZDze8wtpf5qqSiNxosQ@mail.gmail.com>
Hi Hao,
On Thu, Mar 10, 2022 at 4:24 PM Hao Luo <haoluo@google.com> wrote:
> > > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> > > index b0383d371b9a..77f4a022c60c 100644
> > > --- a/include/uapi/linux/bpf.h
> > > +++ b/include/uapi/linux/bpf.h
> > > @@ -2975,8 +2975,8 @@ union bpf_attr {
> > > *
> > > * # sysctl kernel.perf_event_max_stack=<new value>
> > > * Return
> > > - * A non-negative value equal to or less than *size* on success,
> > > - * or a negative error in case of failure.
> > > + * The non-negative copied *buf* length equal to or less than
> > > + * *size* on success, or a negative error in case of failure.
> > > *
> > > * long bpf_skb_load_bytes_relative(const void *skb, u32 offset, void *to, u32 len, u32 start_header)
>
> Namhyung, I think you also need to mirror the change in
> tools/include/uapi/linux/bpf.h
Oh, right. Will update.
Thanks,
Namhyung
next prev parent reply other threads:[~2022-03-11 0:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 8:22 [PATCH 1/2] bpf: Adjust BPF stack helper functions to accommodate skip > 0 Namhyung Kim
2022-03-10 8:22 ` [PATCH 2/2] bpf/selftests: Test skipping stacktrace Namhyung Kim
2022-03-10 23:21 ` Yonghong Song
2022-03-11 0:40 ` Namhyung Kim
2022-03-11 22:23 ` Andrii Nakryiko
2022-03-14 17:28 ` Namhyung Kim
2022-03-10 22:54 ` [PATCH 1/2] bpf: Adjust BPF stack helper functions to accommodate skip > 0 Yonghong Song
2022-03-11 0:23 ` Hao Luo
2022-03-11 0:33 ` Namhyung Kim [this message]
2022-03-11 0:32 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9d7ciKCXD0vcC7rhZFOaXOFTAAWb5w1bXYEee-FZowwzEX9w@mail.gmail.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eugene.loh@oracle.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).