From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>,
Ian Rogers <irogers@google.com>, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/3] tools/lib/fs: Diet cgroupfs_find_mountpoint()
Date: Tue, 29 Dec 2020 14:27:36 +0900 [thread overview]
Message-ID: <CAM9d7cicPSLeMa25=GOsrzMBzk-Oz6XfA1NP=nOsH3fkvgkrmg@mail.gmail.com> (raw)
In-Reply-To: <20201228083120.GA450923@krava>
Hi Jiri,
On Mon, Dec 28, 2020 at 5:31 PM Jiri Olsa <jolsa@redhat.com> wrote:
>
> On Wed, Dec 16, 2020 at 06:05:55PM +0900, Namhyung Kim wrote:
>
> SNIP
>
> > + *p++ = '\0';
> >
> > - while (token != NULL) {
> > - if (subsys && !strcmp(token, subsys)) {
> > - /* found */
> > - fclose(fp);
> > + /* check filesystem type */
> > + if (strncmp(p, "cgroup", 6))
> > + continue;
> >
> > - if (strlen(mountpoint) < maxlen) {
> > - strcpy(buf, mountpoint);
> > - return 0;
> > - }
> > - return -1;
> > - }
> > - token = strtok_r(NULL, ",", &saved_ptr);
> > - }
> > + if (p[6] == '2') {
> > + /* save cgroup v2 path */
> > + strcpy(mountpoint, path);
> > + continue;
> > }
> >
> > - if (!strcmp(type, "cgroup2"))
> > - strcpy(path_v2, mountpoint);
> > + /* now we have cgroup v1, check the options for subsystem */
> > + p += 7;
> > +
> > + p = strstr(p, subsys);
>
> not sure this is a real problem, but this would mixe up for
> cpu/cpuacct/cpuset no? we are using the function for perf_event
> subsys only, but it's globaly availble
Yeah, that's why I added the sanity check below. :)
>
> > + if (p == NULL)
> > + continue;
> > +
> > + /* sanity check: it should be separated by a space or a comma */
> > + if (!strchr(" ,", p[-1]) || !strchr(" ,", p[strlen(subsys)]))
> > + continue;
Here.
Thanks,
Namhyung
> > +
> > + strcpy(mountpoint, path);
> > + break;
> > }
> > + free(line);
> > fclose(fp);
> >
> > - if (path_v2[0] && strlen(path_v2) < maxlen) {
> > - strcpy(buf, path_v2);
> > + if (mountpoint[0] && strlen(mountpoint) < maxlen) {
> > + strcpy(buf, mountpoint);
> > return 0;
> > }
> > return -1;
> > --
> > 2.29.2.684.gfbc64c5ab5-goog
> >
>
next prev parent reply other threads:[~2020-12-29 5:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 9:05 [PATCH 1/3] tools/lib/fs: Prefer cgroup v1 path Namhyung Kim
2020-12-16 9:05 ` [PATCH 2/3] tools/lib/fs: Diet cgroupfs_find_mountpoint() Namhyung Kim
2020-12-28 8:31 ` Jiri Olsa
2020-12-29 5:27 ` Namhyung Kim [this message]
2020-12-29 9:39 ` Jiri Olsa
2020-12-16 9:05 ` [PATCH 3/3] tools/lib/fs: Cache cgroupfs mount point Namhyung Kim
2020-12-29 11:51 ` Arnaldo Carvalho de Melo
2021-01-06 1:33 ` Namhyung Kim
2021-01-08 5:51 ` Namhyung Kim
2021-01-21 4:33 ` Namhyung Kim
2021-02-17 12:58 ` Arnaldo Carvalho de Melo
2021-02-19 10:05 ` Namhyung Kim
2021-02-19 11:37 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM9d7cicPSLeMa25=GOsrzMBzk-Oz6XfA1NP=nOsH3fkvgkrmg@mail.gmail.com' \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).