From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB86DC43331 for ; Wed, 25 Mar 2020 13:20:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8049720870 for ; Wed, 25 Mar 2020 13:20:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585142412; bh=za051gDGb/db/khMgn531TTVJKlx5RDACUa2ohhES2k=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=VXWlYeRy+U+fAK8qV+8nTcg6W8M3IE4Nrln4pG4N9Jcb/6BjfvuY75dswVtRlK5/p JH6bO1Blck5V/uQIMjtwGWshGCSQsawtMjUy2yOwdemWUbTmr5Gld0y4QKaODjyp6g zOT0pqcpUUWcnQQtwQGwUt7EQtSev95OXsRfGjNg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727464AbgCYNUL (ORCPT ); Wed, 25 Mar 2020 09:20:11 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:36600 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726998AbgCYNUK (ORCPT ); Wed, 25 Mar 2020 09:20:10 -0400 Received: by mail-wr1-f66.google.com with SMTP id 31so3050461wrs.3 for ; Wed, 25 Mar 2020 06:20:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ISEybfkjEFb/zuIPAIVpI+Os5qgMM1LlPxoaIqHKxaI=; b=dl65k6vf6NSQCxzVbw2JkdyaiKP/3F4VeT8gEhGlp6Fuwsg4WkDdgYCs8Fxm2To5Ql 51PdsB0fHihuTZJwqgRvkAJAU5qZAA6qtICnpWIMOWdexfoZUJm+OYd4SMbMOn3QO10r lZS1MifOECVcXw4IlEKClN26qsiWIMk8Ogzvl7ltHd+k02Q+ALHvmeFnszegIxGzecLY zZXSDRPrPdAZNJs4xvHZY0nfQb6Xm7u6KDrA8A8g8fnSPS0RCG571L/1wfVNrrE2BY6l Y9ewVfEnMy8Zcc54jqKQf6Spy/nfl6wj8AkzoV9N7jMl4Az8D18arzlroou2KuPAZXBa 5a5Q== X-Gm-Message-State: ANhLgQ3GMLi3veGxFJpCFDniPMCNAbfvnhiXqAf/G4pN3zJ38VHBAAq7 HjnnNSRI8omSOMw9oQKah7QHa6/i8zkOykv9a1o= X-Google-Smtp-Source: ADFU+vtS6h7i4Srpmnt7256dw4I/5wiFmu9FpcWXuS6KRWR/8Gc9MZ03gX8Ecr3FyfCxpdlsKPrbIU/bKt+MEVIPwK0= X-Received: by 2002:adf:a457:: with SMTP id e23mr3466334wra.21.1585142409132; Wed, 25 Mar 2020 06:20:09 -0700 (PDT) MIME-Version: 1.0 References: <20200325124536.2800725-1-namhyung@kernel.org> <20200325130548.GA14102@kernel.org> In-Reply-To: <20200325130548.GA14102@kernel.org> From: Namhyung Kim Date: Wed, 25 Mar 2020 22:19:57 +0900 Message-ID: Subject: Re: [PATCHSET 0/9] perf: Improve cgroup profiling (v6) To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Peter Zijlstra , Ingo Molnar , LKML , Mark Rutland , Alexander Shishkin , Tejun Heo , Li Zefan , Johannes Weiner , Adrian Hunter Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, On Wed, Mar 25, 2020 at 10:05 PM Arnaldo Carvalho de Melo wrote: > > Em Wed, Mar 25, 2020 at 09:45:27PM +0900, Namhyung Kim escreveu: > > Hello, > > > > This work is to improve cgroup profiling in perf. Currently it only > > supports profiling tasks in a specific cgroup and there's no way to > > identify which cgroup the current sample belongs to. So I added > > PERF_SAMPLE_CGROUP to add cgroup id into each sample. It's a 64-bit > > integer having file handle of the cgroup. And kernel also generates > > PERF_RECORD_CGROUP event for new groups to correlate the cgroup id and > > cgroup name (path in the cgroup filesystem). The cgroup id can be > > read from userspace by name_to_handle_at() system call so it can > > synthesize the CGROUP event for existing groups. > > Thanks for the refresh, I'll test this today and all going well push to > Ingo soon, Thanks for doing this! Namhyung