From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Jiri Olsa <jolsa@redhat.com>, Ian Rogers <irogers@google.com>,
Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>,
Leo Yan <leo.yan@linaro.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>,
Kan Liang <kan.liang@linux.intel.com>
Subject: Re: [PATCH V2 22/23] perf tools: Allow system-wide events to keep their own CPUs
Date: Tue, 17 May 2022 16:31:29 -0700 [thread overview]
Message-ID: <CAM9d7cjJups443_V8062cFWn3XNxGCnjM1FeWU9_AHnJnibjVg@mail.gmail.com> (raw)
In-Reply-To: <Yn+wJlzymeAaHHcI@kernel.org>
On Sat, May 14, 2022 at 6:35 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Fri, May 13, 2022 at 07:48:40AM +0300, Adrian Hunter escreveu:
> > On 12/05/22 21:53, Namhyung Kim wrote:
> > > I'm not sure if it's intended. I expect it runs on
> > > cpu 0 or one of the given cpus. Or it runs on both
> > > cpus and returns value in half so that the sum is
> > > the same as the original value (from a cpu).
> >
> > I don't know if there is anything wrong with the way
> > we are handling uncore PMUs, except that I don't know
> > if it is documented anywhere.
>
> Good thing about this conversation is that it will result in
> documentation :-)
>
> Thank you guys for having it and detailing it so nicely.
To move things forward,
Acked-by: Namhyung Kim <namhyung@kernel.org>
for the patchset. I'll try to cleanup the cpu map propagation
with hybrid events later.
Thanks,
Namhyung
next prev parent reply other threads:[~2022-05-17 23:31 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 12:25 [PATCH V2 00/23] perf intel-pt: Better support for perf record --cpu Adrian Hunter
2022-05-06 12:25 ` [PATCH V2 01/23] perf intel-pt: Add a test for system-wide side band Adrian Hunter
2022-05-10 17:18 ` Arnaldo Carvalho de Melo
2022-05-10 17:21 ` Adrian Hunter
2022-05-06 12:25 ` [PATCH V2 02/23] libperf evsel: Add perf_evsel__enable_thread() Adrian Hunter
2022-05-06 17:06 ` Ian Rogers
2022-05-10 17:19 ` Arnaldo Carvalho de Melo
2022-05-06 12:25 ` [PATCH V2 03/23] perf evlist: Use libperf functions in evlist__enable_event_idx() Adrian Hunter
2022-05-10 17:23 ` Arnaldo Carvalho de Melo
2022-05-06 12:25 ` [PATCH V2 04/23] perf auxtrace: Move evlist__enable_event_idx() to auxtrace.c Adrian Hunter
2022-05-10 17:24 ` Arnaldo Carvalho de Melo
2022-05-06 12:25 ` [PATCH V2 05/23] perf auxtrace: Do not mix up mmap idx Adrian Hunter
2022-05-10 17:25 ` Arnaldo Carvalho de Melo
2022-05-06 12:25 ` [PATCH V2 06/23] libperf evlist: Remove ->idx() per_cpu parameter Adrian Hunter
2022-05-10 17:26 ` Arnaldo Carvalho de Melo
2022-05-06 12:25 ` [PATCH V2 07/23] libperf evlist: Move ->idx() into mmap_per_evsel() Adrian Hunter
2022-05-10 17:26 ` Arnaldo Carvalho de Melo
2022-05-06 12:25 ` [PATCH V2 08/23] libperf evlist: Add evsel as a parameter to ->idx() Adrian Hunter
2022-05-10 17:26 ` Arnaldo Carvalho de Melo
2022-05-06 12:25 ` [PATCH V2 09/23] perf auxtrace: Record whether an auxtrace mmap is needed Adrian Hunter
2022-05-10 17:27 ` Arnaldo Carvalho de Melo
2022-05-06 12:25 ` [PATCH V2 10/23] perf auxtrace: Add mmap_needed to auxtrace_mmap_params Adrian Hunter
2022-05-06 20:16 ` Ian Rogers
2022-05-11 7:02 ` Adrian Hunter
2022-05-11 7:01 ` [PATCH V3 " Adrian Hunter
2022-05-06 12:25 ` [PATCH V2 11/23] perf auxtrace: Remove auxtrace_mmap_params__set_idx() per_cpu parameter Adrian Hunter
2022-05-06 20:19 ` Ian Rogers
2022-05-06 12:25 ` [PATCH V2 12/23] perf evlist: Factor out evlist__dummy_event() Adrian Hunter
2022-05-06 12:25 ` [PATCH V2 13/23] perf evlist: Add evlist__add_dummy_on_all_cpus() Adrian Hunter
2022-05-06 13:47 ` Ian Rogers
2022-05-06 15:07 ` Adrian Hunter
2022-05-06 15:35 ` Ian Rogers
2022-05-10 14:55 ` Adrian Hunter
2022-05-10 16:19 ` Ian Rogers
2022-05-10 16:24 ` Arnaldo Carvalho de Melo
2022-05-10 17:32 ` Adrian Hunter
2022-05-11 7:02 ` [PATCH V3 " Adrian Hunter
2022-05-11 22:50 ` Namhyung Kim
2022-05-12 4:33 ` Adrian Hunter
2022-05-12 5:01 ` Namhyung Kim
2022-05-06 12:25 ` [PATCH V2 14/23] perf record: Use evlist__add_dummy_on_all_cpus() in record__config_text_poke() Adrian Hunter
2022-05-06 12:25 ` [PATCH V2 15/23] perf intel-pt: Use evlist__add_dummy_on_all_cpus() for switch tracking Adrian Hunter
2022-05-06 12:25 ` [PATCH V2 16/23] perf intel-pt: Track sideband system-wide when needed Adrian Hunter
2022-05-06 12:25 ` [PATCH V2 17/23] perf tools: Allow all_cpus to be a superset of user_requested_cpus Adrian Hunter
2022-05-06 12:25 ` [PATCH V2 18/23] libperf evlist: Allow mixing per-thread and per-cpu mmaps Adrian Hunter
2022-05-06 12:25 ` [PATCH V2 19/23] libperf evlist: Check nr_mmaps is correct Adrian Hunter
2022-05-06 20:20 ` Ian Rogers
2022-05-06 12:25 ` [PATCH V2 20/23] perf stat: Add requires_cpu flag for uncore Adrian Hunter
2022-05-06 12:25 ` [PATCH V2 21/23] libperf evsel: Add comments for booleans Adrian Hunter
2022-05-06 20:51 ` Ian Rogers
2022-05-11 7:03 ` Adrian Hunter
2022-05-12 5:34 ` Ian Rogers
2022-05-12 11:40 ` Adrian Hunter
2022-05-06 12:26 ` [PATCH V2 22/23] perf tools: Allow system-wide events to keep their own CPUs Adrian Hunter
2022-05-12 5:27 ` Namhyung Kim
2022-05-12 10:34 ` Adrian Hunter
2022-05-12 18:53 ` Namhyung Kim
2022-05-13 4:48 ` Adrian Hunter
2022-05-13 14:12 ` Liang, Kan
2022-05-13 15:21 ` Adrian Hunter
2022-05-13 15:46 ` Liang, Kan
2022-05-13 16:11 ` Adrian Hunter
2022-05-13 16:42 ` Namhyung Kim
2022-05-13 17:32 ` Liang, Kan
2022-05-14 13:35 ` Arnaldo Carvalho de Melo
2022-05-17 23:31 ` Namhyung Kim [this message]
2022-05-06 12:26 ` [PATCH V2 23/23] perf tools: Allow system-wide events to keep their own threads Adrian Hunter
2022-05-08 15:08 ` [PATCH V2 00/23] perf intel-pt: Better support for perf record --cpu Leo Yan
2022-05-09 5:44 ` Adrian Hunter
2022-05-09 8:46 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9d7cjJups443_V8062cFWn3XNxGCnjM1FeWU9_AHnJnibjVg@mail.gmail.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexey.v.bayduraev@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).