From: Namhyung Kim <namhyung@kernel.org>
To: "Bayduraev, Alexey V" <alexey.v.bayduraev@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Alexander Antonov <alexander.antonov@linux.intel.com>,
Alexei Budankov <abudankov@huawei.com>
Subject: Re: [PATCH v5 00/20] Introduce threaded trace streaming for basic perf record operation
Date: Thu, 6 May 2021 21:47:38 -0700 [thread overview]
Message-ID: <CAM9d7cj_nLM2PfSpCjRGKTHdY5G641StHSRgQT-ohWOvJsKEAA@mail.gmail.com> (raw)
In-Reply-To: <9f178dde-751f-9ac9-f5a0-fd1bfba3ca32@linux.intel.com>
On Thu, May 6, 2021 at 5:44 AM Bayduraev, Alexey V
<alexey.v.bayduraev@linux.intel.com> wrote:
>
> Hi,
>
> On 06.05.2021 9:20, Namhyung Kim wrote:
> > Hello,
> >
> > On Tue, May 4, 2021 at 12:05 AM Alexey Bayduraev
> > <alexey.v.bayduraev@linux.intel.com> wrote:
> >>
> <SNIP>>>
> >> Basic analysis of data directories is provided in perf report mode.
> >> Raw dump and aggregated reports are available for data directories,
> >> still with no memory consumption optimizations.
> >
> > Do you have an idea how to improve it?
> >
> > I have to say again that I don't like merely adding more threads to
> > record. Yeah, parallelizing the perf record is good, but we have to
> > think about the perf report (and others) too.
>
> There is your idea about separating tracking records and process them
> first, but these changes can be much larger than my patch and I think
> they looks like independent patch and could be introduced as extension
> of parallel data loading.
>
> I also thought and experimented with the intermediate flushing of
> the ordered queue. This is simple for per-cpu data files (sorted
> by time), but not clear for arbitrary CPU masks.
>
> I think my patch can be the first step to introduce parallel mode
> to the perf tool. It just extends perf-record (already used in our
> vtune tool) and allows to load parallel data in experimental mode.
> Next patches could optimize and extend parallel data loading.
Yeah I agree that we can change it incrementally and good to
know that you are thinking about the next step. :)
Thanks,
Namhyung
next prev parent reply other threads:[~2021-05-07 4:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 7:04 [PATCH v5 00/20] Introduce threaded trace streaming for basic perf record operation Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 01/20] perf record: introduce thread affinity and mmap masks Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 02/20] perf record: introduce thread specific data array Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 03/20] perf record: introduce thread local variable Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 04/20] perf record: stop threads in the end of trace streaming Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 05/20] perf record: start threads in the beginning " Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 06/20] perf record: introduce data file at mmap buffer object Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 07/20] perf record: introduce data transferred and compressed stats Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 08/20] perf record: init data file at mmap buffer object Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 09/20] tools lib: introduce bitmap_intersects() operation Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 10/20] perf record: introduce --threads=<spec> command line option Alexey Bayduraev
2021-05-21 6:50 ` Namhyung Kim
2021-05-04 7:04 ` [PATCH v5 11/20] perf record: document parallel data streaming mode Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 12/20] perf report: output data file name in raw trace dump Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 13/20] perf session: move reader structure to the top Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 14/20] perf session: introduce reader_state in reader object Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 15/20] perf session: introduce reader objects in session object Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 16/20] perf session: introduce decompressor into trace reader object Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 17/20] perf session: move init into reader__init function Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 18/20] perf session: move map/unmap into reader__mmap function Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 19/20] perf session: load single file for analysis Alexey Bayduraev
2021-05-04 7:04 ` [PATCH v5 20/20] perf session: load data directory files " Alexey Bayduraev
2021-05-06 6:20 ` [PATCH v5 00/20] Introduce threaded trace streaming for basic perf record operation Namhyung Kim
2021-05-06 12:43 ` Bayduraev, Alexey V
2021-05-07 4:47 ` Namhyung Kim [this message]
2021-05-06 14:17 ` Andi Kleen
2021-05-07 4:52 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9d7cj_nLM2PfSpCjRGKTHdY5G641StHSRgQT-ohWOvJsKEAA@mail.gmail.com \
--to=namhyung@kernel.org \
--cc=abudankov@huawei.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.antonov@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.v.bayduraev@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).