From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0AC1C3A5A3 for ; Fri, 30 Aug 2019 03:47:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 921222186A for ; Fri, 30 Aug 2019 03:47:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567136826; bh=GSHDfSwOwzHhRsymYAxmor14BoNCFFxb4eivYOnAXe0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=xt4W3KqjcpqmpzyngBqdWwjGR3LRyg8+QiIjx6ppLs3TZ6gNUvcAbdArin8Am3frZ gU4G89UK8D3aza5ZJGwr5NIQwXdlsJPJ6wUFYvoLatBmfV1Yx3qYkDnQlBDDX726VT vlGuKtaM8hg02gvL290D44kPxsPUPOF+ikeCQdXA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727859AbfH3DrF (ORCPT ); Thu, 29 Aug 2019 23:47:05 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:52798 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727066AbfH3DrF (ORCPT ); Thu, 29 Aug 2019 23:47:05 -0400 Received: by mail-wm1-f68.google.com with SMTP id t17so5751489wmi.2 for ; Thu, 29 Aug 2019 20:47:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nBmq40OFeClslDTSVLeJzWGim75xvI1MiiotpLmLOOc=; b=Ze1/pobxpbOij6xoRo8sAfz/5+bxyPq8xOcuwYSnjP15wufh1QreoZdMZE4U8yNxPA 651MVdqkm+ucKFG/Zh4H/vfH7NFhuQi38woAftoWSQDxQ/y4HTmMoruxqQ5arArBXwHz uNQf1vNaMSUMWHyoS8cNb+kN/mHaxeJwK0t79TEhqfy0iZ34ll+vbBfZ8zwT4ShqUn+2 0xWWxrxPlj1/ed6c4FXvf0luBTKWyFkIqIWfqaL9ETeXkzohRJUVpYh91gSQ1SGCgB1f pub1axRla4W18Z3kAPcxRUnt8x1nSYQIZPLVEi85JWsxatznCIZfHeSwQvTPhm0F9l9u 6b6A== X-Gm-Message-State: APjAAAU1V+h/6XV+7kGmshuX+OqjvntzSOvfW2KOzEgn4C3JFSdnKgSV 73KFopCumNn0LZNS7mwcJuV+WHf+0sepbiS5z9E= X-Google-Smtp-Source: APXvYqxkCqUsQpMbxBn3qTkjDD/YYRQNAPSo+siYbobX3CSvnj7FwLZHvvWL1iLF/BeQZOD5sRW1kbnZLJJUvWTuRnY= X-Received: by 2002:a1c:e008:: with SMTP id x8mr3167431wmg.85.1567136823029; Thu, 29 Aug 2019 20:47:03 -0700 (PDT) MIME-Version: 1.0 References: <20190828073130.83800-1-namhyung@kernel.org> <20190828073130.83800-2-namhyung@kernel.org> <20190828094459.GG2369@hirez.programming.kicks-ass.net> In-Reply-To: <20190828094459.GG2369@hirez.programming.kicks-ass.net> From: Namhyung Kim Date: Fri, 30 Aug 2019 12:46:51 +0900 Message-ID: Subject: Re: [PATCH 1/9] perf/core: Add PERF_RECORD_CGROUP event To: Peter Zijlstra Cc: Ingo Molnar , Arnaldo Carvalho de Melo , LKML , Jiri Olsa , Alexander Shishkin , Stephane Eranian , Tejun Heo , Li Zefan , Johannes Weiner , Adrian Hunter Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On Wed, Aug 28, 2019 at 6:45 PM Peter Zijlstra wrote: > > On Wed, Aug 28, 2019 at 04:31:22PM +0900, Namhyung Kim wrote: > > To support cgroup tracking, add CGROUP event to save a link between > > cgroup path and inode number. The attr.cgroup bit was also added to > > enable cgroup tracking from userspace. > > > > This event will be generated when a new cgroup becomes active. > > Userspace might need to synthesize those events for existing cgroups. > > > > As aux_output change is also going on, I just added the bit here as > > well to remove possible conflicts later. > > Why do we want this? I saw below [1] and thought you have the patch introduced aux_output and it's gonna to be merged soon. Also the tooling patches are already in the acme/perf/core so I just wanted to avoid conflicts. Anyway, I'm ok with changing it. Will remove in v2. Thanks Namhyung [1] https://lkml.org/lkml/2019/8/6/586