From: Namhyung Kim <namhyung@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 3/3] perf tools: include termios.h explicitly
Date: Wed, 19 Jun 2013 21:16:20 +0900 [thread overview]
Message-ID: <CAM9d7cjpHEoZaMQE_y5+b1+PZvXrAarzrjtd_GHaNgy1ODy0mQ@mail.gmail.com> (raw)
In-Reply-To: <20130619113326.GA9119@gmail.com>
Hi Ingo,
On Wed, Jun 19, 2013 at 8:33 PM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:
>
>> Building perf for android is failed, because it can't find definition of
>> struct winsize. This definition is in termios.h, so I add this header
>> to util.h to solve the problem. It is missed by commit '2c803e52' which
>> moves get_term_dimensions() from builtin-top.c to util.c, but, missed to
>> move termios.h header.
>>
>> Cc: David Ahern <dsahern@gmail.com>
>> Cc: Namhyung Kim <namhyung@kernel.org>
>> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>
> Is this something we need for v3.10 as well?
>
> Thanks,
>
> Ingo
I think it's good to go to v3.10 and even v3.9 as well:
$ git name-rev --tags --refs=refs/tags/v3.* 2c803e52
2c803e52 tags/v3.9-rc1~173^2~13^2~22
--
Thanks,
Namhyung
next prev parent reply other threads:[~2013-06-19 12:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 1:02 [PATCH 1/3] perf record: support duration option to run during specified time Joonsoo Kim
2013-06-19 1:02 ` [PATCH 2/3] tools lib lk: Fix for cross build Joonsoo Kim
2013-07-12 8:50 ` [tip:perf/urgent] " tip-bot for Joonsoo Kim
2013-06-19 1:02 ` [PATCH 3/3] perf tools: include termios.h explicitly Joonsoo Kim
2013-06-19 11:33 ` Ingo Molnar
2013-06-19 12:16 ` Namhyung Kim [this message]
2013-06-20 1:45 ` Joonsoo Kim
2013-06-19 14:52 ` David Ahern
2013-07-12 8:49 ` [tip:perf/urgent] perf tools: Include " tip-bot for Joonsoo Kim
2013-06-29 0:27 ` [PATCH 1/3] perf record: support duration option to run during specified time Sukadev Bhattiprolu
2013-07-01 5:46 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9d7cjpHEoZaMQE_y5+b1+PZvXrAarzrjtd_GHaNgy1ODy0mQ@mail.gmail.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).