linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <ast@plumgrid.com>
To: David Miller <davem@davemloft.net>
Cc: Ingo Molnar <mingo@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Daniel Borkmann <dborkman@redhat.com>,
	Hannes Frederic Sowa <hannes@stressinduktion.org>,
	Chema Gonzalez <chema@google.com>,
	Eric Dumazet <edumazet@google.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Kees Cook <keescook@chromium.org>,
	Linux API <linux-api@vger.kernel.org>,
	Network Development <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v14 net-next 10/11] bpf: verifier (add verifier core)
Date: Thu, 25 Sep 2014 22:11:30 -0700	[thread overview]
Message-ID: <CAMEtUuzMepq5KkEc0APbMXpY-tZnv0U0xGMFzhc_uT4YeJETtw@mail.gmail.com> (raw)
In-Reply-To: <20140926.004024.1179261758092351350.davem@davemloft.net>

On Thu, Sep 25, 2014 at 9:40 PM, David Miller <davem@davemloft.net> wrote:
> From: Alexei Starovoitov <ast@plumgrid.com>
> Date: Sun, 21 Sep 2014 17:06:50 -0700
>
>> +#define _(OP) ({ int ret = (OP); if (ret < 0) return ret; })
>
> Please do not hide program control flow inside of a macro.

ok.
I'm pretty sure it will be less readable, but I'll get rid off it.
I'm assuming you considered my arguments about it here:
https://lkml.org/lkml/2014/7/2/656
No problem. It's a minor thing.

  reply	other threads:[~2014-09-26  5:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-22  0:06 [PATCH v14 net-next 00/11] eBPF syscall, verifier, testsuite Alexei Starovoitov
2014-09-22  0:06 ` [PATCH v14 net-next 01/11] bpf: introduce BPF syscall and maps Alexei Starovoitov
2014-09-22  0:06 ` [PATCH v14 net-next 02/11] bpf: enable bpf syscall on x64 and i386 Alexei Starovoitov
2014-09-22  0:06 ` [PATCH v14 net-next 03/11] bpf: add lookup/update/delete/iterate methods to BPF maps Alexei Starovoitov
2014-09-22  0:06 ` [PATCH v14 net-next 04/11] bpf: expand BPF syscall with program load/unload Alexei Starovoitov
2014-09-22  0:06 ` [PATCH v14 net-next 05/11] bpf: handle pseudo BPF_CALL insn Alexei Starovoitov
2014-09-22  0:06 ` [PATCH v14 net-next 06/11] bpf: verifier (add docs) Alexei Starovoitov
2014-09-22  0:06 ` [PATCH v14 net-next 07/11] bpf: verifier (add ability to receive verification log) Alexei Starovoitov
2014-09-22  0:06 ` [PATCH v14 net-next 08/11] bpf: handle pseudo BPF_LD_IMM64 insn Alexei Starovoitov
2014-09-22  0:06 ` [PATCH v14 net-next 09/11] bpf: verifier (add branch/goto checks) Alexei Starovoitov
2014-09-22  0:06 ` [PATCH v14 net-next 10/11] bpf: verifier (add verifier core) Alexei Starovoitov
2014-09-26  4:40   ` David Miller
2014-09-26  5:11     ` Alexei Starovoitov [this message]
2014-09-22  0:06 ` [PATCH v14 net-next 11/11] bpf: mini eBPF library, test stubs and verifier testsuite Alexei Starovoitov
2014-09-22 19:57 ` [PATCH v14 net-next 00/11] eBPF syscall, verifier, testsuite Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMEtUuzMepq5KkEc0APbMXpY-tZnv0U0xGMFzhc_uT4YeJETtw@mail.gmail.com \
    --to=ast@plumgrid.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=chema@google.com \
    --cc=davem@davemloft.net \
    --cc=dborkman@redhat.com \
    --cc=edumazet@google.com \
    --cc=hannes@stressinduktion.org \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).