From: Gwendal Grignou <gwendal@chromium.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Benson Leung <bleung@chromium.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
kernel@collabora.com, Guenter Roeck <groeck@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v2 1/6] platform/chrome: cros_ec_sysfs: Modify error handling
Date: Wed, 21 Feb 2018 15:59:51 -0800 [thread overview]
Message-ID: <CAMHSBOU-RtPQ_HqRdCA6-ZgzuWP3cohNJMpRrWNih4YWyvMDRQ@mail.gmail.com> (raw)
In-Reply-To: <20180221170748.27505-2-enric.balletbo@collabora.com>
On Wed, Feb 21, 2018 at 9:07 AM, Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
> From: Gwendal Grignou <gwendal@chromium.org>
>
> When accessing a sysfs attribute, if the EC command fails, -EPROTO is
> now returned instead of an error message as it is unlikely an app is
> parsing the error message to do something meaningful.
> Also, this patch makes use of cros_ec_cmd_xfer_status() instead of
> cros_ec_cmd_xfer() so an error message is printed in the syslog.
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
> ---
> Changes since v1:
> - None
>
> drivers/platform/chrome/cros_ec_sysfs.c | 25 ++++---------------------
> 1 file changed, 4 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chrome/cros_ec_sysfs.c
> index da0a719d32f7..c03621e523a3 100644
> --- a/drivers/platform/chrome/cros_ec_sysfs.c
> +++ b/drivers/platform/chrome/cros_ec_sysfs.c
> @@ -114,15 +114,9 @@ static ssize_t store_ec_reboot(struct device *dev,
> msg->command = EC_CMD_REBOOT_EC + ec->cmd_offset;
> msg->outsize = sizeof(*param);
> msg->insize = 0;
> - ret = cros_ec_cmd_xfer(ec->ec_dev, msg);
> - if (ret < 0) {
> + ret = cros_ec_cmd_xfer_status(ec->ec_dev, msg);
> + if (ret < 0)
> count = ret;
> - goto exit;
> - }
> - if (msg->result != EC_RES_SUCCESS) {
> - dev_dbg(ec->dev, "EC result %d\n", msg->result);
> - count = -EINVAL;
> - }
> exit:
> kfree(msg);
> return count;
> @@ -150,17 +144,11 @@ static ssize_t show_ec_version(struct device *dev,
> msg->command = EC_CMD_GET_VERSION + ec->cmd_offset;
> msg->insize = sizeof(*r_ver);
> msg->outsize = 0;
> - ret = cros_ec_cmd_xfer(ec->ec_dev, msg);
> + ret = cros_ec_cmd_xfer_status(ec->ec_dev, msg);
> if (ret < 0) {
> count = ret;
> goto exit;
> }
> - if (msg->result != EC_RES_SUCCESS) {
> - count = scnprintf(buf, PAGE_SIZE,
> - "ERROR: EC returned %d\n", msg->result);
> - goto exit;
> - }
> -
> r_ver = (struct ec_response_get_version *)msg->data;
> /* Strings should be null-terminated, but let's be sure. */
> r_ver->version_string_ro[sizeof(r_ver->version_string_ro) - 1] = '\0';
> @@ -255,14 +243,9 @@ static ssize_t show_ec_flashinfo(struct device *dev,
> msg->command = EC_CMD_FLASH_INFO + ec->cmd_offset;
> msg->insize = sizeof(*resp);
> msg->outsize = 0;
> - ret = cros_ec_cmd_xfer(ec->ec_dev, msg);
> + ret = cros_ec_cmd_xfer_status(ec->ec_dev, msg);
> if (ret < 0)
> goto exit;
> - if (msg->result != EC_RES_SUCCESS) {
> - ret = scnprintf(buf, PAGE_SIZE,
> - "ERROR: EC returned %d\n", msg->result);
> - goto exit;
> - }
>
> resp = (struct ec_response_flash_info *)msg->data;
>
> --
> 2.16.1
>
next prev parent reply other threads:[~2018-02-22 0:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 17:07 [PATCH v2 0/6] platform/chrome: cros_ec debugfs and sysfs updates Enric Balletbo i Serra
2018-02-21 17:07 ` [PATCH v2 1/6] platform/chrome: cros_ec_sysfs: Modify error handling Enric Balletbo i Serra
2018-02-21 23:59 ` Gwendal Grignou [this message]
2018-02-21 17:07 ` [PATCH v2 2/6] platform/chrome: cros_ec_sysfs: introduce to_cros_ec_dev define Enric Balletbo i Serra
2018-02-21 19:04 ` Andy Shevchenko
2018-02-21 17:07 ` [PATCH v2 3/6] platform/chrome: cros_ec_sysfs: use permission-specific DEVICE_ATTR variants Enric Balletbo i Serra
2018-02-21 19:06 ` Andy Shevchenko
2018-02-21 17:07 ` [PATCH v2 4/6] platform/chrome: cros_ec_debugfs: Use octal permissions '0444' Enric Balletbo i Serra
2018-02-21 17:07 ` [PATCH v2 5/6] platform/chrome: cros_ec_debugfs: Add PD port info to debugfs Enric Balletbo i Serra
2018-03-01 0:26 ` kbuild test robot
2018-03-01 1:02 ` kbuild test robot
2018-02-21 17:07 ` [PATCH v2 6/6] platform/chrome: mfd/cros_ec_dev: Add sysfs entry to set keyboard wake lid angle Enric Balletbo i Serra
2018-03-07 16:28 ` Lee Jones
2018-03-17 5:31 ` Gwendal Grignou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMHSBOU-RtPQ_HqRdCA6-ZgzuWP3cohNJMpRrWNih4YWyvMDRQ@mail.gmail.com \
--to=gwendal@chromium.org \
--cc=andy.shevchenko@gmail.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=kernel@collabora.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).