From: Gwendal Grignou <gwendal@chromium.org>
To: Thierry Escande <thierry.escande@collabora.com>
Cc: Benson Leung <bleung@chromium.org>,
Lee Jones <lee.jones@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Gwendal Grignou <gwendal@chromium.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 2/3] platform/chrome: cros_ec_lpc: Add support for Google Glimmer
Date: Fri, 1 Dec 2017 11:54:11 -0800 [thread overview]
Message-ID: <CAMHSBOU_Xkd=cOCU_KFR_ytY8azjOzLWUNOgeDnE-dGTEW=4Jg@mail.gmail.com> (raw)
In-Reply-To: <1512135743-16529-3-git-send-email-thierry.escande@collabora.com>
This is not required.
Looking with dmidecode, Glimmer reports:
...
BIOS Information
Vendor: coreboot
Version: Google_Glimmer.5216.198.19
...
Therefore, the first entry of cros_ec_lpc_dmi_table will match.
Gwendal.
On Fri, Dec 1, 2017 at 5:42 AM, Thierry Escande
<thierry.escande@collabora.com> wrote:
> This patch adds device information to the DMI table of the cros_ec_lpc
> driver for Google Glimmer devices. Since Google BIOS does not enumerate
> devices in the LPC bus, the cros_ec_lpc driver checks for system
> compatibility and registers the cros_ec device itself.
>
> Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
> ---
> drivers/platform/chrome/cros_ec_lpc.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
> index 0b26a09..4a2fc55 100644
> --- a/drivers/platform/chrome/cros_ec_lpc.c
> +++ b/drivers/platform/chrome/cros_ec_lpc.c
> @@ -365,6 +365,13 @@ static const struct dmi_system_id cros_ec_lpc_dmi_table[] __initconst = {
> DMI_MATCH(DMI_PRODUCT_NAME, "Peppy"),
> },
> },
> + {
> + /* x86-glimmer, the Lenovo Thinkpad Yoga 11e. */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Glimmer"),
> + },
> + },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(dmi, cros_ec_lpc_dmi_table);
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-12-01 19:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 13:42 [PATCH v5 0/3] platform/chrome: Support for cros_ec_accel_legacy driver Thierry Escande
2017-12-01 13:42 ` [PATCH v5 1/3] platform/chrome: cros_ec_lpc: Register the driver if ACPI entry is missing Thierry Escande
2017-12-01 19:49 ` Gwendal Grignou
2017-12-16 6:12 ` Benson Leung
2017-12-16 6:03 ` Benson Leung
2017-12-16 6:04 ` Benson Leung
2017-12-01 13:42 ` [PATCH v5 2/3] platform/chrome: cros_ec_lpc: Add support for Google Glimmer Thierry Escande
2017-12-01 19:54 ` Gwendal Grignou [this message]
2017-12-05 21:55 ` Thierry Escande
2017-12-06 18:04 ` Gwendal Grignou
2017-12-16 6:10 ` Benson Leung
2017-12-01 13:42 ` [PATCH v5 3/3] platform/chrome: Register cros_ec_accel_legacy driver Thierry Escande
2017-12-01 20:00 ` Gwendal Grignou
2017-12-07 9:31 ` Lee Jones
2018-01-18 8:05 ` Gwendal Grignou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMHSBOU_Xkd=cOCU_KFR_ytY8azjOzLWUNOgeDnE-dGTEW=4Jg@mail.gmail.com' \
--to=gwendal@chromium.org \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=jic23@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.escande@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).