From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755209Ab2HRDGm (ORCPT ); Fri, 17 Aug 2012 23:06:42 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:48678 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751524Ab2HRDGh (ORCPT ); Fri, 17 Aug 2012 23:06:37 -0400 MIME-Version: 1.0 In-Reply-To: References: <20120316073213.656519005@fusionio.com> <20120316073512.485027511@fusionio.com> <20120320162157.GE17071@redhat.com> <4F69C62C.7020604@kernel.org> <20120620085724.GA26295@infradead.org> From: Mike Snitzer Date: Fri, 17 Aug 2012 23:06:16 -0400 X-Google-Sender-Auth: R1ko2SMVK7ngKFPBUiXh2vYZ7NY Message-ID: Subject: Re: [patch 1/2]block: handle merged discard request To: "Martin K. Petersen" Cc: Christoph Hellwig , Shaohua Li , Vivek Goyal , axboe@kernel.dk, linux-kernel@vger.kernel.org, neilb@suse.de, linux-scsi@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 21, 2012 at 11:46 PM, Martin K. Petersen wrote: >>>>>> "Christoph" == Christoph Hellwig writes: > >>> There are several additional commands in the pipeline where the 1:1 >>> mapping between DMA size and block range is invalid. I want to get >>> rid of the 1:1 assumption in general so we can handle any command >>> without these evil workarounds. > > Christoph> What's the progress on getting these issues sorted out? > > This has bitrotted for a while. I'll put it on my list. I should finally > have some bandwidth again next week... Hey Martin, I rebased (and fixed/tested) your writesame patches on v3.6-rc2 + jens' for-linus branch, the git tree is available here: https://github.com/snitm/linux/tree/writesame I've also made the updated patchset available here: http://people.redhat.com/msnitzer/patches/upstream/writesame/series.html Should the writesame patches come before any discard merge or 1:1 DMA and block range assumption fixes? NOTE (for others besides martin): http://people.redhat.com/msnitzer/patches/upstream/writesame/0001-block-Clean-up-merge-logic.patch removes all the discard merge hacks; I think it provides a clean baseline to then layer discard merge support back in -- but maybe that's a flawed strategy? Could be I've wasted a few hours by rebasing these patches... regardless, it would be great if you could share what your plans are. Thanks!