From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 964C1C433FE for ; Wed, 23 Nov 2022 15:51:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238025AbiKWPvv (ORCPT ); Wed, 23 Nov 2022 10:51:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237667AbiKWPvb (ORCPT ); Wed, 23 Nov 2022 10:51:31 -0500 Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AF5CC76BE for ; Wed, 23 Nov 2022 07:50:43 -0800 (PST) Received: by mail-vk1-xa33.google.com with SMTP id j24so8938627vkk.0 for ; Wed, 23 Nov 2022 07:50:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WU4MU4ttwXcYHXBFZ9P5T7WQqBKAboHdg0NRXUDXrsA=; b=3RyjLEXpaC9iRKGX9TsCK3o6hXkrNWnpaODYuML+HBwgs9jonVtyM21Jpx2tAPX5IM kkjfDfKHfxhnEoFPteg3oKP3IDIk8W6i2AJmCc2JQ5EegacwVnpFZyq9XcCIpBalb6Os K4yAP0Qp5ATqiDVWs/yeoLn2JKER//gqB5GWaxJjT6YzI+V/53iqQqECVrSA0JYBzf66 n/czP7DJsYe2CZBD0G0m36anizvW0FcK7YlSUFOZOct2Y+zFhwg7WEdhOR0JmwijfnXb jbO6SAgStwBIW5TMeqMHLtn9PNF7rWIOTKw/0uvM2HRLZsDEQEnKlTCLcisqHxY1KuF0 e7QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WU4MU4ttwXcYHXBFZ9P5T7WQqBKAboHdg0NRXUDXrsA=; b=jLFjy2wmaG4weCgg0Eg2PBhNVgTs6mJT5YA8nOYupizao7ZtLLz1RoT+aBr11L7p+H oVMGKHfsPj8oycAb57wLtzGY2G2TvYNlraoO+8pnMWTLvnNT8s+0uL3s5J4RFcAd/1TJ tZ/o5CIX8ueqOUzoz1gTZImf94l1XvKHDyRrKifDqo4FH6PVDYfmABc+QmQIFClVpSJR iurPEOUuPU4XVPHTfaEAHO0/vE1EGi7mWQMy3a32N9MLDFFfKaAUN1CUBPZR1pLMUPEk QIRPO6tmuUJg0h0N7/Xit2AZ6l3BmeS3XUqugs9Iz5EUXUCCfYf5BZuBhMUJ7musrgEJ qOFA== X-Gm-Message-State: ANoB5pk3txhWAgK2ah8YqRARCAy9ypdvEJeqGrwUosbApWepEWglgwrB wStrFIIC75wG2KPrd6tqoh1fWiOGOXXG7Ep2cncoaA== X-Google-Smtp-Source: AA0mqf6YOZ2UMlLjZn/kmjXvs1p3FnFg3qJY0KklFeZEPATLy4J9SfAXdbsg0QbFMiu7XbdDSbnvNlRT7bTlkgW0XW4= X-Received: by 2002:ac5:c915:0:b0:3b8:7fbd:9554 with SMTP id t21-20020ac5c915000000b003b87fbd9554mr5657416vkl.27.1669218642612; Wed, 23 Nov 2022 07:50:42 -0800 (PST) MIME-Version: 1.0 References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-13-uwe@kleine-koenig.org> In-Reply-To: From: Bartosz Golaszewski Date: Wed, 23 Nov 2022 16:50:31 +0100 Message-ID: Subject: Re: [PATCH 012/606] gpio: pca953x: Convert to i2c's .probe_new() To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Linus Walleij , linux-i2c@vger.kernel.org, kernel@pengutronix.de, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 23, 2022 at 10:48 AM Bartosz Golaszewski wrote: > > On Fri, Nov 18, 2022 at 11:46 PM Uwe Kleine-K=C3=B6nig wrote: > > > > From: Uwe Kleine-K=C3=B6nig > > > > .probe_new() doesn't get the i2c_device_id * parameter, so determine > > that explicitly in the probe function. > > > > Signed-off-by: Uwe Kleine-K=C3=B6nig > > --- > > drivers/gpio/gpio-pca953x.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c > > index 6e67867e1dcd..a59d61cd44b2 100644 > > --- a/drivers/gpio/gpio-pca953x.c > > +++ b/drivers/gpio/gpio-pca953x.c > > @@ -1050,9 +1050,9 @@ static int device_pca957x_init(struct pca953x_chi= p *chip, u32 invert) > > return ret; > > } > > > > -static int pca953x_probe(struct i2c_client *client, > > - const struct i2c_device_id *i2c_id) > > +static int pca953x_probe(struct i2c_client *client) > > { > > + const struct i2c_device_id *i2c_id =3D i2c_client_get_device_id= (client); > > struct pca953x_platform_data *pdata; > > struct pca953x_chip *chip; > > int irq_base =3D 0; > > @@ -1376,7 +1376,7 @@ static struct i2c_driver pca953x_driver =3D { > > .of_match_table =3D pca953x_dt_ids, > > .acpi_match_table =3D pca953x_acpi_ids, > > }, > > - .probe =3D pca953x_probe, > > + .probe_new =3D pca953x_probe, > > .remove =3D pca953x_remove, > > .id_table =3D pca953x_id, > > }; > > -- > > 2.38.1 > > > > Applied, thanks! > > Bartosz Same story as with the other ones: Acked-by: Bartosz Golaszewski