From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Kent Gibson <warthog618@gmail.com>,
linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Suresh Balakrishnan <suresh.balakrishnan@intel.com>
Subject: Re: [PATCH v1 1/2] gpiolib: Never return internal error codes to user space
Date: Wed, 24 Nov 2021 13:46:47 +0100 [thread overview]
Message-ID: <CAMRc=McPGR4xejGWxCUkEsNiOmwkf1kctXB-K73xU9q3r7+CFA@mail.gmail.com> (raw)
In-Reply-To: <YZ0928wfsYIBJYcQ@smile.fi.intel.com>
On Tue, Nov 23, 2021 at 8:16 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Thu, May 20, 2021 at 04:39:50PM +0200, Bartosz Golaszewski wrote:
> > On Thu, May 20, 2021 at 3:15 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > >
> > > On Thu, May 20, 2021 at 4:08 PM Bartosz Golaszewski
> > > <bgolaszewski@baylibre.com> wrote:
> > > > On Wed, May 19, 2021 at 10:30 AM Andy Shevchenko
> > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > On Wed, May 19, 2021 at 04:04:34PM +0800, Kent Gibson wrote:
> > > > > > On Wed, May 19, 2021 at 10:45:16AM +0300, Andy Shevchenko wrote:
> > > > > > > On Wed, May 19, 2021 at 07:24:51AM +0800, Kent Gibson wrote:
> > > > > > > > On Tue, May 18, 2021 at 06:50:12PM +0300, Andy Shevchenko wrote:
> > >
> > > ...
> > >
> > > > > > > > > Fixes: d7c51b47ac11 ("gpio: userspace ABI for reading/writing GPIO lines")
> > > > > > > > > Fixes: 61f922db7221 ("gpio: userspace ABI for reading GPIO line events")
> > > > > > > > > Fixes: 3c0d9c635ae2 ("gpiolib: cdev: support GPIO_V2_GET_LINE_IOCTL and GPIO_V2_LINE_GET_VALUES_IOCTL")
> > >
> > > ...
> > >
> > > > > > > > You immediately revert this patch in patch 2.
> > > > > > > > My understanding is that is not allowed within a patch set.
> > > > > > >
> > > > > > > > Why split the patches instead of going direct to the new helper?
> > > > > > >
> > > > > > > It's for backporting to make it easier. (I deliberately left the context above)
> > > > > > >
> > > > > > > I can fold them if maintainers think it's okay to do.
> > > > > > >
> > > > > >
> > > > > > Not sure what the constraints are on backporting, but wouldn't it be
> > > > > > simpler and cleaner to backport the new helper?
> > > > >
> > > > > Logically (and ideally) it would be three different patches:
> > > > > 1) introduce helper
> > > > > 2) use helper
> > > > > 3) fix places where it's needed to be done
> > > > >
> > > > > But the above scheme doesn't fit backporting idea (we don't backport new
> > > > > features and APIs without really necessity). So, the options left are:
> > > > >
> > > > > Option a: One patch (feels a bit like above)
> > > > > Option b: Two patches like in this series (yes, you are correct about
> > > > > disadvantages)
> > > > >
> > > > > > But, as you say, it is the maintainers' call.
> > >
> > > > Third option is to backport this patch but apply the helper
> > > > immediately to master.
> > >
> > > If I got you correctly, you want to have two patches, one for
> > > backporting and one for current, correct? But how can we backport
> > > something which has never been upstreamed?
> > >
> >
> > Well we would not technically backport anything - there would be one
> > patch for mainline and a separate fix for stable.
>
> So, what should I do here?
Send a separate patch for stable branches that fixes the issue and
fold this patch into the next one in the series for master.
Bart
prev parent reply other threads:[~2021-11-24 14:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 15:50 [PATCH v1 1/2] gpiolib: Never return internal error codes to user space Andy Shevchenko
2021-05-18 15:50 ` [PATCH v1 2/2] gpiolib: Introduce gpiod_request_user() helper Andy Shevchenko
2021-05-25 0:27 ` Linus Walleij
2021-05-18 23:24 ` [PATCH v1 1/2] gpiolib: Never return internal error codes to user space Kent Gibson
2021-05-19 7:45 ` Andy Shevchenko
2021-05-19 8:04 ` Kent Gibson
2021-05-19 8:30 ` Andy Shevchenko
2021-05-20 13:02 ` Bartosz Golaszewski
2021-05-20 13:14 ` Andy Shevchenko
2021-05-20 14:39 ` Bartosz Golaszewski
2021-11-23 19:15 ` Andy Shevchenko
2021-11-24 12:46 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=McPGR4xejGWxCUkEsNiOmwkf1kctXB-K73xU9q3r7+CFA@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.balakrishnan@intel.com \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).