linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Enrico Weigelt, metux IT consult" <lkml@metux.net>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Markus Elfring <Markus.Elfring@web.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Keerthy <j-keerthy@ti.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-gpio <linux-gpio@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap_resource()
Date: Tue, 25 Jun 2019 09:32:27 +0200	[thread overview]
Message-ID: <CAMRc=McPjPtDFL2m=n5fWm-fHvVbDzMopb9r=RkzS+TshMJBAQ@mail.gmail.com> (raw)
In-Reply-To: <20190625073016.GA18381@kroah.com>

wt., 25 cze 2019 o 09:30 Greg Kroah-Hartman
<gregkh@linuxfoundation.org> napisał(a):
>
> On Tue, Jun 25, 2019 at 09:10:25AM +0200, Bartosz Golaszewski wrote:
> > pon., 24 cze 2019 o 20:22 Enrico Weigelt, metux IT consult
> > <lkml@metux.net> napisał(a):
> > >
> > > On 24.06.19 12:46, Bartosz Golaszewski wrote:
> > >
> > > >> The patch seems pretty trivial and doesn't change any actual code, so
> > > >> I don't see hard resons for rejecting it.
> > > >>
> > > >
> > > > In its current form it makes the code even less readable. The #ifdef
> > > > should actually be one line lower and touch the comment instead of the
> > > > EXPORT_SYMBOL() related to a different function.
> > >
> > > Okay, that missing newline should be fixed (as well as the extra one
> > > after the #ifdef). Besides that, I don't see any further problems.
> > >
> >
> > Are we sure this even changes something? Does kernel documentation get
> > generated according to current config options? I really think this
> > patch just pollutes the history for now apparent reason.
> >
> > Greg, could you give your opinion on this?
>
> Why are you all arguing with a all-but-instinguishable-from-a-bot
> persona about a patch that I will never apply?
>
> greg k-h

Oh so it's another troll then? Good to know, ignoring from now on.

Thanks,
Bart

  reply	other threads:[~2019-06-25  7:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21 16:26 [PATCH] drivers: depend on HAS_IOMEM for devm_platform_ioremap_resource() Bartosz Golaszewski
2019-02-21 16:47 ` Greg Kroah-Hartman
2019-02-21 19:55 ` Andy Shevchenko
2019-02-21 19:56   ` Andy Shevchenko
2019-02-22  9:04     ` Bartosz Golaszewski
2019-02-22 10:24       ` Andy Shevchenko
2019-02-22 14:22   ` Rob Herring
2019-02-22 16:22     ` Linus Walleij
2019-06-14 16:50 ` [PATCH] drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap_resource() Markus Elfring
2019-06-24  8:29   ` Bartosz Golaszewski
2019-06-24 10:05     ` Enrico Weigelt, metux IT consult
2019-06-24 10:46       ` Bartosz Golaszewski
2019-06-24 11:00         ` Markus Elfring
2019-06-24 18:22         ` [PATCH] " Enrico Weigelt, metux IT consult
2019-06-25  7:10           ` Bartosz Golaszewski
2019-06-25  7:30             ` Greg Kroah-Hartman
2019-06-25  7:32               ` Bartosz Golaszewski [this message]
2019-06-25  7:51                 ` Markus Elfring
2019-06-25  7:42               ` Markus Elfring
2019-06-24 10:51     ` [PATCH] " Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMRc=McPjPtDFL2m=n5fWm-fHvVbDzMopb9r=RkzS+TshMJBAQ@mail.gmail.com' \
    --to=brgl@bgdev.pl \
    --cc=Markus.Elfring@web.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=j-keerthy@ti.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@metux.net \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).