From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
Kent Gibson <warthog618@gmail.com>,
linux-gpio <linux-gpio@vger.kernel.org>,
linux-doc <linux-doc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 8/9] gpio: mockup: use the generic 'gpio-line-names' property
Date: Mon, 28 Sep 2020 10:44:38 +0200 [thread overview]
Message-ID: <CAMRc=McfBLaE=N12z29JjTDJ0ABzC8OW4rPWeeSU82kag+9pgQ@mail.gmail.com> (raw)
In-Reply-To: <20200925123000.GD3956970@smile.fi.intel.com>
On Fri, Sep 25, 2020 at 6:41 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Fri, Sep 25, 2020 at 01:40:10PM +0200, Bartosz Golaszewski wrote:
> > On Fri, Sep 25, 2020 at 11:03 AM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Thu, Sep 24, 2020 at 01:38:41PM +0200, Bartosz Golaszewski wrote:
> > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > >
> > > > GPIO line names are currently created by the driver from the chip label.
> > > > We'll want to support custom formats for line names (for instance: to
> > > > name all lines the same) for user-space tests so create them in the
> > > > module init function and pass them to the driver using the standard
> > > > 'gpio-line-names' property.
> > >
> > > ...
> > >
> > > > + if (gpio_mockup_named_lines) {
> > > > + line_names = gpio_mockup_make_line_names(chip_label,
> > > > + ngpio);
> > > > + if (!line_names) {
> > > > + platform_driver_unregister(&gpio_mockup_driver);
> > > > + gpio_mockup_unregister_pdevs();
> > > > + return -ENOMEM;
> > > > + }
> > >
> > > > + properties[prop++] = PROPERTY_ENTRY_STRING_ARRAY_LEN(
> > > > + "gpio-line-names",
> > > > + line_names, ngpio);
> > >
> > > Forgot to update GPIO_MOCKUP_MAX_PROP?
> > >
> >
> > No, there are still three properties: chip-label, nr-gpios and
> > gpio-line-names. Same answer to patch 8/9.
> >
> > > > + }
> > >
> > > ...
> > >
> > > > + kfree_strarray(line_names, line_names ? ngpio : 0);
> > >
> > > Perhaps you may check for NULL pointer in the kfree_strarray() and drop ternary
> > > here?
> > >
> >
> > I did in the previous series and you told me to not to. :)
>
> Hmm... What was my argument? What was wrong with me? free() should be NULL-aware.
>
Well, it is - your just need to make sure ngpio is 0 too. :)
I'll revert back to having the NULL check.
Bartosz
next prev parent reply other threads:[~2020-09-28 8:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 11:38 [PATCH 0/9] gpio: mockup: refactoring + documentation Bartosz Golaszewski
2020-09-24 11:38 ` [PATCH 1/9] lib: string_helpers: provide kfree_strarray() Bartosz Golaszewski
2020-09-25 8:48 ` Andy Shevchenko
2020-09-25 11:32 ` Bartosz Golaszewski
2020-09-25 12:28 ` Andy Shevchenko
2020-09-24 11:38 ` [PATCH 2/9] Documentation: gpio: add documentation for gpio-mockup Bartosz Golaszewski
2020-09-24 11:38 ` [PATCH 3/9] gpio: mockup: drop unneeded includes Bartosz Golaszewski
2020-09-24 11:38 ` [PATCH 4/9] gpio: mockup: use KBUILD_MODNAME Bartosz Golaszewski
2020-09-24 11:38 ` [PATCH 5/9] gpio: mockup: use pr_fmt() Bartosz Golaszewski
2020-09-24 16:04 ` Joe Perches
2020-09-24 11:38 ` [PATCH 6/9] gpio: mockup: remove unneeded return statement Bartosz Golaszewski
2020-09-24 11:38 ` [PATCH 7/9] gpio: mockup: pass the chip label as device property Bartosz Golaszewski
2020-09-25 9:00 ` Andy Shevchenko
2020-09-24 11:38 ` [PATCH 8/9] gpio: mockup: use the generic 'gpio-line-names' property Bartosz Golaszewski
2020-09-25 9:03 ` Andy Shevchenko
2020-09-25 11:40 ` Bartosz Golaszewski
2020-09-25 12:30 ` Andy Shevchenko
2020-09-28 8:44 ` Bartosz Golaszewski [this message]
2020-09-28 9:11 ` Andy Shevchenko
2020-09-28 9:58 ` Bartosz Golaszewski
2020-09-24 11:38 ` [PATCH 9/9] gpio: mockup: refactor the module init function Bartosz Golaszewski
2020-09-25 9:04 ` [PATCH 0/9] gpio: mockup: refactoring + documentation Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=McfBLaE=N12z29JjTDJ0ABzC8OW4rPWeeSU82kag+9pgQ@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=corbet@lwn.net \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).