From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 735EDC33C9E for ; Sat, 11 Jan 2020 10:24:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A17E205F4 for ; Sat, 11 Jan 2020 10:24:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="apGZuJag" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730964AbgAKKYH (ORCPT ); Sat, 11 Jan 2020 05:24:07 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:37169 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730797AbgAKKXG (ORCPT ); Sat, 11 Jan 2020 05:23:06 -0500 Received: by mail-io1-f66.google.com with SMTP id k24so4761420ioc.4 for ; Sat, 11 Jan 2020 02:23:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vU2+i2GO3WHRg+jV5YDCjUlPGe/9rhbunzFmSeBXEWs=; b=apGZuJagwClqbxqX07aG9onUwlXW+H6wqSje8JaxzprMtEUYR5NB1bvF15EYuwiCMe J/6L1a0tS80/ibAhAGjIApfioD9g98McJp6RDN+tDdZWxUZ7ePfYbizd/kcOtS18BrLb 8yBicbElljp0ywh37I6WLhmWlzMukCi2WNOrZQ1HPb4CyOqN+VhSN0NeCqTNrh0YsctB 5q8UlfGE+WDxXcKItttXVsB5ZKS2u49Y5b+jjIsvM7z/LBqyns97E7vt2c8S6WEPES5Z ZXFdudV/uob5aIHPpn56BS8LcdHKJOtRsVDXgJFWX4s73n9/2fASW2Z8uFAK64DDxD6S tc3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vU2+i2GO3WHRg+jV5YDCjUlPGe/9rhbunzFmSeBXEWs=; b=ZsOlHyH2Dj4eSkFHggiwvzdMUXiXfqIPCFswSs6U9SIvkGbvzpLqIn8usc0jJpcFQy qIxmJgRqseZ//3aHd6PKta1xg2kOt3I0KtG7plFkjsnC0t+cZ7j5/YR5JB7W3wvdVhc4 KRR53Z0vAximHc36DEpIVIiGxTQI7oNJCUDplZYXwcsBSs7ZNos/hbnXzwRV49g//X3U eRu+xodMSK4rpfNYpb1N0G7wSfTGlcTt5101xpY/T5FkRorYDZduh+j4H3YoxCqePBKD kZ0Att+vCj2ALY9DTvcCOTf5XG/euKH7bAn2jWqny5lRoWz/644dh54D3ijN92Pvb/SP scKA== X-Gm-Message-State: APjAAAWTCLSGBHG/W8ShGTy/xAxOfUAYUXOuEMTWkp9/M4+pZL6vsB7y M5VKYUa9cJ4NOI5BbnS49W17RpaDu/zNfnIrxp6mWg== X-Google-Smtp-Source: APXvYqzpvyDTaxYdZtZGArwDIzWwAKCU3pngPn20GQcVt5O6FZInAzvQo0UuAlIgrGMYv/s2x55pDLoDBJmaLmIxHFg= X-Received: by 2002:a05:6602:2352:: with SMTP id r18mr5779111iot.220.1578738185997; Sat, 11 Jan 2020 02:23:05 -0800 (PST) MIME-Version: 1.0 References: <20191210100753.11090-1-brgl@bgdev.pl> <20200110182841.GT8314@dtor-ws> In-Reply-To: <20200110182841.GT8314@dtor-ws> From: Bartosz Golaszewski Date: Sat, 11 Jan 2020 11:22:55 +0100 Message-ID: Subject: Re: [PATCH] input: max77650-onkey: add of_match table To: Dmitry Torokhov Cc: Linux Kernel Mailing List , Linux Input , Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org pt., 10 sty 2020 o 19:28 Dmitry Torokhov napisa= =C5=82(a): > > On Tue, Dec 10, 2019 at 11:07:53AM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > We need the of_match table if we want to use the compatible string in > > the pmic's child node and get the onkey driver loaded automatically. > > Do we really need of_match table or adding > Not really. Technically not anyway but we merged bindings that define it (at the time I didn't know any better) and seems we're stuck with it. Please see the discussion below a similar patch for regulator subsystem[1]. > MODULE_ALIAS("platform:max77650-onkey"); > This is already in there, but if someone defines the compatible in the device tree as per bindings, the module won't be loaded despite the MODULE_ALIAS() definition. > will work as well? > > In general, do we ever instantiate onkey portion from device tree? Or > is it always an MFD cell that is instantiated unconditionally? > Bart [1] https://lkml.org/lkml/2019/12/10/271