From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F58FC433FE for ; Tue, 29 Mar 2022 12:31:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236354AbiC2Mcq (ORCPT ); Tue, 29 Mar 2022 08:32:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236323AbiC2Mci (ORCPT ); Tue, 29 Mar 2022 08:32:38 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0343C5F4C2 for ; Tue, 29 Mar 2022 05:30:53 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id c10so16393278ejs.13 for ; Tue, 29 Mar 2022 05:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nRQGNy0JNeG8yPE1QXXWKqsK/KgT2iVgd9NOSAmnpao=; b=rghn0NZ7veo+c7F9TgovwmfTphDZN1nzJMzcXj5lds+VNPPlWVx4s9Km9UFuESnj9C 0j6zPwG/Xf6D92JpGQDO2SsY514Cc3dispUkIKCGzRnO4C9HS7T9TWQ6L1NWItI9HoVR Wk/smMInsq69ioZO8yNZDu546rixqBUH1Q7RKjgyI+USlKpBx73H+Jxrz2inmb2EkToU H2vf7Sa/pckmLcWFoAxiMBDzr7UgHBsB2Q8hra4/Kl5ny0G8cLhgWaE+yEkyTutDGHt1 d/7ehdh+gvbKH2tMg6SF+fI/PRBhqZLpgBB/Oz9YxV+MxEClGvdSUz2pl20OT0F+Mpvd d2oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nRQGNy0JNeG8yPE1QXXWKqsK/KgT2iVgd9NOSAmnpao=; b=LGR/X6ykzuSzscbvYCS90xnT6TrdRLOGV8IeyM/EaU2hFJgEsYp38GXMsgLWIKT3NN JFw68ssfyt/eXpuzDly8UlrVwqzZoVU0WfLUUTc/U2XuhUgv6K0rsc+l3R2n7dhHpDn2 D7X97T+wkJkhlKNmkk8ZdNEaz95Da3CdEPnCZF2hA7APBz3nqHq8NNBHcQPSrGrM9bCp TSKYWK2H9JTBiozKmk0Gw0rGUcmMBTiap5NUH/X4YtCsn7GNZ/gw77krpCvR/lf2eW2+ yafhX1YRQLc8yUpBpAUkwZn5q2fndyc6AVGvZFddGmLbVBXUujuSz83KK8ZaQx/Ig2HJ iLMQ== X-Gm-Message-State: AOAM533uIkWbpgjMhC35pJmtquw/NcxhaS+e63xTqpMy5HCaobrmCdAP mXq4PdMx3gfq85X8Z0+gjHgiTsh8/Mjqzb0GK4hWjw== X-Google-Smtp-Source: ABdhPJyPZNX8y3gOGfSZgg3AGAll74j9kjPNXJs0DTpnrEh1/wBVEgROdTkgglF1+DGDwH7nabIubcnQbpp8LiNpfow= X-Received: by 2002:a17:907:d2a:b0:6e0:963c:97d9 with SMTP id gn42-20020a1709070d2a00b006e0963c97d9mr28430774ejc.736.1648557051475; Tue, 29 Mar 2022 05:30:51 -0700 (PDT) MIME-Version: 1.0 References: <20220326165909.506926-1-benni@stuerz.xyz> <20220326165909.506926-9-benni@stuerz.xyz> In-Reply-To: <20220326165909.506926-9-benni@stuerz.xyz> From: Bartosz Golaszewski Date: Tue, 29 Mar 2022 14:30:40 +0200 Message-ID: Subject: Re: [PATCH 09/22] gpio-winbond: Use C99 initializers To: =?UTF-8?Q?Benjamin_St=C3=BCrz?= Cc: Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Russell King , linux@simtec.co.uk, Krzysztof Kozlowski , alim.akhtar@samsung.com, Thomas Gleixner , mingo@redhat.com, Borislav Petkov , dave.hansen@linux.intel.com, hpa@zytor.com, robert.moore@intel.com, "Rafael J . Wysocki" , lenb@kernel.org, 3chas3@gmail.com, laforge@gnumonks.org, Arnd Bergmann , Greg Kroah-Hartman , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , Linus Walleij , mike.marciniszyn@cornelisnetworks.com, dennis.dalessandro@cornelisnetworks.com, jgg@ziepe.ca, pali@kernel.org, Dmitry Torokhov , isdn@linux-pingi.de, Benjamin Herrenschmidt , fbarrat@linux.ibm.com, ajd@linux.ibm.com, "David S . Miller" , Jakub Kicinski , Paolo Abeni , nico@fluxnic.net, loic.poulain@linaro.org, kvalo@kernel.org, pkshih@realtek.com, Bjorn Helgaas , Linux ARM , Linux Kernel Mailing List , linux-samsung-soc@vger.kernel.org, linux-ia64@vger.kernel.org, ACPI Devel Maling List , devel@acpica.org, linux-atm-general@lists.sourceforge.net, netdev , linux-edac@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-rdma@vger.kernel.org, Linux Input , linuxppc-dev@lists.ozlabs.org, Linux Media Mailing List , wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 26, 2022 at 6:00 PM Benjamin St=C3=BCrz wrot= e: > > This replaces comments with C99's designated > initializers because the kernel supports them now. > > Signed-off-by: Benjamin St=C3=BCrz > --- > drivers/gpio/gpio-winbond.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpio/gpio-winbond.c b/drivers/gpio/gpio-winbond.c > index 7f8f5b02e31d..0b637fdb407c 100644 > --- a/drivers/gpio/gpio-winbond.c > +++ b/drivers/gpio/gpio-winbond.c > @@ -249,7 +249,7 @@ struct winbond_gpio_info { > }; > > static const struct winbond_gpio_info winbond_gpio_infos[6] =3D { > - { /* 0 */ > + [0] =3D { > .dev =3D WB_SIO_DEV_GPIO12, > .enablereg =3D WB_SIO_GPIO12_REG_ENABLE, > .enablebit =3D WB_SIO_GPIO12_ENABLE_1, > @@ -266,7 +266,7 @@ static const struct winbond_gpio_info winbond_gpio_in= fos[6] =3D { > .warnonly =3D true > } > }, > - { /* 1 */ > + [1] =3D { > .dev =3D WB_SIO_DEV_GPIO12, > .enablereg =3D WB_SIO_GPIO12_REG_ENABLE, > .enablebit =3D WB_SIO_GPIO12_ENABLE_2, > @@ -277,7 +277,7 @@ static const struct winbond_gpio_info winbond_gpio_in= fos[6] =3D { > .datareg =3D WB_SIO_GPIO12_REG_DATA2 > /* special conflict handling so doesn't use conflict data= */ > }, > - { /* 2 */ > + [2] =3D { > .dev =3D WB_SIO_DEV_GPIO34, > .enablereg =3D WB_SIO_GPIO34_REG_ENABLE, > .enablebit =3D WB_SIO_GPIO34_ENABLE_3, > @@ -294,7 +294,7 @@ static const struct winbond_gpio_info winbond_gpio_in= fos[6] =3D { > .warnonly =3D true > } > }, > - { /* 3 */ > + [3] =3D { > .dev =3D WB_SIO_DEV_GPIO34, > .enablereg =3D WB_SIO_GPIO34_REG_ENABLE, > .enablebit =3D WB_SIO_GPIO34_ENABLE_4, > @@ -311,7 +311,7 @@ static const struct winbond_gpio_info winbond_gpio_in= fos[6] =3D { > .warnonly =3D true > } > }, > - { /* 4 */ > + [4] =3D { > .dev =3D WB_SIO_DEV_WDGPIO56, > .enablereg =3D WB_SIO_WDGPIO56_REG_ENABLE, > .enablebit =3D WB_SIO_WDGPIO56_ENABLE_5, > @@ -328,7 +328,7 @@ static const struct winbond_gpio_info winbond_gpio_in= fos[6] =3D { > .warnonly =3D true > } > }, > - { /* 5 */ > + [5] =3D { > .dev =3D WB_SIO_DEV_WDGPIO56, > .enablereg =3D WB_SIO_WDGPIO56_REG_ENABLE, > .enablebit =3D WB_SIO_WDGPIO56_ENABLE_6, > -- > 2.35.1 > Acked-by: Bartosz Golaszewski