From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 83B25C4332F
	for <linux-kernel@archiver.kernel.org>; Mon, 13 Dec 2021 18:30:44 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S239070AbhLMSam (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 13 Dec 2021 13:30:42 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41210 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S236094AbhLMSal (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Dec 2021 13:30:41 -0500
Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 953F3C061748
        for <linux-kernel@vger.kernel.org>; Mon, 13 Dec 2021 10:30:40 -0800 (PST)
Received: by mail-ed1-x536.google.com with SMTP id v1so55525989edx.2
        for <linux-kernel@vger.kernel.org>; Mon, 13 Dec 2021 10:30:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=bgdev-pl.20210112.gappssmtp.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=g3YkPQNm8HT8uPOkwlxqDDosj5jXAidcs7NGVfMzGdQ=;
        b=PLD5ugaoBxsfh13ItjXwt+RNxiwpsjiaasa4t/MUMpINo5uqktSh5tco4R6UweAQgK
         MqvGKm8ztEc/M3G6KVIYytn8Bm8hkmzeOB2gUQZaSuMwlTEneVyDnM/nMi8JbKVOY81/
         fPqWP04HenfQmN39e89XLHFapkLjIvDliA525SJI54yu4heczQ03Fqm7kOr6n2pB9RH6
         R+RmokoP1evfSqPD0UuNQUA91Dlu16XEsYjmrT6yz4vwCg+N22NpseGGJICSklRu5wfl
         5WNKXzYJEFBV6KR0sYPKce8YyOmalZV1OoydswBghAjVXZl65mgjUte03EmT7nopsyNU
         FbZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=g3YkPQNm8HT8uPOkwlxqDDosj5jXAidcs7NGVfMzGdQ=;
        b=o2A8XY8N1KYuHAnWS/jMdstuQyzAoMXT9bTOIOloIZV3oWYT9ABSlmb5n1A39C1al8
         o74tdk4BJh/Q6KbrpRTtZ/cn2t8tyPsSCNY5+WX4tCbtQU1n/TODXtbHFQ3SpS5EYGWs
         1m9MtRkEkHnK1+22lzCVafjH9/lWS74+RI3fhyBPkJypbxpeKnyrqH2drEDulG8rImwi
         n8FuQeGHWmYpJhb/qSSWiqgLc6T9rL+CjEKauYdBjyRsI/bFEex6BD66QsAm1iKrt3f7
         xgCUeHFOQOpiazV7rB2ZSqIG0vvLqCsipR0pBQrGKnFObB7C0vkGTXNnHCMb0UVd0C8D
         8ImA==
X-Gm-Message-State: AOAM531T54CazYtELAndlz+EZyEdSzWd4/aBj0XYngUGzV/mYw9YWlm2
        NwUbY2B6j3nNLYsc/SoPmdQPD/gY268/qTdsJMdTLvOs3vc=
X-Google-Smtp-Source: ABdhPJyiubzERra+E8YaazWpZr091U7oC8cB59PSHrp6pM086prR5B207yEmyjou/vFhSLrfFhB+yjJkKc7RYvFcV9M=
X-Received: by 2002:a17:907:6289:: with SMTP id nd9mr51979ejc.101.1639420239120;
 Mon, 13 Dec 2021 10:30:39 -0800 (PST)
MIME-Version: 1.0
References: <20211213162625.18081-1-brgl@bgdev.pl> <Ybd3DT5e3fCP5JiS@smile.fi.intel.com>
In-Reply-To: <Ybd3DT5e3fCP5JiS@smile.fi.intel.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Mon, 13 Dec 2021 19:30:28 +0100
Message-ID: <CAMRc=MdOeB_xFTodeAhNBK3E0OuDRceW9wFGK_iPB8=GjGoj_Q@mail.gmail.com>
Subject: Re: [PATCH -next] selftests: gpio: gpio-sim: remove bashisms
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Kent Gibson <warthog618@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Shuah Khan <shuah@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-kselftest@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 13, 2021 at 5:39 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Mon, Dec 13, 2021 at 05:26:25PM +0100, Bartosz Golaszewski wrote:
> > '==' is a bashisms and not understood by POSIX shell. Drop it from
> > gpio-sim selftests.
>
> > -             if [ "$BANK" == "live" ] || [ "$BANK" == "dev_name" ]; then
> > +             if [ "$BANK" = "live" ] || [ "$BANK" = "dev_name" ]; then
>
> While at it, no need to fork `test` twice, isn't it?
>
>                 if [ "$BANK" = "live" -o "$BANK" = "dev_name" ]; then
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

I'll send a follow-up for that, thanks for spotting it.

Bart