From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752652AbdF2LDz (ORCPT ); Thu, 29 Jun 2017 07:03:55 -0400 Received: from mail-it0-f46.google.com ([209.85.214.46]:38847 "EHLO mail-it0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752150AbdF2LDt (ORCPT ); Thu, 29 Jun 2017 07:03:49 -0400 MIME-Version: 1.0 X-Originating-IP: [194.228.20.36] In-Reply-To: References: <1498218316-27860-1-git-send-email-brgl@bgdev.pl> <1498218316-27860-2-git-send-email-brgl@bgdev.pl> From: Bartosz Golaszewski Date: Thu, 29 Jun 2017 13:03:47 +0200 Message-ID: Subject: Re: [PATCH] gpiolib: fix filtering out unwanted events To: Linus Walleij Cc: "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-06-29 11:33 GMT+02:00 Linus Walleij : > On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski wrote: > >> GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of >> GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE. >> >> The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get >> evaluated to true even if only one event type was requested. >> >> Fix it by checking both RISING & FALLING flags explicitly. >> >> Signed-off-by: Bartosz Golaszewski > > Patch applied for fixes. > > Yours, > Linus Walleij Thanks. I think this should also go to linux-stable (e.g. 4.9 LTS is affected). Will you forward it or should I do it myself? Thanks, Bartosz