From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 1/3] irq/irq_sim: add a simple interrupt simulator framework
Date: Mon, 14 Aug 2017 11:54:22 +0200 [thread overview]
Message-ID: <CAMRc=MdZXbY4Lp-a=qu+d7civ9PFQi2niXqzeFYqvVF03sy=Cw@mail.gmail.com> (raw)
In-Reply-To: <20170812124357.56ddd01d@archlinux>
2017-08-12 13:43 GMT+02:00 Jonathan Cameron <jic23@kernel.org>:
> On Tue, 1 Aug 2017 16:50:26 +0200
> Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
>> Implement a simple, irq_work-based framework for simulating
>> interrupts. Currently the API exposes routines for initializing and
>> deinitializing the simulator object, enqueueing the interrupts and
>> retrieving the allocated interrupt numbers based on the offset of the
>> dummy interrupt in the simulator struct.
>>
>> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> Looks good to me.
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Only tiny thing is the lack of a specified license for the code...
I'll send a v3 with license added.
> + checkpatch is warning about wrong file mode...
> #105:
> new file mode 100644
>
> Though I have no idea why...
>
I think this only says that a file was created with given mode, it's
not a warning. The actual warning is about missing a new entry in
MAINTAINERS.
>> --- a/init/Kconfig
>> +++ b/init/Kconfig
>> @@ -23,6 +23,10 @@ config CONSTRUCTORS
>> config IRQ_WORK
>> bool
>>
>> +config IRQ_SIM
>> + bool
> You could make this tristate, but then the handling of the
> users would get complex so perhaps given it's so small boolean
> is the way to go.
>
Nah, irq_work is built-in to at even greater size. Let's just leave it
like this, especially when only testing modules select it.
Thanks,
Bartosz
next prev parent reply other threads:[~2017-08-14 9:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 14:50 [PATCH v2 0/3] simulated interrupts Bartosz Golaszewski
2017-08-01 14:50 ` [PATCH v2 1/3] irq/irq_sim: add a simple interrupt simulator framework Bartosz Golaszewski
2017-08-12 11:43 ` Jonathan Cameron
2017-08-14 9:54 ` Bartosz Golaszewski [this message]
2017-08-14 10:04 ` Jonathan Cameron
2017-08-01 14:50 ` [PATCH v2 2/3] irq/irq_sim: add a devres variant of irq_sim_init() Bartosz Golaszewski
2017-08-12 11:47 ` Jonathan Cameron
2017-08-01 14:50 ` [PATCH v2 3/3] gpio: mockup: use irq_sim Bartosz Golaszewski
2017-08-12 11:46 ` Jonathan Cameron
2017-08-13 12:16 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MdZXbY4Lp-a=qu+d7civ9PFQi2niXqzeFYqvVF03sy=Cw@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=bamvor.zhangjian@linaro.org \
--cc=corbet@lwn.net \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).