archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <>
To: David Miller <>
Cc: John Crispin <>,
	Sean Wang <>,
	Mark Lee <>,
	Jakub Kicinski <>,
	Matthias Brugger <>,
	netdev <>,
	Linux ARM <>,
	"moderated list:ARM/Mediatek SoC..." 
	Linux Kernel Mailing List <>,
	Fabien Parent <>,
	Stephane Le Provost <>,
	Pedro Tsai <>,
	Andrew Perepech <>,
	Bartosz Golaszewski <>
Subject: Re: [PATCH] net: ethernet: mtk-star-emac: simplify interrupt handling
Date: Thu, 11 Jun 2020 23:04:07 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

czw., 11 cze 2020 o 21:51 David Miller <> napisał(a):
> From: Bartosz Golaszewski <>
> Date: Thu, 11 Jun 2020 16:01:39 +0200
> > Unfortunately after thorough testing of current mainline, we noticed the
> > driver has become unstable under heavy load. While this is hard to
> > reproduce, it's quite consistent in the driver's current form.
> Maybe you should work to pinpoint the actual problem before pushing forward
> a solution?

Why would you assume I didn't? I've been trying to figure out this
problem since Monday but since I'm not sure how much time I will be
able to spend on this going forward and due to the fact that this is
now upstream (and broken), I sent this patch. As I said: it doesn't
impact performance nor is this solution inherently wrong - many
drivers do it this way.

I will continue working on this driver on and off so I *do* intend on
fixing it as well as extending it with more support, hence the FIXME
and previous TODO.

Best regards,

  reply	other threads:[~2020-06-11 21:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11 14:01 Bartosz Golaszewski
2020-06-11 19:51 ` David Miller
2020-06-11 21:04   ` Bartosz Golaszewski [this message]
2020-06-15 20:31 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] net: ethernet: mtk-star-emac: simplify interrupt handling' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).