From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9103FC7EE29 for ; Tue, 13 Jun 2023 09:50:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241590AbjFMJu3 (ORCPT ); Tue, 13 Jun 2023 05:50:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241606AbjFMJuL (ORCPT ); Tue, 13 Jun 2023 05:50:11 -0400 Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 483472705 for ; Tue, 13 Jun 2023 02:49:35 -0700 (PDT) Received: by mail-vs1-xe33.google.com with SMTP id ada2fe7eead31-43dc17feb22so315423137.3 for ; Tue, 13 Jun 2023 02:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20221208.gappssmtp.com; s=20221208; t=1686649774; x=1689241774; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lHShPJI1ND84wlAQIXTdkKHqiP9kaIQnFJziQlEFXAg=; b=W6V4ONuGe+cz/0uk/uN5Iqq0aT/OfJ6B9RiOB0CdGwIzS6c6ziD2B5nKU9nEklZFod 3ilSqxRl3pklQ5KRqx0j4ktIUbx25z2edb6WY294QkZsXfM2J/X+wug1aSX0NprsmZ5Y KCQEca4HhEkM6S9qJsUkogsPU+JJ4q8bRDoVZmhq4y8wvWneOf6rl2vcBOPIiVMxQqOL XklEO9/DYK6kBfs66OJ3+roaXwfEfqZi0331CzihEAbErEx9cXxlXmeWQFmqZzs2fJid EtvIZkBReT9vSeUMj828rvEBXQ4SzgEXomPbmotCE3YkNpAYtPIw/eY1iJhEJ+NPb4Cy ek7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686649774; x=1689241774; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lHShPJI1ND84wlAQIXTdkKHqiP9kaIQnFJziQlEFXAg=; b=Sb11rVqgU3qnOktHECGrX4V7m1KPAZ14SnwmRit/aXGQd+/NthJU0Pk08e63/WjpXG M2Sum1AEFjVKR7d5qvZrmYM9k8xfogoakzOTjOO7qhXl9hp+WNE3/15nF6Pei+tvbqb+ UydO1l29EnfRy/HNdmFE1r9qfPYI24np29sSn8jjYfC3kJb8CYuP8tbdl3/xq+zb0Y9g Q9AbdekOLyCMBJ4JXyb/YAoUtew7mfL6eVGGrTn2MGXhUj73JdRhiN2JDb7PkIIARift QNnu7BPMeChA4gmy1jwhHheo3rq6ers7nrlaAa5azNwqYjFL47iBMEbPVFjvxNPn1TRT HJSQ== X-Gm-Message-State: AC+VfDwYH8MaH3fEV4QOxOFJrH7bCzlufQkTRsRAb88Cog8KgQdyPx1Q igaQtmSXN6lIeFIZFl+YHpEPqN5PinJ+pmrNmnARRQ== X-Google-Smtp-Source: ACHHUZ6d07s72MWiYVxCx5UTb5HEFEm5bhKysx4M+2vQ5aEkZntWDPGMGEALVUWuh8IGKijZ+Q5f8rP5+9BSaUl6N9s= X-Received: by 2002:a67:ff88:0:b0:439:3128:587d with SMTP id v8-20020a67ff88000000b004393128587dmr5259878vsq.28.1686649774444; Tue, 13 Jun 2023 02:49:34 -0700 (PDT) MIME-Version: 1.0 References: <1686249772-26231-1-git-send-email-manikanta.guntupalli@amd.com> In-Reply-To: <1686249772-26231-1-git-send-email-manikanta.guntupalli@amd.com> From: Bartosz Golaszewski Date: Tue, 13 Jun 2023 11:49:23 +0200 Message-ID: Subject: Re: [PATCH V2] gpio: zynq: fix zynqmp_gpio not an immutable chip warning To: Manikanta Guntupalli Cc: michal.simek@xilinx.com, michal.simek@amd.com, git@amd.com, shubhrajyoti.datta@xilinx.com, srinivas.neeli@xilinx.com, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.goud@amd.com, manion05gk@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 8, 2023 at 8:43=E2=80=AFPM Manikanta Guntupalli wrote: > > Make the struct irq_chip const and flag it as IRQCHIP_IMMUTABLE, > call gpiochip_disable_irq() in the .irq_mask() callback and > gpiochip_enable_irq() in the .irq_unmask() callback to fix > "gpio gpiochip1: (zynqmp_gpio): not an immutable chip" warning. > > Signed-off-by: Manikanta Guntupalli > --- Applied, thanks! Bart