From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9579FC433EF for ; Mon, 14 Mar 2022 14:47:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240441AbiCNOsI (ORCPT ); Mon, 14 Mar 2022 10:48:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240684AbiCNOsG (ORCPT ); Mon, 14 Mar 2022 10:48:06 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67ED24163B for ; Mon, 14 Mar 2022 07:46:56 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id g3so20302115edu.1 for ; Mon, 14 Mar 2022 07:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tejnvpcItznP+XieeMEeqmEZtG7EKmEE378s7VoibWA=; b=dDLUQ6796YMEiUp31VGhDzOTCJr1qPyT996cw3CMfVjF2raAunLZqee5fmKQC/ZKET 8kNjpMX7hXBBd3ITSA2ZdyFyCRAASlr39t+ZkyFCi7UPtLnpTP2SZUQj7b90Tp8AgjYB 78IFCI/CbnDsY6OhmVYtoKxx+kUYQImiaKqX1jeGHu/oKH9mkQqF/Z2QrP9HxBa2rGhj PbEaICb5JmwdKuEhVlPseLUJYBlF1YSUieZvN6MoVl16R7LpfMZFy8/ARis7FvAaHRO1 TZqup7X0JHfaOF1KJ++xjeHwfBUDikPdIdN+i0Dw2maagYT4r0KHbJwrXrR8omFkW9/Q 6B0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tejnvpcItznP+XieeMEeqmEZtG7EKmEE378s7VoibWA=; b=4eCm/WDIdMu97bJsMOOC0elLgigL/MoAhr8NIZhEIJ9tgYI2BQ1BNSCRmF0RBiU1H3 jkMANzG0WOrK80YDvBOWmytQYK1o0HrjtcoRWzM8nM+U9xZRCKwE0QBKtg7kI8sY+D+m ZN18F0XhpeGHPqE4HjxX8+lzS0BNQ+yBg6jN+61XLQZKUkd4xMiNjwi+SiHjqagp0sZ8 Ott8cgaZ8P+aYIFmVSgBpNqvPqsGgDChU+eXMd/Kb0Otgctql1o5udS/9DmjoKurGR99 HWf0fsdohQM459f4JRM34sMGPRpKObtt5K9za9zo/ED/6cSogE9ouRRZ+ejrMvvLNT0w HLhQ== X-Gm-Message-State: AOAM530J664pssEDzC5pb3RRGiM1lP9leN8ldXdzM0Zw5k3Vjkce3dvf vkm64SEaj260rs+NL10I9uHxdGegJsKDU01rPBPiQxT7Xd8ffw== X-Google-Smtp-Source: ABdhPJwSUtZwdFVddUfnEml4egreDeBD098RwDKR5/7dPMwJXBj/gYOWAdLCLzX+HmZAkJSD2+2Ya1d2KQwu9LEE3/A= X-Received: by 2002:a05:6402:5cb:b0:415:e04a:5230 with SMTP id n11-20020a05640205cb00b00415e04a5230mr21115927edx.352.1647269214900; Mon, 14 Mar 2022 07:46:54 -0700 (PDT) MIME-Version: 1.0 References: <20220311181958.4487-1-kris@embeddedTS.com> In-Reply-To: From: Bartosz Golaszewski Date: Mon, 14 Mar 2022 15:46:44 +0100 Message-ID: Subject: Re: [PATCH] gpio: ts4900: Fix comment formatting and grammar To: Andy Shevchenko Cc: Kris Bahnsen , Linus Walleij , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 12, 2022 at 2:06 PM Andy Shevchenko wrote: > > On Fri, Mar 11, 2022 at 8:20 PM Kris Bahnsen wrote: > > > > The issues were pointed out after the prior commit was applied > > Missed period in the above sentence. > > Otherwise LGTM, > Reviewed-by: Andy Shevchenko > > > Signed-off-by: Kris Bahnsen > > --- > > drivers/gpio/gpio-ts4900.c | 12 +++++++----- > > 1 file changed, 7 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpio/gpio-ts4900.c b/drivers/gpio/gpio-ts4900.c > > index d918d2df4de2..ede605b8e098 100644 > > --- a/drivers/gpio/gpio-ts4900.c > > +++ b/drivers/gpio/gpio-ts4900.c > > @@ -55,8 +55,9 @@ static int ts4900_gpio_direction_input(struct gpio_chip *chip, > > { > > struct ts4900_gpio_priv *priv = gpiochip_get_data(chip); > > > > - /* Only clear the OE bit here, requires a RMW. Prevents potential issue > > - * with OE and data getting to the physical pin at different times. > > + /* > > + * Only clear the OE bit here, requires a RMW. Prevents a potential issue > > + * with OE and DAT getting to the physical pin at different times. > > */ > > return regmap_update_bits(priv->regmap, offset, TS4900_GPIO_OE, 0); > > } > > @@ -68,9 +69,10 @@ static int ts4900_gpio_direction_output(struct gpio_chip *chip, > > unsigned int reg; > > int ret; > > > > - /* If changing from an input to an output, we need to first set the > > - * proper data bit to what is requested and then set OE bit. This > > - * prevents a glitch that can occur on the IO line > > + /* > > + * If changing from an input to an output, we need to first set the > > + * GPIO's DAT bit to what is requested and then set the OE bit. This > > + * prevents a glitch that can occur on the IO line. > > */ > > regmap_read(priv->regmap, offset, ®); > > if (!(reg & TS4900_GPIO_OE)) { > > -- > > 2.11.0 > > > > > -- > With Best Regards, > Andy Shevchenko Added the missing period and applied. Bart