From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8808C6FA83 for ; Wed, 7 Sep 2022 11:18:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229956AbiIGLSE (ORCPT ); Wed, 7 Sep 2022 07:18:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229650AbiIGLSC (ORCPT ); Wed, 7 Sep 2022 07:18:02 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 202FBA5719 for ; Wed, 7 Sep 2022 04:18:01 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id u6so19120605eda.12 for ; Wed, 07 Sep 2022 04:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=dZIh4+/56mPZ8GNJ0DQtWOl7S488zyoNCksTXVS4XdY=; b=VQ6UrKP2Ppw5g7e/Y4qcRdVDeCmUJMzs7joV+B4t8ncxhcBJIkf4z2eN9HY+A8FH2u 28PSq0leDUdV/Ce3Mk8N6YOp0YvlptviGdXp+LcqWWiJZz8arYfmIP/8FiuvUchkbPIy G7MHEsVpJFr7LnHH7omvOCMceCYO3A1k92MGnCZ7HVa+dJmXdHzCJqyJbgDInaoKn1pC AYxW8yCczu52agaQcsnuaS79r/jL69MJeHTSqILIDgzCq5VtH2l+KjQ+dpHLFcoNw+FK Bwcyb6kkBcX+Ps5PE+6iXhSHChUjYHpPL4qC0dBcVuGA5dRhh0H+W+/xH0zOSL1wUGJb Puug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=dZIh4+/56mPZ8GNJ0DQtWOl7S488zyoNCksTXVS4XdY=; b=vY1IjJTLeBnEsOQL8+51wdu+uBVVkpAyfPSTJCFFdMKAu0v8tTp3RkRakKGURY2kDb y/kfaYu0D+Bu1PGn3S3o4KcU1AJyUa166ij/X5BY4ZNxVF22QVODUdSuhdSmJFCjFtHh 2feyW9cLyKRRfwuwl0+J15+I51muer1NlinWWgLYSg0NdAakadhdRlHTru2UX2fobG7y Sein7WBCKmrgpK4CyWmHH3JyIMsg6cxPMOq04K7qMiukZSpD1Bbp3ra9jE9APC1VuYHM lDj32ptGSRwop9cQT0MgaeAQFJ+vB1L+kmAHgS0imQqc6skIcsCfxJ+25ibUcbIzgJ6o hrWg== X-Gm-Message-State: ACgBeo1XftCiFxApjDSW21wNr0EhftXHr++kO0Wj2oKiHThXvqCpBm+Y DLF05knq7ygnLs7/trZdhh5jEG8lmNRDvJP3tMxfEkOSJsw= X-Google-Smtp-Source: AA6agR6EW00/7vkJywy6kMguX7icdT7VZ02IGp5o8iDc7yvy/ODvZlLvwivz+1E23l5HysN4M6uUnfPg/dawCWF73OE= X-Received: by 2002:a05:6402:524c:b0:43e:aba4:a42d with SMTP id t12-20020a056402524c00b0043eaba4a42dmr2712719edd.328.1662549479692; Wed, 07 Sep 2022 04:17:59 -0700 (PDT) MIME-Version: 1.0 References: <20220906105431.30911-1-pali@kernel.org> In-Reply-To: <20220906105431.30911-1-pali@kernel.org> From: Bartosz Golaszewski Date: Wed, 7 Sep 2022 13:17:48 +0200 Message-ID: Subject: Re: [PATCH] gpio: mpc8xxx: Fix support for IRQ_TYPE_LEVEL_LOW flow_type in mpc85xx To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Linus Walleij , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 6, 2022 at 12:54 PM Pali Roh=C3=A1r wrote: > > Commit e39d5ef67804 ("powerpc/5xxx: extend mpc8xxx_gpio driver to support > mpc512x gpios") implemented support for IRQ_TYPE_LEVEL_LOW flow type in > mpc512x via falling edge type. Do same for mpc85xx which support was adde= d > in commit 345e5c8a1cc3 ("powerpc: Add interrupt support to mpc8xxx_gpio")= . > > Fixes probing of lm90 hwmon driver on mpc85xx based board which use level > interrupt. Without it kernel prints error and refuse lm90 to work: > > [ 15.258370] genirq: Setting trigger mode 8 for irq 49 failed (mpc8= xxx_irq_set_type+0x0/0xf8) > [ 15.267168] lm90 0-004c: cannot request IRQ 49 > [ 15.272708] lm90: probe of 0-004c failed with error -22 > > Fixes: 345e5c8a1cc3 ("powerpc: Add interrupt support to mpc8xxx_gpio") > Signed-off-by: Pali Roh=C3=A1r > --- > drivers/gpio/gpio-mpc8xxx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c > index a964e25ea620..763256efddc2 100644 > --- a/drivers/gpio/gpio-mpc8xxx.c > +++ b/drivers/gpio/gpio-mpc8xxx.c > @@ -172,6 +172,7 @@ static int mpc8xxx_irq_set_type(struct irq_data *d, u= nsigned int flow_type) > > switch (flow_type) { > case IRQ_TYPE_EDGE_FALLING: > + case IRQ_TYPE_LEVEL_LOW: > raw_spin_lock_irqsave(&mpc8xxx_gc->lock, flags); > gc->write_reg(mpc8xxx_gc->regs + GPIO_ICR, > gc->read_reg(mpc8xxx_gc->regs + GPIO_ICR) > -- > 2.20.1 > Applied, thanks! Bart