From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irq_work: improve the flag definitions
Date: Mon, 14 Aug 2017 19:12:16 +0200 [thread overview]
Message-ID: <CAMRc=Mf9Xn4E=iPpVBdQe_6mUG4JQBmt7gL41kOpvbjYWX8pOQ@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VcqQGgkkuoxpNheBPDtjWqY1CGAVd1RS2Vh0Kp29vfOLQ@mail.gmail.com>
2017-08-14 14:19 GMT+02:00 Andy Shevchenko <andy.shevchenko@gmail.com>:
> On Mon, Aug 14, 2017 at 2:56 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>> IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it
>> says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise
>> OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY.
>>
>> While we're at it: use the BIT() macro for all flags.
>
>> +#define IRQ_WORK_PENDING BIT(0)
>> +#define IRQ_WORK_BUSY BIT(1)
>> +#define IRQ_WORK_FLAGS (IRQ_WORK_PENDING | IRQ_WORK_BUSY)
>
> I dunno which style is preferred, though I would go with simple
> GENMASK() here, as all definitions right on left :-)
>
> Parameters of GENMASK will show last-first entries and can be easily decoded.
> Although there are only two for now.
>
Which is a good enough reason to not over-complicate things and just
use an easy to decipher bitwise OR. ;)
Thanks,
Bartosz
next prev parent reply other threads:[~2017-08-14 17:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 11:56 [PATCH] irq_work: improve the flag definitions Bartosz Golaszewski
2017-08-14 12:19 ` Andy Shevchenko
2017-08-14 17:12 ` Bartosz Golaszewski [this message]
2017-08-15 9:12 ` Bartosz Golaszewski
2018-01-05 4:19 [PATCH] irq_work: Improve " Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=Mf9Xn4E=iPpVBdQe_6mUG4JQBmt7gL41kOpvbjYWX8pOQ@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).