From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9487EC433EB for ; Mon, 22 Mar 2021 14:33:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A11B619A3 for ; Mon, 22 Mar 2021 14:33:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231272AbhCVOdM (ORCPT ); Mon, 22 Mar 2021 10:33:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230482AbhCVOch (ORCPT ); Mon, 22 Mar 2021 10:32:37 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C89CAC061763 for ; Mon, 22 Mar 2021 07:32:36 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id o19so19611189edc.3 for ; Mon, 22 Mar 2021 07:32:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=chWlvvM+R8+Nda51a8aii3oOtn9NRHzXgHWY/tWJNes=; b=05P7zw0tsPCH0lkJ4IJWK6rQhq0iLu6STD9jyRTbwyhVhZmqY4InkSeFh37+emrYYw wr+8HIFPwHEyiFrnZO4OyYvntZCN+eM8GP07HOelEq4xNS4oPiZeML8W89f1n04NUVpL 7Fl5hRXg6UwkyofR+jUZWed9M7WzxZVcAudOsL9B5YnDxY5qZDNYaA2ch1lxKFlhz7GT i/xarewa/2rMudBLAosj/p9RNJDtM2SNArMRxkAXy4+GPBOrMsWm9HqPiqhOQ0AfFM49 l47SLVzefAIGGeKk5h/uFBLhZeHjdM9Jk/1qDi7SeoziApYdbNmYZKFTojxjrEl8PVJl 9kNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=chWlvvM+R8+Nda51a8aii3oOtn9NRHzXgHWY/tWJNes=; b=hUPXodsbNvex+xXPdA3m2fk/fdxrIu/AVPwszhbeAy+aqNrd8ZiWkEPYxzLqRLnuvJ 1g+XR5+nfU258SP1M8wVdsT3iTdWURn6R1UVyfsFWCT4S6D/Yyce5W2/1neIZnsGe3Zo UYSyp2FvO0Qy9jxAte0701zsKVQzdgzdFewp22uZWrC8xu2Q2+mt95E9CoZhSm18INw8 J7u9iugSH+fH+KWwZ/fgh4js1VzMt/Hh50Yy3yrocteDfTt1mu1QDfbi3VNUCm+HnGgt gJ4snXhmYPnXkAwHnxeO98TlI+e4y7xIahhGt4VMHfgi1qXXk0mh+o3of8AN80m5FGbE Dlog== X-Gm-Message-State: AOAM532Q4UAWDhxs9GTxFne5/lzfEf70MtArWsCJdj4Fqn9RLgDI3z75 JOIr7H1s5l8QPiihlHvrpeq08X93plRhUugHqQRhFg== X-Google-Smtp-Source: ABdhPJw/qkhZqdtkjOclpC5fJbhhHCbMBE7GUaaaOreGNmjMwpYaceJ/cmgop4G0BQNlEFUtPoQIUhipTBCnhOKseCY= X-Received: by 2002:a05:6402:4309:: with SMTP id m9mr27072328edc.25.1616423555361; Mon, 22 Mar 2021 07:32:35 -0700 (PDT) MIME-Version: 1.0 References: <20210315091400.13772-1-brgl@bgdev.pl> In-Reply-To: <20210315091400.13772-1-brgl@bgdev.pl> From: Bartosz Golaszewski Date: Mon, 22 Mar 2021 15:32:24 +0100 Message-ID: Subject: Re: [PATCH v5 00/11] gpio: implement the configfs testing module To: Joel Becker , Christoph Hellwig Cc: "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Shuah Khan , linux-doc , Bartosz Golaszewski , Linus Walleij , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Andy Shevchenko , Geert Uytterhoeven , Kent Gibson , Jonathan Corbet , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 15, 2021 at 10:14 AM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > This series adds a new GPIO testing module based on configfs committable items > and sysfs. The goal is to provide a testing driver that will be configurable > at runtime (won't need module reload) and easily extensible. The control over > the attributes is also much more fine-grained than in gpio-mockup. > > This series also contains a respin of the patches I sent separately to the > configfs maintainers - these patches implement the concept of committable > items that was well defined for a long time but never actually completed. > > Apart from the new driver itself, its selftests and the configfs patches, this > series contains some changes to the bitmap API - most importantly: it adds > devres managed variants of bitmap_alloc() and bitmap_zalloc(). > > v1 -> v2: > - add selftests for gpio-sim > - add helper programs for selftests > - update the configfs rename callback to work with the new API introduced in > v5.11 > - fix a missing quote in the documentation > - use !! whenever using bits operation that are required to return 0 or 1 > - use provided bitmap API instead of reimplementing copy or fill operations > - fix a deadlock in gpio_sim_direction_output() > - add new read-only configfs attributes for mapping of configfs items to GPIO > device names > - and address other minor issues pointed out in reviews of v1 > > v2 -> v3: > - use devm_bitmap_alloc() instead of the zalloc variant if we're initializing > the bitmap with 1s > - drop the patch exporting device_is_bound() > - don't return -ENODEV from dev_nam and chip_name configfs attributes, return > a string indicating that the device is not available yet ('n/a') > - fix indentation where it makes sense > - don't protect IDA functions which use their own locking and where it's not > needed > - use kmemdup() instead of kzalloc() + memcpy() > - collected review tags > - minor coding style fixes > > v3 -> v4: > - return 'none' instead of 'n/a' from dev_name and chip_name before the device > is registered > - use sysfs_emit() instead of s*printf() > - drop GPIO_SIM_MAX_PROP as it's only used in an array's definition where it's > fine to hardcode the value > > v4 -> v5: > - export devm bitmap functions with EXPORT_SYMBOL_GPL() instead of a simple > EXPORT_SYMBOL() > > Bartosz Golaszewski (11): > configfs: increase the item name length > configfs: use (1UL << bit) for internal flags > configfs: implement committable items > samples: configfs: add a committable group > lib: bitmap: remove the 'extern' keyword from function declarations > lib: bitmap: order includes alphabetically > lib: bitmap: provide devm_bitmap_alloc() and devm_bitmap_zalloc() > gpio: sim: new testing module > selftests: gpio: provide a helper for reading chip info > selftests: gpio: add a helper for reading GPIO line names > selftests: gpio: add test cases for gpio-sim > > Documentation/admin-guide/gpio/gpio-sim.rst | 72 ++ > Documentation/filesystems/configfs.rst | 6 +- > drivers/gpio/Kconfig | 8 + > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-sim.c | 874 ++++++++++++++++++ > fs/configfs/configfs_internal.h | 22 +- > fs/configfs/dir.c | 245 ++++- > include/linux/bitmap.h | 127 +-- > include/linux/configfs.h | 3 +- > lib/bitmap.c | 42 +- > samples/configfs/configfs_sample.c | 153 +++ > tools/testing/selftests/gpio/.gitignore | 2 + > tools/testing/selftests/gpio/Makefile | 4 +- > tools/testing/selftests/gpio/config | 1 + > tools/testing/selftests/gpio/gpio-chip-info.c | 57 ++ > tools/testing/selftests/gpio/gpio-line-name.c | 55 ++ > tools/testing/selftests/gpio/gpio-sim.sh | 229 +++++ > 17 files changed, 1815 insertions(+), 86 deletions(-) > create mode 100644 Documentation/admin-guide/gpio/gpio-sim.rst > create mode 100644 drivers/gpio/gpio-sim.c > create mode 100644 tools/testing/selftests/gpio/gpio-chip-info.c > create mode 100644 tools/testing/selftests/gpio/gpio-line-name.c > create mode 100755 tools/testing/selftests/gpio/gpio-sim.sh > > -- > 2.30.1 > Hi Joel, Christoph, FYI The configfs patches from this series have been on the mailing list for months (long before the GPIO part) and have been re-sent several times. You have neither acked or opposed these changes. I don't want to delay the new testing driver anymore so I intend to apply the entire series and take it upstream through the GPIO tree by the end of this week. Best Regards, Bartosz Golaszewski