linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivo Sieben <meltedpianoman@gmail.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Chris Wright <chrisw@sous-sol.org>,
	linux-kernel@vger.kernel.org, Jean Delvare <khali@linux-fr.org>,
	Kevin Hilman <khilman@deeprootsystems.com>
Subject: Re: [PATCH-v3] Support M95040 SPI EEPROM
Date: Wed, 4 Apr 2012 09:21:57 +0200	[thread overview]
Message-ID: <CAMSQXEHpjD7LWQkKWJOU=9eFYqsaJi-xHFTxexQr7yoKiCG7HQ@mail.gmail.com> (raw)
In-Reply-To: <20120403171736.GD2477@pengutronix.de>

Hi,

Op 3 april 2012 19:17 heeft Wolfram Sang <w.sang@pengutronix.de> het
volgende geschreven:
>
>> > > > +#define EE_INSTR_BIT3_IS_ADDR  0x0010
>> > >
>> > > Is there some guarantee that this chip flag will always have this
>> > > meaning?
>> >
>> > ? This is a driver flag.
>>
>> Sorry, I don't see it set anywhere, so unclear on where it comes from.
>> I thought it was from a generic spi probe.
>
> Yeah, agreed, 'struct spi_eeprom' does not sound much like platform_data :/
> Thanks for checking.

The flag is indeed used in the platform initialization to enable the
"address bit" behavior, so you don't see it set anywhere in this patch
(and not anywhere in the kernel, since no board uses this flag yet).

Is it OK if we leave this patch like this?

Regards,
Ivo Sieben

  reply	other threads:[~2012-04-04  7:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-03  6:25 [PATCH-v3] Support M95040 SPI EEPROM Ivo Sieben
2012-04-03 16:46 ` Wolfram Sang
2012-04-03 16:53 ` Chris Wright
2012-04-03 17:07   ` Wolfram Sang
2012-04-03 17:11     ` Chris Wright
2012-04-03 17:17       ` Wolfram Sang
2012-04-04  7:21         ` Ivo Sieben [this message]
2012-04-04  7:59           ` Wolfram Sang
2012-04-05 15:11             ` Ivo Sieben
2012-04-05 16:43               ` Greg KH
2012-04-06  8:16                 ` Remy Bohmer
2012-04-06 18:22                   ` Wolfram Sang
2012-04-17 14:43                     ` Ivo Sieben
2012-04-17 20:47                       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMSQXEHpjD7LWQkKWJOU=9eFYqsaJi-xHFTxexQr7yoKiCG7HQ@mail.gmail.com' \
    --to=meltedpianoman@gmail.com \
    --cc=chrisw@sous-sol.org \
    --cc=khali@linux-fr.org \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).