From: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can <linux-can@vger.kernel.org>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Arunachalam Santhanam <arunachalam.santhanam@in.bosch.com>,
Wolfgang Grandegger <wg@grandegger.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>
Subject: Re: [PATCH v6] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces
Date: Mon, 16 Nov 2020 23:44:54 +0900 [thread overview]
Message-ID: <CAMZ6RqKVi8GFxU7s2zkzcv9RLSr_GidayjKu1YyNFRDOijUvgg@mail.gmail.com> (raw)
In-Reply-To: <11bada82-7406-d8e1-66e3-43db237ee265@pengutronix.de>
On Mon. 16 Nov 2020 at 03:55, Marc Kleine-Budde wrote:
> On 11/14/20 4:22 PM, Vincent Mailhol wrote:
> > This driver supports the ES581.4, ES582.1 and ES584.1 interfaces from
> > ETAS GmbH (https://www.etas.com/en/products/es58x.php).
> >
> > Co-developed-by: Arunachalam Santhanam <arunachalam.santhanam@in.bosch.com>
> > Signed-off-by: Arunachalam Santhanam <arunachalam.santhanam@in.bosch.com>
> > Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
>
> The driver fails to compile with CONFIG_SYSFS switched off
>
> CC [M] drivers/net/can/usb/etas_es58x/es58x_core.o
> drivers/net/can/usb/etas_es58x/es58x_core.c: In function ‘es58x_init_netdev’:
> drivers/net/can/usb/etas_es58x/es58x_core.c:2380:32: error: ‘struct netdev_queue’ has no member named ‘dql’
> 2380 | netdev_get_tx_queue(netdev, 0)->dql.min_limit =
> | ^~
Thanks, nice catch!
CONFIG_SYSFS is an expert setting, I totally missed that one. Took me
actually a couple of minutes navigating in the menuconfig to find how
to remove the option.
The root cause is actually on CONFIG_BQL (which depends on
CONFIG_SYSFS).
Reference: https://elixir.bootlin.com/linux/latest/source/include/linux/netdevice.h#L636
Will send a v7 patch right after.
Out of curiosity, how did you find this? Did you find it during a code
review or did you just happen to have a .config with CONFIG_SYSFS
Yours sincerely,
Vincent Mailhol
next prev parent reply other threads:[~2020-11-16 14:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 15:22 [PATCH v6] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces Vincent Mailhol
2020-11-14 18:12 ` kernel test robot
2020-11-15 11:41 ` Vincent MAILHOL
2020-11-16 0:31 ` [kbuild-all] " Rong Chen
2020-11-15 18:55 ` Marc Kleine-Budde
2020-11-16 14:44 ` Vincent MAILHOL [this message]
2020-11-16 15:02 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZ6RqKVi8GFxU7s2zkzcv9RLSr_GidayjKu1YyNFRDOijUvgg@mail.gmail.com \
--to=mailhol.vincent@wanadoo.fr \
--cc=arunachalam.santhanam@in.bosch.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).