From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 009EFC433ED for ; Mon, 5 Apr 2021 10:23:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9A6B61399 for ; Mon, 5 Apr 2021 10:23:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232322AbhDEKWr (ORCPT ); Mon, 5 Apr 2021 06:22:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234338AbhDEKWq (ORCPT ); Mon, 5 Apr 2021 06:22:46 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB304C06178C for ; Mon, 5 Apr 2021 03:22:40 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id t140so7823457pgb.13 for ; Mon, 05 Apr 2021 03:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JjgwIjAp85WETxxoLIiGI4oB1jKd53gUCV9N8DoHoVo=; b=HK2iVnuNeYbiSGk/CpIB26Ey5gvjKZRle1JQkDy/zQo4RG2G3EHSfnUbJbeF2sW7Vt np0W9wUxkSMXuvlgL4wNOgEXTP8UeUHTUzX6YN3lIzWvtHvUKZdPakY8jC67r696cLtU 9bBfBeOrv8KN8+hghSUTcbAL1a3tQ2lsDpgSAlTtROeEGE77umBa0NyibbmbkiVNqSaT U7fUOvTA/jZy0p1/JP3xmOCEvWelHy/Q65CAqtmHWniZ4fdZ+8W3Ro+47KY8DPt050uE RZeevE4BxqmxOZ1s5BSvvh2lBLuPT+9wcmz32pGp1ww1yeZulmBIIi/c2Wiqw3HLPO8u zwtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JjgwIjAp85WETxxoLIiGI4oB1jKd53gUCV9N8DoHoVo=; b=hd2OGoHmH8OpLdqG4yeSqVvQnQHR9hrZGpmfNjqtjTYXMU8AJvVAL0IeGoBz/LBDLf hwS3OdKKHfjhtbkPyUz4hD+yCWw/rwkVav7GbhuwQ8H2oujZVjjCmDdZnAgi2wGp7A0Z BJhz5GEtMqfG0SEvqFXBJxPmWU5iKstGGFFzPAJNzzVrpOsS0Y6O+2tz6GI7x4ec01zr hqhyxca6Wnhbl+gtXRMFLSSMbncQek+YzGA4S+KqoVGG12bJaDgsKS4WdfNoIUsWkWMy S9aPRtGBnP/sFqdNFIX+Pmyyf5tEMNZns2eGCwlDFpxjG0ufGRxIehr2f+nwLyCAzlqu Qx/g== X-Gm-Message-State: AOAM533xDGUfoK/x2Q7hT76bOD8GJdEZjLfLAmGXv/daOD1m/XUhp0Yp 9GrwszsioIDjvFHymYLkHqxSSz2v4BnZ3xchDjEgkQ== X-Google-Smtp-Source: ABdhPJxgf7FHvJvQJlQDJS7/bpeWe7CTfuF4tOMun1coUKie4kyPusS8tK5yZZJFAZ/zRyRM5Xa5a6xDqe8OW7ayfpo= X-Received: by 2002:a62:7a09:0:b029:1f1:5cf4:3fd7 with SMTP id v9-20020a627a090000b02901f15cf43fd7mr22427429pfc.66.1617618160049; Mon, 05 Apr 2021 03:22:40 -0700 (PDT) MIME-Version: 1.0 References: <1617616369-27305-1-git-send-email-loic.poulain@linaro.org> <1617616369-27305-2-git-send-email-loic.poulain@linaro.org> In-Reply-To: <1617616369-27305-2-git-send-email-loic.poulain@linaro.org> From: Loic Poulain Date: Mon, 5 Apr 2021 12:30:50 +0200 Message-ID: Subject: Re: [PATCH net-next v9 2/2] net: Add Qcom WWAN control driver To: Greg Kroah-Hartman , Jakub Kicinski , David Miller Cc: linux-arm-msm , Aleksander Morgado , open list , Network Development , Bjorn Andersson , Manivannan Sadhasivam Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Apr 2021 at 11:44, Loic Poulain wrote: > > The MHI WWWAN control driver allows MHI QCOM-based modems to expose > different modem control protocols/ports via the WWAN framework, so that > userspace modem tools or daemon (e.g. ModemManager) can control WWAN > config and state (APN config, SMS, provider selection...). A QCOM-based > modem can expose one or several of the following protocols: > - AT: Well known AT commands interactive protocol (microcom, minicom...) > - MBIM: Mobile Broadband Interface Model (libmbim, mbimcli) > - QMI: QCOM MSM/Modem Interface (libqmi, qmicli) > - QCDM: QCOM Modem diagnostic interface (libqcdm) > - FIREHOSE: XML-based protocol for Modem firmware management > (qmi-firmware-update) > > Note that this patch is mostly a rework of the earlier MHI UCI > tentative that was a generic interface for accessing MHI bus from > userspace. As suggested, this new version is WWAN specific and is > dedicated to only expose channels used for controlling a modem, and > for which related opensource userpace support exist. > > Signed-off-by: Loic Poulain > --- > v2: update copyright (2021) > v3: Move driver to dedicated drivers/net/wwan directory > v4: Rework to use wwan framework instead of self cdev management > v5: Fix errors/typos in Kconfig > v6: - Move to new wwan interface, No need dedicated call to wwan_dev_create > - Cleanup code (remove legacy from mhi_uci, unused defines/vars...) > - Remove useless write_lock mutex > - Add mhi_wwan_wait_writable and mhi_wwan_wait_dlqueue_lock_irq helpers > - Rework locking > - Add MHI_WWAN_TX_FULL flag > - Add support for NONBLOCK read/write > v7: Fix change log (mixed up 1/2 and 2/2) > v8: - Implement wwan_port_ops instead of fops > - Remove all obsolete elements (kref, lock, waitqueues) > - Add tracking of RX buffer budget > - Use WWAN TX flow control function to stop TX when MHI queue is full > v9: - Add proper locking for rx_budget + rx_refill scheduling > - Fix cocci errors (use-after-free, ERR_CAST) > [...] > +static int mhi_wwan_ctrl_probe(struct mhi_device *mhi_dev, > + const struct mhi_device_id *id) > +{ > + struct mhi_controller *cntrl = mhi_dev->mhi_cntrl; > + struct mhi_wwan_dev *mhiwwan; > + struct wwan_port *port; > + > + mhiwwan = kzalloc(sizeof(*mhiwwan), GFP_KERNEL); > + if (!mhiwwan) > + return -ENOMEM; > + > + mhiwwan->mhi_dev = mhi_dev; > + mhiwwan->mtu = MHI_WWAN_MAX_MTU; > + INIT_WORK(&mhiwwan->rx_refill, mhi_wwan_ctrl_refill_work); > + spin_lock_init(&mhiwwan->tx_lock); > + spin_lock_init(&mhiwwan->rx_lock); > + > + if (mhi_dev->dl_chan) > + set_bit(MHI_WWAN_DL_CAP, &mhiwwan->flags); > + if (mhi_dev->ul_chan) > + set_bit(MHI_WWAN_UL_CAP, &mhiwwan->flags); > + > + dev_set_drvdata(&mhi_dev->dev, mhiwwan); > + > + /* Register as a wwan port, id->driver_data contains wwan port type */ > + port = wwan_create_port(&cntrl->mhi_dev->dev, id->driver_data, > + &wwan_pops, mhiwwan); > + if (IS_ERR(mhiwwan->wwan_port)) { Should obviously be IS_ERR(port)... but waiting for comments on the series before resubmitting. > + kfree(mhiwwan); > + return PTR_ERR(port); > + } > + > + mhiwwan->wwan_port = port; > + > + return 0; > +};