From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0933C43461 for ; Tue, 15 Sep 2020 22:21:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76E5320872 for ; Tue, 15 Sep 2020 22:21:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="PTyR5b3m" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727785AbgIOWVm (ORCPT ); Tue, 15 Sep 2020 18:21:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727664AbgIOQ1y (ORCPT ); Tue, 15 Sep 2020 12:27:54 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC6C9C06121C for ; Tue, 15 Sep 2020 09:02:17 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id o68so2218930pfg.2 for ; Tue, 15 Sep 2020 09:02:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Rnn7brXuIav3vAJTNVyPdEtGBil0goNlmFybmIVcOOc=; b=PTyR5b3m8PvFl4k4qRhRZIkSU9mFdibCwuJoEEZyE7EFbYgXGr4CcNzaev27AjjfNc HoCamxH5F/HWhJfSDX+OxZ3APaUc1piqWZ5C+iIe+CPpXvToy3TDWysXE1tG4T9cGFdk +qASkYp6nF/cB/pFMhLJF+WxCtaZk+IsKBKpOcXI59vQSqFNxEVWVlP384in/vbsvdMv NF0Zer0ktFfIbKm+vjp/5IKg2aq4fkoIkaVyBrV4eH/EoF1oIq9hEI8ZZz6dxJ2DK/lM LiFfSrW505/AmnrJ0giADbQGzmcL0R899C73AmhF4l+Gszx/MbcuPpM9CmtC75eOBOC5 PDxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Rnn7brXuIav3vAJTNVyPdEtGBil0goNlmFybmIVcOOc=; b=UStYsMj85E9hH+/XDcC0dJJXmygY2TCaWrNv9Oq2MPEPG+a4nQqJ2tBsj4f30g779P ZtI9mMHUSvC3ikYqVrbwfIwRtYT3Wqv3wFaAs3bAo4CKnW8seEfWPNZY8p0DTppZZ5zo tG4inbMeqaC39BmH66ZxxwnzTcmJTjMgOUvY4345sxZYTMqU58ZUwMbKFQhi6Nfzs9P5 NCnTyOLqJxv8uRPsKzu3dfZrYjv9xJ+kpH2fOAUE4QSZ/8cmurxhE10GS7P+Gq3iWQJJ 2pzSwxgf9EfvGSNEMB0NEfazUGlzvUUu0MfvEX7xucHt5Vw4JBTjISIfk2i0AAkzFWTy SXYg== X-Gm-Message-State: AOAM5308RPo0r/5XVr5k9oGDoqpi/pBIrtDyc0MshWLnVo8FGb6thPGg +nroseHzSeA8TjkMq+drslu4w9b5pCaDXZJ8rT2AEg== X-Google-Smtp-Source: ABdhPJxYqEDxVz62ieN2AkMu385Z+pLr9lUwQA8maNGW5KsfZeFpud0ENKNwr9poUj8Nq7YH9OZn5uAuafp5wRwdhOM= X-Received: by 2002:a62:e40c:0:b029:13f:d777:f70e with SMTP id r12-20020a62e40c0000b029013fd777f70emr12244289pfh.2.1600185737371; Tue, 15 Sep 2020 09:02:17 -0700 (PDT) MIME-Version: 1.0 References: <20200915055825.5279-1-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Wed, 16 Sep 2020 00:01:41 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v4] mm: memcontrol: Add the missing numa_stat interface for cgroup v2 To: Randy Dunlap Cc: Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Cgroups , linux-doc@vger.kernel.org, LKML , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 11:45 PM Randy Dunlap wrote: > > Hi, > > On 9/14/20 10:58 PM, Muchun Song wrote: > > In the cgroup v1, we have a numa_stat interface. This is useful for > > providing visibility into the numa locality information within an > > memcg since the pages are allowed to be allocated from any physical > > node. One of the use cases is evaluating application performance by > > combining this information with the application's CPU allocation. > > But the cgroup v2 does not. So this patch adds the missing information. > > > > Signed-off-by: Muchun Song > > Suggested-by: Shakeel Butt > > --- > > changelog in v4: > > 1. Fix some document problems pointed out by Randy Dunlap. > > 2. Remove memory_numa_stat_format() suggested by Shakeel Butt. > > > > changelog in v3: > > 1. Fix compiler error on powerpc architecture reported by kernel test robot. > > 2. Fix a typo from "anno" to "anon". > > > > changelog in v2: > > 1. Add memory.numa_stat interface in cgroup v2. > > > > Documentation/admin-guide/cgroup-v2.rst | 72 +++++++++++++++++++++ > > mm/memcontrol.c | 86 +++++++++++++++++++++++++ > > 2 files changed, 158 insertions(+) > > > > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > > index 6be43781ec7f..bcb7b202e88d 100644 > > --- a/Documentation/admin-guide/cgroup-v2.rst > > +++ b/Documentation/admin-guide/cgroup-v2.rst > > @@ -1368,6 +1368,78 @@ PAGE_SIZE multiple when read back. > > collapsing an existing range of pages. This counter is not > > present when CONFIG_TRANSPARENT_HUGEPAGE is not set. > > > > + memory.numa_stat > > + A read-only flat-keyed file which exists on non-root cgroups. > > + > > + This breaks down the cgroup's memory footprint into different > > + types of memory, type-specific details, and other information > > + per node on the state of the memory management system. > > + > > + This is useful for providing visibility into the NUMA locality > > + information within an memcg since the pages are allowed to be > > + allocated from any physical node. One of the use cases is evaluating > > + application performance by combining this information with the > > + application's CPU allocation. > > + > > + All memory amounts are in bytes. > > + > > + The output format of memory.numa_stat is:: > > + > > + type N0= N1= ... > > I'm OK with Shakeel's suggested change here. > > > + The entries are ordered to be human readable, and new entries > > + can show up in the middle. Don't rely on items remaining in a > > + fixed position; use the keys to look up specific values! > > + > > + anon > > + Amount of memory per node used in anonymous mappings such > > + as brk(), sbrk(), and mmap(MAP_ANONYMOUS). > > + > > + file > > + Amount of memory per node used to cache filesystem data, > > + including tmpfs and shared memory. > > + > > + kernel_stack > > + Amount of memory per node allocated to kernel stacks. > > + > > + shmem > > + Amount of cached filesystem data per node that is swap-backed, > > + such as tmpfs, shm segments, shared anonymous mmap()s. > > + > > + file_mapped > > + Amount of cached filesystem data per node mapped with mmap(). > > + > > + file_dirty > > + Amount of cached filesystem data per node that was modified but > > + not yet written back to disk. > > + > > + file_writeback > > + Amount of cached filesystem data per node that was modified and > > + is currently being written back to disk. > > + > > + anon_thp > > + Amount of memory per node used in anonymous mappings backed by > > + transparent hugepages. > > + > > + inactive_anon, active_anon, inactive_file, active_file, unevictable > > + Amount of memory, swap-backed and filesystem-backed, > > + per node on the internal memory management lists used > > + by the page reclaim algorithm. > > + > > + As these represent internal list state (e.g. shmem pages are on > > + anon memory management lists), inactive_foo + active_foo may not > > + be equal to the value for the foo counter, since the foo counter > > + is type-based, not list-based. > > + > > + slab_reclaimable > > + Amount of memory per node used for storing in-kernel data > > + structures which might be reclaimed, such as dentries and > > + inodes. > > + > > + slab_unreclaimable > > + Amount of memory per node used for storing in-kernel data > > + structures which cannot be reclaimed on memory pressure. > > + > > memory.swap.current > > A read-only single value file which exists on non-root > > cgroups. > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 75cd1a1e66c8..ff919ef3b57b 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -6425,6 +6425,86 @@ static int memory_stat_show(struct seq_file *m, void *v) > > return 0; > > } > > > > +#ifdef CONFIG_NUMA > > +struct numa_stat { > > + const char *name; > > + unsigned int ratio; > > + enum node_stat_item idx; > > +}; > > + > > +static struct numa_stat numa_stats[] = { > > + { "anon", PAGE_SIZE, NR_ANON_MAPPED }, > > + { "file", PAGE_SIZE, NR_FILE_PAGES }, > > + { "kernel_stack", 1024, NR_KERNEL_STACK_KB }, > > + { "shmem", PAGE_SIZE, NR_SHMEM }, > > + { "file_mapped", PAGE_SIZE, NR_FILE_MAPPED }, > > + { "file_dirty", PAGE_SIZE, NR_FILE_DIRTY }, > > + { "file_writeback", PAGE_SIZE, NR_WRITEBACK }, > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > > + /* > > + * The ratio will be initialized in numa_stats_init(). Because > > + * on some architectures, the macro of HPAGE_PMD_SIZE is not > > + * constant(e.g. powerpc). > > + */ > > + { "anon_thp", 0, NR_ANON_THPS }, > > +#endif > > + { "inactive_anon", PAGE_SIZE, NR_INACTIVE_ANON }, > > + { "active_anon", PAGE_SIZE, NR_ACTIVE_ANON }, > > + { "inactive_file", PAGE_SIZE, NR_INACTIVE_FILE }, > > + { "active_file", PAGE_SIZE, NR_ACTIVE_FILE }, > > + { "unevictable", PAGE_SIZE, NR_UNEVICTABLE }, > > + { "slab_reclaimable", 1, NR_SLAB_RECLAIMABLE_B }, > > + { "slab_unreclaimable", 1, NR_SLAB_UNRECLAIMABLE_B }, > > +}; > > + > > +static int __init numa_stats_init(void) > > +{ > > + int i; > > + > > + for (i = 0; i < ARRAY_SIZE(numa_stats); i++) { > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > > + if (numa_stats[i].idx == NR_ANON_THPS) > > + numa_stats[i].ratio = HPAGE_PMD_SIZE; > > +#endif > > + } > > Although the loop may be needed sometime in the future due to > other changes.. why couldn't it be like this for now? The compiler is so smart, so there is nothing difference between them. I disassemble the numa_stats_init when !CONFIG_TRANSPARENT_HUGEPAGE. Dump of assembler code for function numa_stats_init: 0xffffffff8273b061 <+0>: callq 0xffffffff81057490 <__fentry__> 0xffffffff8273b066 <+5>: xor %eax,%eax 0xffffffff8273b068 <+7>: retq > > > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > > + for (i = 0; i < ARRAY_SIZE(numa_stats); i++) { > > + if (numa_stats[i].idx == NR_ANON_THPS) > > + numa_stats[i].ratio = HPAGE_PMD_SIZE; > > + } > > +#endif > > > > + > > + return 0; > > +} > > +pure_initcall(numa_stats_init); > > > thanks. > -- > ~Randy > -- Yours, Muchun