From: Muchun Song <songmuchun@bytedance.com>
To: David Hildenbrand <david@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [External] Re: [PATCH v2] mm/page_isolation: do not isolate the max order page
Date: Sat, 5 Dec 2020 00:12:06 +0800 [thread overview]
Message-ID: <CAMZfGtVdFtLB8f2uDfJ1H-YG4CsJ+RxxFbAWzePDnqBB1MU0ig@mail.gmail.com> (raw)
In-Reply-To: <46fcf0c1-7c38-723b-8905-953d72f1d6bc@redhat.com>
On Fri, Dec 4, 2020 at 12:28 AM David Hildenbrand <david@redhat.com> wrote:
>
> On 03.12.20 17:22, Muchun Song wrote:
> > The max order page has no buddy page and never merge to other order.
> > So isolating and then freeing it is pointless. And if order == MAX_ORDER
> > - 1, then the buddy can actually be a !pfn_valid() in some corner case?
> > pfn_valid_within(buddy_pfn) that follows would only catch it on archs
> > with holes in zone. Then is_migrate_isolate_page(buddy) might access an
> > invalid buddy. So this is also a bug fix.
> >
> > Fixes: 3c605096d315 ("mm/page_alloc: restrict max order of merging on isolated pageblock")
>
> As just replied to v1, I don't think this is required and the patch
You mean we should remove the Fixes tag? Thanks.
> description can be simplified - e.g., stating that we have/had not such
> users.
>
>
> --
> Thanks,
>
> David / dhildenb
>
--
Yours,
Muchun
next prev parent reply other threads:[~2020-12-04 16:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 16:22 [PATCH v2] mm/page_isolation: do not isolate the max order page Muchun Song
2020-12-03 16:28 ` David Hildenbrand
2020-12-04 16:12 ` Muchun Song [this message]
2020-12-04 17:12 ` [External] " David Hildenbrand
2020-12-07 13:42 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZfGtVdFtLB8f2uDfJ1H-YG4CsJ+RxxFbAWzePDnqBB1MU0ig@mail.gmail.com \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).