From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D93FC4361B for ; Thu, 10 Dec 2020 15:59:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45A1923D39 for ; Thu, 10 Dec 2020 15:59:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392102AbgLJP7U (ORCPT ); Thu, 10 Dec 2020 10:59:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391210AbgLJP7T (ORCPT ); Thu, 10 Dec 2020 10:59:19 -0500 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06C90C0613D6 for ; Thu, 10 Dec 2020 07:58:39 -0800 (PST) Received: by mail-pf1-x442.google.com with SMTP id f9so4474014pfc.11 for ; Thu, 10 Dec 2020 07:58:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3JsItjQhJTNChGLKWrMzXdOtHhMmJn68zyS+vNfChmc=; b=YR54goM9BduaqkUSFsN45e6lbCS6jKd0VIuO8EoEZV4bRzXfT2OMkZL9t4rycCznXW 3L+nB8URIDdu6cufleBaMugwkzBJ0bAmqF0tASnrYsCLhXE90t4kb9Fpi+J+fG4bsJly 4UPW1v4jSERSN9+jdEjsc4NfOwDb9a/RIIiYugb5FFWv0opti3lRjgSvAZwG60ZblLwL 8Q5zDENNJsMDc29AnGad8P8sF2aH8qAHCa1+ETX/nWCzL4DxswvNSMVczwx2143XKobK EZFF46MuoFXi2yZCvCbpV2lqjbGdRnJ4/Es9gUtDj8ArJRCqhb32n36XVO4LRVNfilvI 3syw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3JsItjQhJTNChGLKWrMzXdOtHhMmJn68zyS+vNfChmc=; b=bO0g6jxRMOtgUaES/HmzsPLt5TbtO4Tw88mIkNJ3blGH7xcH6io2BnhXuzILVo6BXT x7nfop8/8HjTnm7GX3pNESPVlPfjKPjUIoNt8Uk5MIc21ds9CSz/36M6yCjBLxBdTiUt wjcmMVxXRd1C2UzUL00K8vzjEnBI1TG34u57/GB0kLlfQx6shm0ikQngKgZcxzhLwtS4 Ehfo7qgRQp6HleWw+RKKZNoCVCn30HyFjkppuk+QcJl4HOcw+2vNMK/c/mPVNIOZ/aHD iuXV/GgHXjgKR937ONcJsPrkKb8EZieN56ofDzvHT5JNeW89TuSNQ6Bxhn71hgvl75An /8aA== X-Gm-Message-State: AOAM531YQ+glPPR89ZWeFKMtK0kKYpU1vgeEZpkhEzNo5m+09gubv2eZ 1wP4Zts3Rets+MgrKeCUA/Ezu4K/F3UtwsBkMwWhPQ== X-Google-Smtp-Source: ABdhPJxsRJTEViV1kHZNE7S/lb4xqQOiuBcWI/nuOSkpUU7hFgwqcfKWK3LPuNueNSM77fjVgLOMwdLciypLZQHT8Os= X-Received: by 2002:a63:c15:: with SMTP id b21mr7123599pgl.341.1607615918579; Thu, 10 Dec 2020 07:58:38 -0800 (PST) MIME-Version: 1.0 References: <20201210035526.38938-1-songmuchun@bytedance.com> <20201210035526.38938-5-songmuchun@bytedance.com> <20201210144256.GB8538@localhost.localdomain> <20201210144419.GC8538@localhost.localdomain> In-Reply-To: <20201210144419.GC8538@localhost.localdomain> From: Muchun Song Date: Thu, 10 Dec 2020 23:58:02 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v8 04/12] mm/hugetlb: Free the vmemmap pages associated with each HugeTLB page To: Oscar Salvador Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Michal Hocko , "Song Bao Hua (Barry Song)" , David Hildenbrand , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 10, 2020 at 10:44 PM Oscar Salvador wrote: > > On Thu, Dec 10, 2020 at 03:42:56PM +0100, Oscar Salvador wrote: > > On Thu, Dec 10, 2020 at 11:55:18AM +0800, Muchun Song wrote: > > > The free_vmemmap_pages_per_hpage() which indicate that how many vmemmap > > > pages associated with a HugeTLB page that can be freed to the buddy > > > allocator just returns zero now, because all infrastructure is not > > > ready. Once all the infrastructure is ready, we will rework this > > > function to support the feature. > > > > I would reword the above to: > > > > "free_vmemmap_pages_per_hpage(), which indicates how many vmemmap > > pages associated with a HugeTLB page can be freed, returns zero for > > now, which means the feature is disabled. > > We will enable it once all the infrastructure is there." > > > > Or something along those lines. > > > > > Signed-off-by: Muchun Song > > > > Overall this looks good to me, and it has seen a considerable > > simplification, which is good. > > Some nits/questions below: > > And as I said, I would merge patch#3 with this one. Will do. Thanks. > > > -- > Oscar Salvador > SUSE L3 -- Yours, Muchun