From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F663C433ED for ; Sat, 3 Apr 2021 05:48:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1429A611F0 for ; Sat, 3 Apr 2021 05:48:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234205AbhDCFrq (ORCPT ); Sat, 3 Apr 2021 01:47:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232140AbhDCFro (ORCPT ); Sat, 3 Apr 2021 01:47:44 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7F20C0613E6 for ; Fri, 2 Apr 2021 22:47:42 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id ha17so3590298pjb.2 for ; Fri, 02 Apr 2021 22:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V+wFWYRFis43GOTN2XRu8TgjxNZOmO8IgF4gRsiv9cA=; b=pMd1FbuvZ5E2fr1ocmyqnh+uLdNieVu/k08bIWoaWboRu1GuMhWuxbxzopnRIIA9lc zKwlsLoFQIrvZO9+Oo5f16yHnpzmH+iue6MrfQZ68f+gsl7xZ5h4aANWgAt4AjBkOBIn LczolwaRoieF168IcrjESxGMivxeYdlo7Pm9SyQ/si7aRk4o9K2fQKJkVd7bDtift8BP irNQU99mPX+t2pMHMjigsm8Gc9ruDFKeFl/YCvdAbROCuItCoolqDlnbbTsjNsM8SmMt RqMuLSmnqc5b8HrGIBHt14Fxr9KQXLtRLhBl5pAV9AM5fVsGMKr2+SMyr/9c/sjy9u4c nEdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V+wFWYRFis43GOTN2XRu8TgjxNZOmO8IgF4gRsiv9cA=; b=Fz0gkI6nwoD3AtPQBsbYHh+6LXk3MMf/UCsK0BBPYx3uZNgeC9gmIiwOIi+mG64MMG qYocvISpoDV3zMazsT9uqisbwXnuS8mZkikFVMWS4gs6pd8CUdzLcnGY2TGvW/4+irnb M/SVlCuf7byca03sD53e5D/yVlESTpx0dZy9rWfXzjlq4zZCC4N8Dp6ptOMFhjw7mQOH pO9lX90XakY1f/d64QdE/uSO56AnYkXt5cVwqemItkZ/tRoGx5xq28ACcSRlR/OYFH/p mfPQAP5vAUc1RbL08hH7xNVfx/kvBtDQppfhfqTgkvYi0jNzDymw9MBG/wKr7ui7AbWp BPJg== X-Gm-Message-State: AOAM532acpdw0F5iN1UTAKJEftjEJvFBc7e2R11vw1YRxquI80Kgnswm UsIbBZsmTJ5LlNp9W6JjZDDs9UbRgXKr9NUD9JcoiA== X-Google-Smtp-Source: ABdhPJzihZ9i7xdyKbcp25Pn/HT4uvsaH7n4VpVPtgIcyATKoF8snXQWFtthCIKS1/pr04vA/PHK/n8U/ZaD5DfL31I= X-Received: by 2002:a17:90a:d991:: with SMTP id d17mr16762991pjv.229.1617428862110; Fri, 02 Apr 2021 22:47:42 -0700 (PDT) MIME-Version: 1.0 References: <20210402191638.3249835-1-schatzberg.dan@gmail.com> <20210402191638.3249835-3-schatzberg.dan@gmail.com> In-Reply-To: <20210402191638.3249835-3-schatzberg.dan@gmail.com> From: Muchun Song Date: Sat, 3 Apr 2021 13:47:05 +0800 Message-ID: Subject: Re: [External] [PATCH 2/3] mm: Charge active memcg when no mm is set To: Dan Schatzberg Cc: Jens Axboe , Tejun Heo , Zefan Li , Johannes Weiner , Andrew Morton , Michal Hocko , Vladimir Davydov , Hugh Dickins , Shakeel Butt , Roman Gushchin , Yang Shi , Alex Shi , Alexander Duyck , Wei Yang , "open list:BLOCK LAYER" , open list , "open list:CONTROL GROUP (CGROUP)" , "open list:MEMORY MANAGEMENT" , Chris Down Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 3, 2021 at 3:17 AM Dan Schatzberg wrote: > > set_active_memcg() worked for kernel allocations but was silently > ignored for user pages. > > This patch establishes a precedence order for who gets charged: > > 1. If there is a memcg associated with the page already, that memcg is > charged. This happens during swapin. > > 2. If an explicit mm is passed, mm->memcg is charged. This happens > during page faults, which can be triggered in remote VMs (eg gup). > > 3. Otherwise consult the current process context. If there is an > active_memcg, use that. Otherwise, current->mm->memcg. > > Previously, if a NULL mm was passed to mem_cgroup_charge (case 3) it > would always charge the root cgroup. Now it looks up the active_memcg > first (falling back to charging the root cgroup if not set). > > Signed-off-by: Dan Schatzberg > Acked-by: Johannes Weiner > Acked-by: Tejun Heo > Acked-by: Chris Down > Reviewed-by: Shakeel Butt Reviewed-by: Muchun Song Thanks.