From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76010C4167B for ; Sat, 5 Dec 2020 18:33:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43149230FD for ; Sat, 5 Dec 2020 18:33:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726788AbgLESdZ (ORCPT ); Sat, 5 Dec 2020 13:33:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726330AbgLES2l (ORCPT ); Sat, 5 Dec 2020 13:28:41 -0500 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8E6AC02B8DB for ; Sat, 5 Dec 2020 07:30:02 -0800 (PST) Received: by mail-pl1-x644.google.com with SMTP id x15so4782017pll.2 for ; Sat, 05 Dec 2020 07:30:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c3OEJmdZ1/qP5ONZzc9GH1i60y0LaLFR+aOV9VrM68E=; b=RFv6oCVnKXhcQR6IicNUWbPC4/Z5AsfOqXI3YNlh0pvXL5969ZbwsIOX94yL0AoG5N 4H10HQ069aT2lPyegmLL9y5xGugUcMz06aS1WZ3pdq89Imi81tAKFJpyZMgUK9SVBJCa A634SvsUCe2U04cVJ+T8KfpvS62xfjKViRM/4Ex9qGjkVQlmHy6yE9R+xdzcuFSxO7nB nryctbZ+1QmIx2ZL86cf9GfD5A29hVns8f5lrEAC8Jfaer82Zra6uPWc36qK5KpPh9/6 /jaQaMuS5xxE4bgF0K1DkKYHgRSYmK92cWC3rUAmSittguNyEDioQaexShy1L+BVY1Zv 1emQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c3OEJmdZ1/qP5ONZzc9GH1i60y0LaLFR+aOV9VrM68E=; b=jVrkkCGRQ8Nnyuug3UZLr92xXnRvsEPobbTjLCLDXPm4X1YkjKzKHJUO0+ALkngXJL wnUO23/RplCpHxxdx7Wa9L7i1xH8UihsC2suwiP2JQbR0pnuBdJ0BHihTnmtvQZN4Ax1 TVhQ7RnEeLHXNccZRk0u94ZANjx0hExrcioaZ2pV8QbTcYF2ERADOJnnW9ruJH56Mq45 ULF0rygxIMHqwf+gkAXu0mDk+bPmZTzaJBOTBFxLwX0lJ9CLAJ0Zfrg9inj/x8t2/DpV LthluTCpLb5OC59qDabTAJTRKzVL+z0SCYIVpbHXmHIUeinEbPbmv7dgoLpDWe1svznM SPNA== X-Gm-Message-State: AOAM533KERhtGPypkFdbCvQYJJQ5Jk9IWMM/dFSaxa9vKWLx/RvP90PF XKTgufubf/NMr5qnlCmqnPlVKyfKN9t3miuAvKB5YQ== X-Google-Smtp-Source: ABdhPJzCfYIR8zNekwULgYedfmRzJ6EdPamFbkDT+7O9rY/XKHDu8JVu3tJC5a/COi5onrzsJ8EhaKY+0w0A1Nu98rU= X-Received: by 2002:a17:90a:ba88:: with SMTP id t8mr8959793pjr.229.1607182202264; Sat, 05 Dec 2020 07:30:02 -0800 (PST) MIME-Version: 1.0 References: <20201205130224.81607-1-songmuchun@bytedance.com> <20201205130224.81607-6-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Sat, 5 Dec 2020 23:29:26 +0800 Message-ID: Subject: Re: [External] Re: [PATCH 5/9] mm: memcontrol: convert NR_FILE_THPS account to pages To: Greg KH Cc: rafael@kernel.org, Alexey Dobriyan , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Will Deacon , Roman Gushchin , Mike Rapoport , Thomas Gleixner , esyr@redhat.com, peterx@redhat.com, krisman@collabora.com, Suren Baghdasaryan , avagin@openvz.org, Marco Elver , Randy Dunlap , Joonsoo Kim , LKML , linux-fsdevel , Linux Memory Management List , Cgroups Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 5, 2020 at 10:09 PM Greg KH wrote: > > On Sat, Dec 05, 2020 at 09:02:20PM +0800, Muchun Song wrote: > > Converrt NR_FILE_THPS account to pages. > > > > Signed-off-by: Muchun Song > > --- > > drivers/base/node.c | 3 +-- > > fs/proc/meminfo.c | 2 +- > > mm/filemap.c | 2 +- > > mm/huge_memory.c | 3 ++- > > mm/khugepaged.c | 2 +- > > mm/memcontrol.c | 5 ++--- > > 6 files changed, 8 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/base/node.c b/drivers/base/node.c > > index 05c369e93e16..f6a9521bbcf8 100644 > > --- a/drivers/base/node.c > > +++ b/drivers/base/node.c > > @@ -466,8 +466,7 @@ static ssize_t node_read_meminfo(struct device *dev, > > HPAGE_PMD_NR), > > nid, K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED) * > > HPAGE_PMD_NR), > > - nid, K(node_page_state(pgdat, NR_FILE_THPS) * > > - HPAGE_PMD_NR), > > + nid, K(node_page_state(pgdat, NR_FILE_THPS)), > > Again, is this changing a user-visable value? > Of course not. In the previous, the NR_FILE_THPS account is like below: __mod_lruvec_page_state(page, NR_FILE_THPS, 1); With this patch, it is: __mod_lruvec_page_state(page, NR_FILE_THPS, HPAGE_PMD_NR); So the result is not changed from the view of user space. Thanks. -- Yours, Muchun