From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95A02C433DB for ; Mon, 22 Feb 2021 10:32:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62F8564E24 for ; Mon, 22 Feb 2021 10:32:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230318AbhBVKcd (ORCPT ); Mon, 22 Feb 2021 05:32:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230212AbhBVKc3 (ORCPT ); Mon, 22 Feb 2021 05:32:29 -0500 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BBDAC061786 for ; Mon, 22 Feb 2021 02:31:49 -0800 (PST) Received: by mail-pl1-x635.google.com with SMTP id k22so7462045pll.6 for ; Mon, 22 Feb 2021 02:31:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8UWh8jduGRGu0Lvsdl9eBlyqHKjBe0P0nAH4NaZ9DMc=; b=CJhQTg5ewgzZcnE2MhOHrzTbe0C5iEgOrytZGTuvGqjQI+Uw34/pbKAhYfv55ZbEQ+ 3k1GnYlHjK3NlkzleMwne0BnkjHisb1fCE5MYMfn2irYh+FIKK5ZeBhC1r/gr4ou+UsQ 9C2upnSbHxCxznvPzFE1kIpgGUj7irS2BkklgdS3tSc5tHC4pXnPdWSCPGnbaaJGIjZk z/n8oOfCDpuoEI15EjK00iptRmFy5EsufKXUlVyopdACbYxxWNCbmWSqyS0QQZL39Rj/ K04D7A6saCRLnu+QLw3fVe/ammJfGSl6OwbFU82JpozB+uMI0V6xEqmTjXu8gGmgwe8c P3wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8UWh8jduGRGu0Lvsdl9eBlyqHKjBe0P0nAH4NaZ9DMc=; b=kXuHirvNOxdykcbpU3eveiOBmQCcw9GvWZYzR7IuyCl+aqYoB937HrwJdyOA8rsKZz OQleVLfDIIEk6fdMMKtjzVptESsaELPOjKI38MLSKfg9dTisVfj94kMBdRAxTkV6hpzK DVNMoYCc1T1+bbVtlhPTu+XufGCPWqQb6zhzvZ+ELb4hjI/EQqyorJPWidtNIEAghmWy VOO4YqN/qVrUSHQuA4YyLn6p0klwSHXR9B6kN4yhLp2DLMRWn3CMCfuRor6ikkkqv+Ma x7JNkIpLIpqcOsPVNmCBj0Gl5+KQWrDsfdqFwLc39qntCboTkU6RdXM+iuGXYcZU+AGk GuRg== X-Gm-Message-State: AOAM531tXoGPpdtAJp6wb89mUVxpTS0VflyMOx8SW/pFL6dFX19TKXZR p3Qljh/0mFl+ZDd/qsEd8y3cAiWdkfIng/sjPqcj/g== X-Google-Smtp-Source: ABdhPJxeUlmz8zPz9b/j2QjskVoGdhyZlrSI7oyLSmQ0kLy48DqKvUv7uDS1x5dDFWskiPN5ixGvTOLh0b8L9NlGn5M= X-Received: by 2002:a17:90a:f18d:: with SMTP id bv13mr1625214pjb.13.1613989908932; Mon, 22 Feb 2021 02:31:48 -0800 (PST) MIME-Version: 1.0 References: <20210219104954.67390-1-songmuchun@bytedance.com> <20210219104954.67390-5-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Mon, 22 Feb 2021 18:31:12 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v16 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page To: Michal Hocko Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Oscar Salvador , "Song Bao Hua (Barry Song)" , David Hildenbrand , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Joao Martins , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 22, 2021 at 5:25 PM Michal Hocko wrote: > > On Sat 20-02-21 12:20:36, Muchun Song wrote: > > On Fri, Feb 19, 2021 at 10:12 PM Michal Hocko wrote: > [...] > > > What about hugetlb page poisoning on HW failure (resp. soft offlining)? > > > > If the HW poisoned hugetlb page failed to be dissolved, the page > > will go back to the free list with PG_HWPoison set. But the page > > will not be used, because we will check whether the page is HW > > poisoned when it is dequeued from the free list. If so, we will skip > > this page. > > Can this lead to an under provisioned pool then? Or is there a new > hugetlb allocated to replace the poisoned one? Actually, no page will be allocated. Your concern is right. But without this patch, the result does not change. e.g. The HW poisoned page can fail to be dissolved when h->free_huge_pages is equal to h->resv_huge_pages. But no one seems to have reported this issue so far. Maybe this behavior needs improvement in the feature. > > -- > Michal Hocko > SUSE Labs