From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 451AFC07E9B for ; Tue, 20 Jul 2021 04:30:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 259B7610F7 for ; Tue, 20 Jul 2021 04:30:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241322AbhGTDt4 (ORCPT ); Mon, 19 Jul 2021 23:49:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231795AbhGTDtZ (ORCPT ); Mon, 19 Jul 2021 23:49:25 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EAF1C061574; Mon, 19 Jul 2021 21:30:03 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id t9so21390950pgn.4; Mon, 19 Jul 2021 21:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BzuDwtFqPo4qqrRvCl7MJ3PnC9VhI0oxy96YAAdNcKM=; b=ceLJfZuTfRY/Mn7cPwed8gBs+/+yyBD1PqVOW0Gc6mVjxUdHEpTGsCXwoe4YWELZpW 3Sq2M9k8NRI7Of1AJEzlwhDr15YhH4Ssvmhxm8KUUFPGcBsR5qxVaVkC/dEsgfqcWPEQ BPjEATi0kcgW2M0IsTsVQ2zbUzGaIeTlnzkpkwk2g21Re/sYPQRLBxy5FYQyxcZJdf6x r/zlarBJ1mN7x1jJWJKNz96mWcxL6dI7yNfbZ7in75cxKtL4YYWZvglJ9s+bNExlbQI4 jCQ1lZ5pNFKgG2dqyaml3fL1n5lFGjzbJnjLZ2/BzUG0hmr3oeZPGv5HgDvq3AxVdUsg XNlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BzuDwtFqPo4qqrRvCl7MJ3PnC9VhI0oxy96YAAdNcKM=; b=aGx8KLLgmxzSl+DWb9lEBJNsYEFurAmBc1Hoh+L37Fi5gHqgd2LeLb9/zqrujdsrtx HRaIi57XCB4ZMyd+eYe3GtJpzio2OlCzZlO83J55FxV9HiiaJl+ldNqZeFmKMqo8pjl8 JbTHo1ZCVFOXhLdNy6jMM/WUiBBjv9yI6quuYPM3J6rXzHMycgFnB/6UxdYbHozSvOYj QyG8RpAJD720Q5/nqOTmk7EHUtW7LpdYjkKASFY6flb5NF2QGVFsze+SUYQuIdkQ5QNN 3Udp4jNdSyg2B0duKhHpvdw2/KBd7NY25TgaqkeXVVPZTryBH/Kj4q8FE8nrub44GYxn 473g== X-Gm-Message-State: AOAM5328UYfd/I8fMCjsJuisJ438ZeSPcxAXdjIxMa00bo4xxRFM206Z RRSYEBpU3rXjsSFGaISezEWtanGb4A4QLafH+GY= X-Google-Smtp-Source: ABdhPJwGAZ9pw6/Nfnhc5hLXNtEg5yNwKeNeSbOw+AZLvl+tfUHhCBayNrYsQxUnt637bXLneJYy0l0K/WoLrHGLNU0= X-Received: by 2002:a62:ea1a:0:b029:329:a95a:fab with SMTP id t26-20020a62ea1a0000b0290329a95a0fabmr29822885pfh.31.1626755402840; Mon, 19 Jul 2021 21:30:02 -0700 (PDT) MIME-Version: 1.0 References: <20210719051816.11762-1-yajun.deng@linux.dev> In-Reply-To: <20210719051816.11762-1-yajun.deng@linux.dev> From: Cong Wang Date: Mon, 19 Jul 2021 21:29:51 -0700 Message-ID: Subject: Re: [PATCH] netlink: Deal with ESRCH error in nlmsg_notify() To: Yajun Deng Cc: David Miller , Jakub Kicinski , Alexei Starovoitov , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Linux Kernel Network Developers , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 18, 2021 at 10:19 PM Yajun Deng wrote: > The failure seems due to the commit > cfdf0d9ae75b ("rtnetlink: use nlmsg_notify() in rtnetlink_send()") > > Deal with ESRCH error in nlmsg_notify() even the report variable is zero. Looks like the tc-testing failure I saw is also due to this... Why not just revert the above commit which does not have much value? It at most saves some instructions. Thanks.