From: Cong Wang <xiyou.wangcong@gmail.com>
To: Peilin Ye <yepeilin.cs@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>, Shuah Khan <shuah@kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Lucas Bates <lucasb@mojatatu.com>,
Cong Wang <cong.wang@bytedance.com>,
Peilin Ye <peilin.ye@bytedance.com>
Subject: Re: [PATCH net-next] tc-testing: Add control-plane selftests for sch_mq
Date: Tue, 3 Aug 2021 15:21:15 -0700 [thread overview]
Message-ID: <CAM_iQpVUMzP8_gPsth_DncVUdC09ihizTC7jo2t1=MS9uSdfTw@mail.gmail.com> (raw)
In-Reply-To: <20210803221659.9847-1-yepeilin.cs@gmail.com>
On Tue, Aug 3, 2021 at 3:17 PM Peilin Ye <yepeilin.cs@gmail.com> wrote:
> + "setup": [
> + "echo \"1 1 4\" > /sys/bus/netdevsim/new_device"
> + ],
> + "cmdUnderTest": "$TC qdisc add dev $ETH root handle 1: mq",
> + "expExitCode": "0",
> + "verifyCmd": "$TC qdisc show dev $ETH",
> + "matchPattern": "qdisc pfifo_fast 0: parent 1:[1-4] bands 3 priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1",
> + "matchCount": "4",
> + "teardown": [
> + "echo \"1\" > /sys/bus/netdevsim/del_device"
> + ]
> + },
Like I mentioned to Peilin, I am _not_ sure whether it is better to create
netdevsim device in such a way. Maybe we need to create it before
these tests and pass it via cmdline?? Lucas?
Thanks.
next prev parent reply other threads:[~2021-08-03 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210803123921.2374485-1-kuba@kernel.org>
2021-08-03 22:16 ` [PATCH net-next] tc-testing: Add control-plane selftests for sch_mq Peilin Ye
2021-08-03 22:21 ` Cong Wang [this message]
2021-08-04 11:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_iQpVUMzP8_gPsth_DncVUdC09ihizTC7jo2t1=MS9uSdfTw@mail.gmail.com' \
--to=xiyou.wangcong@gmail.com \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lucasb@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=peilin.ye@bytedance.com \
--cc=shuah@kernel.org \
--cc=yepeilin.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).