linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* tc qdisc command partially broken with patch-4.14.76-77 up to patch-4.14.77-78
@ 2018-10-25 20:12 astx
  2018-10-25 21:49 ` Cong Wang
  0 siblings, 1 reply; 2+ messages in thread
From: astx @ 2018-10-25 20:12 UTC (permalink / raw)
  To: linux-kernel

tc qdisc command is partially broken after applying patch-4.14.76-77.
Applying patch-4.14.77-78 didn't fix it.

Test command:
   tc qdisc add dev eth0 root handle 1: hfsc default fffd
Kernel answer:
   RTNETLINK answers: Numerical result out of range

I have identified the problematic sub-patch out of patch-4.14.76-77 to  
be the problem:

    diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
    index 22bc6fc48311..cd69aa067543 100644

Without this small patch the above "tc qdisc" command works like a charm.

Maybe someone can have a look at it.

Best regards, Toni



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: tc qdisc command partially broken with patch-4.14.76-77 up to patch-4.14.77-78
  2018-10-25 20:12 tc qdisc command partially broken with patch-4.14.76-77 up to patch-4.14.77-78 astx
@ 2018-10-25 21:49 ` Cong Wang
  0 siblings, 0 replies; 2+ messages in thread
From: Cong Wang @ 2018-10-25 21:49 UTC (permalink / raw)
  To: astx; +Cc: LKML

On Thu, Oct 25, 2018 at 1:14 PM astx <astx@aws-it.at> wrote:
>
> tc qdisc command is partially broken after applying patch-4.14.76-77.
> Applying patch-4.14.77-78 didn't fix it.
>
> Test command:
>    tc qdisc add dev eth0 root handle 1: hfsc default fffd
> Kernel answer:
>    RTNETLINK answers: Numerical result out of range
>
> I have identified the problematic sub-patch out of patch-4.14.76-77 to
> be the problem:
>
>     diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
>     index 22bc6fc48311..cd69aa067543 100644
>
> Without this small patch the above "tc qdisc" command works like a charm.

Should be fixed by the following commit:

commit e72bde6b66299602087c8c2350d36a525e75d06e
Author: David Ahern <dsahern@gmail.com>
Date:   Wed Oct 24 08:32:49 2018 -0700

    net: sched: Remove TCA_OPTIONS from policy


Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-25 21:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-25 20:12 tc qdisc command partially broken with patch-4.14.76-77 up to patch-4.14.77-78 astx
2018-10-25 21:49 ` Cong Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).