From: Cong Wang <xiyou.wangcong@gmail.com>
To: Paul Moore <paul@paul-moore.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Boot regression caused by kauditd
Date: Thu, 27 Apr 2017 16:41:24 -0700 [thread overview]
Message-ID: <CAM_iQpXz0apV6UD3PPtfvOFimzh-=i5v9Zhf754z2-0BSW6cBA@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhQHT=OyCrjBEnLbq_j4VFvK-VQvR8W_ftY4PQRrNBA86w@mail.gmail.com>
On Thu, Apr 27, 2017 at 3:38 PM, Paul Moore <paul@paul-moore.com> wrote:
> On Thu, Apr 27, 2017 at 5:45 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>> On Thu, Apr 27, 2017 at 2:35 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>>> On Thu, Apr 27, 2017 at 1:31 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>>>> On Wed, Apr 26, 2017 at 2:20 PM, Paul Moore <paul@paul-moore.com> wrote:
>>>>> Thanks for the report, this is the only one like it that I've seen.
>>>>> I'm looking at the code in Linus' tree and I'm not seeing anything
>>>>> obvious ... looking at the trace above it appears that the problem is
>>>>> when get_net() goes to bump the refcount and the passed net pointer is
>>>>> NULL; unless I'm missing something, the only way this would happen in
>>>>> kauditd_thread() is if the auditd_conn.pid value is non-zero but the
>>>>> auditd_conn.net pointer is NULL.
>>>>>
>>>>> That shouldn't happen.
>>>>>
>>>>
>>>> Looking at the code that reads/writes the global auditd_conn,
>>>> I don't see how it even works with RCU+spinlock, RCU plays
>>>> with pointers and you have to make a copy as its name implies.
>>>> But it looks like you simply use RCU+spinlock as a traditional
>>>> rwlock, it doesn't work.
>>>
>>> The attached patch seems working for me, I tried to boot my
>>> VM for 4 times, so far no crash or warning.
>>>
>>
>> Or even better, save a memory allocation for reset path...
>
> I need to step away from my laptop for the evening so I can't give
> this a proper review until tomorrow (sending patches as attachments
> makes it difficult to review), but on quick glance I did notice a few
> small things I would like to see changed. However, since there is no
> normal commit description and sign-off, I'm guessing you sent these
> out as a suggestion and not a proper patch submission, yes/no? If
> that's the case, I'll work up a proper fix tomorrow and share it with
> you for comment/review, but if you were planning on sending a proper
> patch let me know and I'll wait until I see something in my inbox from
> you.
I want you to give it sanity check before I submit a formal one. ;)
If you don't reject it, I will send a formal one with description and SoB.
Thanks.
next prev parent reply other threads:[~2017-04-27 23:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 20:48 Boot regression caused by kauditd Cong Wang
2017-04-26 21:20 ` Paul Moore
2017-04-27 5:04 ` Cong Wang
2017-04-27 20:31 ` Cong Wang
2017-04-27 21:35 ` Cong Wang
2017-04-27 21:45 ` Cong Wang
2017-04-27 22:38 ` Paul Moore
2017-04-27 23:41 ` Cong Wang [this message]
2017-04-28 0:47 ` Paul Moore
2017-04-28 15:30 ` Paul Moore
2017-04-28 16:11 ` Cong Wang
2017-04-28 16:26 ` Paul Moore
2017-05-02 5:50 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_iQpXz0apV6UD3PPtfvOFimzh-=i5v9Zhf754z2-0BSW6cBA@mail.gmail.com' \
--to=xiyou.wangcong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).