From: Peter Geis <pgwipeout@gmail.com> To: "Heiko Stübner" <heiko@sntech.de> Cc: Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Rob Herring <robh+dt@kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, devicetree@vger.kernel.org, arm-mail-list <linux-arm-kernel@lists.infradead.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 6/9] arm64: dts: rockchip: add missing rk3568 cru phandles Date: Wed, 28 Jul 2021 10:18:49 -0400 [thread overview] Message-ID: <CAMdYzYqR+ocrXQi8TOHY0Yd2oULXuPgE_QnbcuQSw=BoaumBKA@mail.gmail.com> (raw) In-Reply-To: <13247009.uLZWGnKmhe@diego> On Wed, Jul 28, 2021 at 10:06 AM Heiko Stübner <heiko@sntech.de> wrote: > > Hi Peter, > > Am Mittwoch, 28. Juli 2021, 15:55:31 CEST schrieb Peter Geis: > > The grf and pmugrf phandles are necessary for the pmucru and cru to > > modify clocks. Add these phandles to permit adjusting the clock rates > > and muxes. > > > > Signed-off-by: Peter Geis <pgwipeout@gmail.com> > > --- > > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > index 0905fac0726a..8ba0516eedd8 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > @@ -218,6 +218,8 @@ grf: syscon@fdc60000 { > > pmucru: clock-controller@fdd00000 { > > compatible = "rockchip,rk3568-pmucru"; > > reg = <0x0 0xfdd00000 0x0 0x1000>; > > + rockchip,grf = <&grf>; > > + rockchip,pmugrf = <&pmugrf>; > > I don't think the pmucru needs both and in fact the mainline > clock driver should just reference its specific grf at all, i.e. > pmucru -> pmugrf (via the rockchip,grf handle) > cru -> grf > > I've not seen anything breaking this scope so far. I thought the same thing as well, but for some reason the driver refuses to apply assigned-clocks to the plls unless these are all present. If the driver can get these assignments automatically eventually, perhaps it's a loading order issue? Thinking about it, it's probably the grf and pmugrf haven't probed when the driver is attempting to assign these, and tying them together forces the probe to happen first. > > > Heiko > > > #clock-cells = <1>; > > #reset-cells = <1>; > > }; > > @@ -225,6 +227,7 @@ pmucru: clock-controller@fdd00000 { > > cru: clock-controller@fdd20000 { > > compatible = "rockchip,rk3568-cru"; > > reg = <0x0 0xfdd20000 0x0 0x1000>; > > + rockchip,grf = <&grf>; > > #clock-cells = <1>; > > #reset-cells = <1>; > > }; > > > > > >
next prev parent reply other threads:[~2021-07-28 14:19 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-28 13:55 [PATCH 0/9] fixes and enablement for rk356x Peter Geis 2021-07-28 13:55 ` [PATCH 1/9] dt-bindings: gpio: rockchip,gpio-bank: increase max clocks Peter Geis 2021-07-28 14:10 ` Heiko Stübner 2021-07-28 15:24 ` Peter Geis 2021-07-28 15:51 ` Rob Herring 2021-07-28 13:55 ` [PATCH 2/9] arm64: dts: rockchip: fix rk3568 mbi-alias Peter Geis 2021-07-28 13:55 ` [PATCH 3/9] arm64: dts: rockchip: add rk356x gpio debounce clocks Peter Geis 2021-07-28 13:55 ` [PATCH 4/9] arm64: dts: rockchip: add rk356x gmac1 node Peter Geis 2021-07-28 14:21 ` Heiko Stübner 2021-07-28 14:32 ` Peter Geis 2021-07-28 13:55 ` [PATCH 5/9] arm64: dts: rockchip: add rk3568 tsadc nodes Peter Geis 2021-07-28 14:46 ` Heiko Stübner 2021-07-28 15:14 ` Peter Geis 2021-07-28 15:31 ` Heiko Stübner 2021-07-28 15:33 ` Johan Jonker 2022-01-17 8:43 ` Piotr Oniszczuk 2022-01-17 13:49 ` Peter Geis 2022-01-17 14:13 ` Piotr Oniszczuk 2022-01-17 14:38 ` Peter Geis 2022-01-17 14:53 ` Piotr Oniszczuk 2021-07-28 13:55 ` [PATCH 6/9] arm64: dts: rockchip: add missing rk3568 cru phandles Peter Geis 2021-07-28 14:06 ` Heiko Stübner 2021-07-28 14:18 ` Peter Geis [this message] 2021-07-28 14:41 ` Heiko Stübner 2021-07-28 15:16 ` Peter Geis 2021-07-28 16:49 ` Peter Geis 2021-07-28 17:28 ` Heiko Stübner 2021-07-28 13:55 ` [PATCH 7/9] arm64: dts: rockchip: adjust rk3568 pll clocks Peter Geis 2021-07-28 14:08 ` Heiko Stübner 2021-07-28 14:24 ` Peter Geis 2021-07-28 13:55 ` [PATCH 8/9] arm64: dts: rockchip: enable gmac node on quartz64-a Peter Geis 2021-07-28 13:55 ` [PATCH 9/9] arm64: dts: rockchip: add thermal support to Quartz64 Model A Peter Geis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMdYzYqR+ocrXQi8TOHY0Yd2oULXuPgE_QnbcuQSw=BoaumBKA@mail.gmail.com' \ --to=pgwipeout@gmail.com \ --cc=bgolaszewski@baylibre.com \ --cc=devicetree@vger.kernel.org \ --cc=heiko@sntech.de \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=robh+dt@kernel.org \ --subject='Re: [PATCH 6/9] arm64: dts: rockchip: add missing rk3568 cru phandles' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).