From: Peter Geis <pgwipeout@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Heiko Stübner" <heiko@sntech.de>,
"Jianqun Xu" <jay.xu@rock-chips.com>,
"Tao Huang" <huangtao@rock-chips.com>,
"Kever Yang" <kever.yang@rock-chips.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/7] gpio-rockchip driver
Date: Mon, 12 Apr 2021 11:00:18 -0400 [thread overview]
Message-ID: <CAMdYzYrSwLd7zAo840VvQNs48ki1kwS2LdL+N96aVKrmrMRWbw@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VdWES51UPiKayYZ15Mr7pS-Aaz51hKNFmyhbv2JqwPwPA@mail.gmail.com>
On Mon, Apr 12, 2021 at 9:34 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Mon, Apr 12, 2021 at 4:30 PM Heiko Stübner <heiko@sntech.de> wrote:
> > Am Montag, 12. April 2021, 14:13:37 CEST schrieb Andy Shevchenko:
> > > On Sun, Apr 11, 2021 at 4:35 PM Peter Geis <pgwipeout@gmail.com> wrote:
> > > >
> > > > Separate gpio driver from pinctrl driver, and support v2 controller.
> > > >
> > > > Tested on rk3566-quartz64 prototype board.
> > >
> > > Can you give a bit more context?
> > > Usually separation means that hardware is represented by two different
> > > IP blocks that are (almost) independent to each other. Was it the case
> > > on the original platforms? Do you have different pin controller (or
> > > it's absent completely) on some new / old platform?
> >
> > They are separate on all Rockchip SoCs.
> >
> > I.e. the pinconfig (muxing, pulls, etc) is done via some registers inside
> > the "General Register Files" [area for misc registers]
> > and control for the gpio functionality is done in separate blocks
> > for each bank.
> >
> > Lumping that stuff together into one driver, was a design-mistake
> > from younger-me back in 2013 ;-)
>
> Thanks!
>
> To the submitter: Just for the future, please elaborate such things in
> the cover letter.
Apologies, I only rebased the work and reused the original cover letter.
I'll keep that in mind if this sort of situation arises again.
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2021-04-12 15:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-11 13:30 [PATCH v2 0/7] gpio-rockchip driver Peter Geis
2021-04-11 13:30 ` [PATCH v2 1/7] pinctrl/rockchip: separate struct rockchip_pin_bank to a head file Peter Geis
2021-04-11 13:30 ` [PATCH v2 2/7] pinctrl/pinctrl-rockchip.h: add pinctrl device to gpio bank struct Peter Geis
2021-04-11 13:30 ` [PATCH v2 3/7] gpio: separate gpio driver from pinctrl-rockchip driver Peter Geis
2021-04-11 17:51 ` Johan Jonker
2021-04-11 17:55 ` Heiko Stübner
2021-04-11 17:58 ` Ezequiel Garcia
2021-04-13 9:48 ` Johan Jonker
2021-04-11 13:30 ` [PATCH v2 4/7] gpio/rockchip: use struct rockchip_gpio_regs for gpio controller Peter Geis
2021-04-11 13:30 ` [PATCH v2 5/7] gpio/rockchip: support next version " Peter Geis
2021-04-11 13:30 ` [PATCH v2 6/7] gpio/rockchip: always enable clock for " Peter Geis
2021-04-11 13:30 ` [PATCH v2 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type Peter Geis
2021-04-12 12:13 ` [PATCH v2 0/7] gpio-rockchip driver Andy Shevchenko
2021-04-12 13:30 ` Heiko Stübner
2021-04-12 13:33 ` Andy Shevchenko
2021-04-12 15:00 ` Peter Geis [this message]
2021-04-14 7:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMdYzYrSwLd7zAo840VvQNs48ki1kwS2LdL+N96aVKrmrMRWbw@mail.gmail.com \
--to=pgwipeout@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=jay.xu@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).