From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753104Ab2DRVtQ (ORCPT ); Wed, 18 Apr 2012 17:49:16 -0400 Received: from mail-qa0-f53.google.com ([209.85.216.53]:47950 "EHLO mail-qa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751839Ab2DRVtO (ORCPT ); Wed, 18 Apr 2012 17:49:14 -0400 MIME-Version: 1.0 In-Reply-To: <4F8F30F5.9030704@zytor.com> References: <1329696488-16970-1-git-send-email-hpa@zytor.com> <4F8EFE4D.2040201@zytor.com> <4F8F0385.5090901@zytor.com> <4F8F0614.9010604@zytor.com> <4F8F30F5.9030704@zytor.com> Date: Wed, 18 Apr 2012 14:49:13 -0700 Message-ID: Subject: Re: [tip:x86/x32] x32: Fix alignment fail in struct compat_siginfo From: "H.J. Lu" To: "H. Peter Anvin" Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, linux-tip-commits@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 18, 2012 at 2:24 PM, H. Peter Anvin wrote: > Something like this works for you? > > Note: we should promote __compat_[us]64 to a global type when we do the > cleanup work requested by Linus (change __[us]64 to explicitly aligned > types, with all users that require the old types using __compat_[us]64), It looks good to me. > but we need the compiler warning to do that, realistically. > I think you mentioned to me about this. Have you opened a gcc bug to request to this feature? Thanks. -- H.J.