* [PATCH] drivers/gpu/drm/gma500:fix build failure for 3.9-rc5
@ 2013-04-09 6:35 Xiong Zhou
2013-04-09 20:22 ` Patrik Jakobsson
0 siblings, 1 reply; 4+ messages in thread
From: Xiong Zhou @ 2013-04-09 6:35 UTC (permalink / raw)
To: airlied, alan, dri-devel; +Cc: linux-kernel
From: Xiong Zhou <jencce.kernel@gmail.com>
This patch fixes build failure of v3.9-rc5.
When config ACPI_VIDEO as m, DRM_GMA500 as y, here comes the failure.
gma5/600 needs acpi_video just like nouveau.
Failure message:
drivers/built-in.o: In function `psb_driver_load':
kernel-3.9-rc5/drivers/gpu/drm/gma500/psb_drv.c:340: \
undefined reference to `acpi_video_register'
make: *** [vmlinux] Error 1
Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
---
drivers/gpu/drm/gma500/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig
index 1188f0f..d64fc45 100644
--- a/drivers/gpu/drm/gma500/Kconfig
+++ b/drivers/gpu/drm/gma500/Kconfig
@@ -6,6 +6,7 @@ config DRM_GMA500
select FB_CFB_IMAGEBLIT
select DRM_KMS_HELPER
select DRM_TTM
+ select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT
help
Say yes for an experimental 2D KMS framebuffer driver for the
Intel GMA500 ('Poulsbo') and other Intel IMG based graphics
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/gpu/drm/gma500:fix build failure for 3.9-rc5
2013-04-09 6:35 [PATCH] drivers/gpu/drm/gma500:fix build failure for 3.9-rc5 Xiong Zhou
@ 2013-04-09 20:22 ` Patrik Jakobsson
2013-04-10 11:56 ` Xiong Zhou
0 siblings, 1 reply; 4+ messages in thread
From: Patrik Jakobsson @ 2013-04-09 20:22 UTC (permalink / raw)
To: Xiong Zhou; +Cc: airlied, alan, dri-devel, linux-kernel
On Tue, Apr 9, 2013 at 8:35 AM, Xiong Zhou <jencce.kernel@gmail.com> wrote:
> From: Xiong Zhou <jencce.kernel@gmail.com>
>
> This patch fixes build failure of v3.9-rc5.
> When config ACPI_VIDEO as m, DRM_GMA500 as y, here comes the failure.
> gma5/600 needs acpi_video just like nouveau.
>
> Failure message:
> drivers/built-in.o: In function `psb_driver_load':
> kernel-3.9-rc5/drivers/gpu/drm/gma500/psb_drv.c:340: \
> undefined reference to `acpi_video_register'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
> ---
> drivers/gpu/drm/gma500/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig
> index 1188f0f..d64fc45 100644
> --- a/drivers/gpu/drm/gma500/Kconfig
> +++ b/drivers/gpu/drm/gma500/Kconfig
> @@ -6,6 +6,7 @@ config DRM_GMA500
> select FB_CFB_IMAGEBLIT
> select DRM_KMS_HELPER
> select DRM_TTM
> + select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT
> help
> Say yes for an experimental 2D KMS framebuffer driver for the
> Intel GMA500 ('Poulsbo') and other Intel IMG based graphics
> --
Hi
Thanks for catching this, but if I can be picky, I'd prefer if you wrote it
like i915 does. E.g.
select ACPI_VIDEO if ACPI
select BACKLIGHT_CLASS_DEVICE if ACPI
...
And you can skip X86 since we already 'depend' on it.
Thanks
Patrik
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/gpu/drm/gma500:fix build failure for 3.9-rc5
2013-04-09 20:22 ` Patrik Jakobsson
@ 2013-04-10 11:56 ` Xiong Zhou
0 siblings, 0 replies; 4+ messages in thread
From: Xiong Zhou @ 2013-04-10 11:56 UTC (permalink / raw)
To: Patrik Jakobsson; +Cc: Xiong Zhou, airlied, alan, dri-devel, linux-kernel
On Tue, 9 Apr 2013, Patrik Jakobsson wrote:
> On Tue, Apr 9, 2013 at 8:35 AM, Xiong Zhou <jencce.kernel@gmail.com> wrote:
> > From: Xiong Zhou <jencce.kernel@gmail.com>
> >
> > This patch fixes build failure of v3.9-rc5.
> > When config ACPI_VIDEO as m, DRM_GMA500 as y, here comes the failure.
> > gma5/600 needs acpi_video just like nouveau.
> >
> > Failure message:
> > drivers/built-in.o: In function `psb_driver_load':
> > kernel-3.9-rc5/drivers/gpu/drm/gma500/psb_drv.c:340: \
> > undefined reference to `acpi_video_register'
> > make: *** [vmlinux] Error 1
> >
> > Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
> > ---
> > drivers/gpu/drm/gma500/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig
> > index 1188f0f..d64fc45 100644
> > --- a/drivers/gpu/drm/gma500/Kconfig
> > +++ b/drivers/gpu/drm/gma500/Kconfig
> > @@ -6,6 +6,7 @@ config DRM_GMA500
> > select FB_CFB_IMAGEBLIT
> > select DRM_KMS_HELPER
> > select DRM_TTM
> > + select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT
> > help
> > Say yes for an experimental 2D KMS framebuffer driver for the
> > Intel GMA500 ('Poulsbo') and other Intel IMG based graphics
> > --
>
> Hi
>
> Thanks for catching this, but if I can be picky, I'd prefer if you wrote it
> like i915 does. E.g.
>
> select ACPI_VIDEO if ACPI
> select BACKLIGHT_CLASS_DEVICE if ACPI
> ...
>
> And you can skip X86 since we already 'depend' on it.
>
> Thanks
> Patrik
>
Nice advices, Thanks!
Xiong
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drivers/gpu/drm/gma500:fix build failure for 3.9-rc5
@ 2013-04-07 6:32 Xiong Zhou
0 siblings, 0 replies; 4+ messages in thread
From: Xiong Zhou @ 2013-04-07 6:32 UTC (permalink / raw)
To: linux-kernel, airlied; +Cc: daniel.vetter, alan, dri-devel
From: Xiong Zhou <jencce.kernel@gmail.com>
This patch fixes build failure of v3.9-rc5.
When config ACPI_VIDEO as m, DRM_GMA500 as y, here comes the failure.
gma5/600 needs acpi_video just like nouveau.
Failure message:
drivers/built-in.o: In function `psb_driver_load':
kernel-3.9-rc5/drivers/gpu/drm/gma500/psb_drv.c:340: \
undefined reference to `acpi_video_register'
make: *** [vmlinux] Error 1
Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
---
drivers/gpu/drm/gma500/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig
index 1188f0f..d64fc45 100644
--- a/drivers/gpu/drm/gma500/Kconfig
+++ b/drivers/gpu/drm/gma500/Kconfig
@@ -6,6 +6,7 @@ config DRM_GMA500
select FB_CFB_IMAGEBLIT
select DRM_KMS_HELPER
select DRM_TTM
+ select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT
help
Say yes for an experimental 2D KMS framebuffer driver for the
Intel GMA500 ('Poulsbo') and other Intel IMG based graphics
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-10 11:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-09 6:35 [PATCH] drivers/gpu/drm/gma500:fix build failure for 3.9-rc5 Xiong Zhou
2013-04-09 20:22 ` Patrik Jakobsson
2013-04-10 11:56 ` Xiong Zhou
-- strict thread matches above, loose matches on Subject: below --
2013-04-07 6:32 Xiong Zhou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).