* [PATCH] drm/gma500: add a missed gma_power_end in error path
@ 2019-12-09 8:57 Chuhong Yuan
2019-12-09 20:35 ` Patrik Jakobsson
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2019-12-09 8:57 UTC (permalink / raw)
Cc: Patrik Jakobsson, David Airlie, Daniel Vetter, dri-devel,
linux-kernel, Chuhong Yuan
oaktrail_lvds_mode_set() misses a gma_power_end() in an error path.
Add the call to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/gma500/oaktrail_lvds.c b/drivers/gpu/drm/gma500/oaktrail_lvds.c
index 7390403ea1b7..582e09597500 100644
--- a/drivers/gpu/drm/gma500/oaktrail_lvds.c
+++ b/drivers/gpu/drm/gma500/oaktrail_lvds.c
@@ -117,6 +117,7 @@ static void oaktrail_lvds_mode_set(struct drm_encoder *encoder,
if (!connector) {
DRM_ERROR("Couldn't find connector when setting mode");
+ gma_power_end(dev);
return;
}
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/gma500: add a missed gma_power_end in error path
2019-12-09 8:57 [PATCH] drm/gma500: add a missed gma_power_end in error path Chuhong Yuan
@ 2019-12-09 20:35 ` Patrik Jakobsson
0 siblings, 0 replies; 2+ messages in thread
From: Patrik Jakobsson @ 2019-12-09 20:35 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: David Airlie, Daniel Vetter, dri-devel, linux-kernel
On Mon, Dec 9, 2019 at 9:57 AM Chuhong Yuan <hslester96@gmail.com> wrote:
>
> oaktrail_lvds_mode_set() misses a gma_power_end() in an error path.
> Add the call to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Hi Chuhong, thanks for the patch.
Applied to drm-misc-next
-Patrik
> ---
> drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/gma500/oaktrail_lvds.c b/drivers/gpu/drm/gma500/oaktrail_lvds.c
> index 7390403ea1b7..582e09597500 100644
> --- a/drivers/gpu/drm/gma500/oaktrail_lvds.c
> +++ b/drivers/gpu/drm/gma500/oaktrail_lvds.c
> @@ -117,6 +117,7 @@ static void oaktrail_lvds_mode_set(struct drm_encoder *encoder,
>
> if (!connector) {
> DRM_ERROR("Couldn't find connector when setting mode");
> + gma_power_end(dev);
> return;
> }
>
> --
> 2.24.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-09 20:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 8:57 [PATCH] drm/gma500: add a missed gma_power_end in error path Chuhong Yuan
2019-12-09 20:35 ` Patrik Jakobsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).