* [PATCH] drm/gma500: remove redundant ret variable
@ 2022-01-12 8:25 cgel.zte
2022-01-12 8:51 ` Patrik Jakobsson
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-01-12 8:25 UTC (permalink / raw)
To: patrik.r.jakobsson
Cc: airlied, daniel, dri-devel, linux-kernel, Minghao Chi,
Zeal Robot, CGEL ZTE
From: Minghao Chi <chi.minghao@zte.com.cn>
Return value directly instead of taking this in another redundant
variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
---
drivers/gpu/drm/gma500/cdv_intel_dp.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c
index ba6ad1466374..74e67679714e 100644
--- a/drivers/gpu/drm/gma500/cdv_intel_dp.c
+++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c
@@ -82,7 +82,6 @@ i2c_algo_dp_aux_address(struct i2c_adapter *adapter, u16 address, bool reading)
{
struct i2c_algo_dp_aux_data *algo_data = adapter->algo_data;
int mode = MODE_I2C_START;
- int ret;
if (reading)
mode |= MODE_I2C_READ;
@@ -90,8 +89,7 @@ i2c_algo_dp_aux_address(struct i2c_adapter *adapter, u16 address, bool reading)
mode |= MODE_I2C_WRITE;
algo_data->address = address;
algo_data->running = true;
- ret = i2c_algo_dp_aux_transaction(adapter, mode, 0, NULL);
- return ret;
+ return i2c_algo_dp_aux_transaction(adapter, mode, 0, NULL);
}
/*
@@ -122,13 +120,11 @@ static int
i2c_algo_dp_aux_put_byte(struct i2c_adapter *adapter, u8 byte)
{
struct i2c_algo_dp_aux_data *algo_data = adapter->algo_data;
- int ret;
if (!algo_data->running)
return -EIO;
- ret = i2c_algo_dp_aux_transaction(adapter, MODE_I2C_WRITE, byte, NULL);
- return ret;
+ return i2c_algo_dp_aux_transaction(adapter, MODE_I2C_WRITE, byte, NULL);
}
/*
@@ -139,13 +135,11 @@ static int
i2c_algo_dp_aux_get_byte(struct i2c_adapter *adapter, u8 *byte_ret)
{
struct i2c_algo_dp_aux_data *algo_data = adapter->algo_data;
- int ret;
if (!algo_data->running)
return -EIO;
- ret = i2c_algo_dp_aux_transaction(adapter, MODE_I2C_READ, 0, byte_ret);
- return ret;
+ return i2c_algo_dp_aux_transaction(adapter, MODE_I2C_READ, 0, byte_ret);
}
static int
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/gma500: remove redundant ret variable
2022-01-12 8:25 [PATCH] drm/gma500: remove redundant ret variable cgel.zte
@ 2022-01-12 8:51 ` Patrik Jakobsson
0 siblings, 0 replies; 2+ messages in thread
From: Patrik Jakobsson @ 2022-01-12 8:51 UTC (permalink / raw)
To: cgel.zte
Cc: David Airlie, Daniel Vetter, dri-devel, linux-kernel,
Minghao Chi, Zeal Robot
On Wed, Jan 12, 2022 at 9:25 AM <cgel.zte@gmail.com> wrote:
>
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value directly instead of taking this in another redundant
> variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
Thanks for the patch. I'll apply this to drm-misc-next
-Patrik
> ---
> drivers/gpu/drm/gma500/cdv_intel_dp.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c
> index ba6ad1466374..74e67679714e 100644
> --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c
> +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c
> @@ -82,7 +82,6 @@ i2c_algo_dp_aux_address(struct i2c_adapter *adapter, u16 address, bool reading)
> {
> struct i2c_algo_dp_aux_data *algo_data = adapter->algo_data;
> int mode = MODE_I2C_START;
> - int ret;
>
> if (reading)
> mode |= MODE_I2C_READ;
> @@ -90,8 +89,7 @@ i2c_algo_dp_aux_address(struct i2c_adapter *adapter, u16 address, bool reading)
> mode |= MODE_I2C_WRITE;
> algo_data->address = address;
> algo_data->running = true;
> - ret = i2c_algo_dp_aux_transaction(adapter, mode, 0, NULL);
> - return ret;
> + return i2c_algo_dp_aux_transaction(adapter, mode, 0, NULL);
> }
>
> /*
> @@ -122,13 +120,11 @@ static int
> i2c_algo_dp_aux_put_byte(struct i2c_adapter *adapter, u8 byte)
> {
> struct i2c_algo_dp_aux_data *algo_data = adapter->algo_data;
> - int ret;
>
> if (!algo_data->running)
> return -EIO;
>
> - ret = i2c_algo_dp_aux_transaction(adapter, MODE_I2C_WRITE, byte, NULL);
> - return ret;
> + return i2c_algo_dp_aux_transaction(adapter, MODE_I2C_WRITE, byte, NULL);
> }
>
> /*
> @@ -139,13 +135,11 @@ static int
> i2c_algo_dp_aux_get_byte(struct i2c_adapter *adapter, u8 *byte_ret)
> {
> struct i2c_algo_dp_aux_data *algo_data = adapter->algo_data;
> - int ret;
>
> if (!algo_data->running)
> return -EIO;
>
> - ret = i2c_algo_dp_aux_transaction(adapter, MODE_I2C_READ, 0, byte_ret);
> - return ret;
> + return i2c_algo_dp_aux_transaction(adapter, MODE_I2C_READ, 0, byte_ret);
> }
>
> static int
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-12 8:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-12 8:25 [PATCH] drm/gma500: remove redundant ret variable cgel.zte
2022-01-12 8:51 ` Patrik Jakobsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).